Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 24 Sep 2022 00:09:32 +0900
From:   Jiho Chu <jiho.chu@samsung.com>
To:     "Arnd Bergmann" <arnd@arndb.de>
Cc:     "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
        ogabbay@kernel.org,
        "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
        "Mark Brown" <broonie@kernel.org>, linux-kernel@vger.kernel.org,
        yelini.jeong@samsung.com, myungjoo.ham@samsung.com
Subject: Re: [PATCH v2 01/13] trinity: Add base driver
Message-Id: <20220924000932.689c44f37abecb153175ed8b@samsung.com>
In-Reply-To: <51275e33-c791-4593-84d1-eedad27d7fd6@www.fastmail.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <20220917072356.2255620-1-jiho.chu@samsung.com>
        <CGME20220917072357epcas1p17b277154f0d020435417450fa0337906@epcas1p1.samsung.com>
        <20220917072356.2255620-2-jiho.chu@samsung.com>
        <e035ac54-35af-4e86-a74a-9a4c7f936a19@www.fastmail.com>
        <20220917234918.8b94d2690b8533bd47cf64e0@samsung.com>
        <51275e33-c791-4593-84d1-eedad27d7fd6@www.fastmail.com>
Precedence: bulk

On Thu, 22 Sep 2022 15:56:51 +0200
"Arnd Bergmann" <arnd@arndb.de> wrote:

> On Sat, Sep 17, 2022, at 4:49 PM, Jiho Chu wrote:
> > On Sat, 17 Sep 2022 09:41:13 +0200
> > "Arnd Bergmann" <arnd@arndb.de> wrote:
> >> 
> >> If you have the need to manage multiple devices here, maybe use
> >> a dynamic major number and have the chardev code allocate the
> >> minor numbers, instead of using multiple misc devices and
> >> doing that yourself.
> >> 
> >
> > I'm little confusing. It means that managing own char devices is proper,
> > not using misc device? But, it's still under misc dir.
> 
> There is no strict connection between miscdevices and drivers/misc.
> 
> The former is for drivers that tend to have only one instance
> in a system, while the latter is for drivers that do not have
> a separate subsystem.
> 
>      Arnd
> 

Thanks for the clarification. Allocating a dynamic major could be better
for trinity, which could have multiple instances.
I'll rewrite code for it in next revision.

Best regards,
Jiho chu