Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 23 Sep 2022 08:53:16 -0700
From:   Colin Foster <colin.foster@in-advantage.com>
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, netdev@vger.kernel.org,
        Russell King <linux@armlinux.org.uk>,
        Linus Walleij <linus.walleij@linaro.org>,
        UNGLinuxDriver@microchip.com,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Lee Jones <lee@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Vladimir Oltean <olteanv@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH v2 net-next 08/14] net: dsa: felix: update init_regmap to
 be string-based
Message-ID: <Yy3WbBjMNllNQ+gs@euler>
References: <20220922040102.1554459-1-colin.foster@in-advantage.com>
 <20220922040102.1554459-9-colin.foster@in-advantage.com>
 <20220922193906.7ab18960@kernel.org>
 <20220922194009.276371fc@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220922194009.276371fc@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?UWhdYAtk3KU9vFWW3/BVBHaoHeGakVQLDucwkhC06CAxZwu0BCYqhfc2M0IU?=
 =?us-ascii?Q?9mcY/+ZCRXHEVuevmrlMJblfDdIjjHcDSNqtUAGiYY6NolsoUs/EqMwA569U?=
 =?us-ascii?Q?RVZxXjExXEy56MUmciVagYXNX4ealQ0qtIGCqU2DXLdjTHto0fN39JTB9rER?=
 =?us-ascii?Q?yuvyMnilN4L4ZNGbki+rb1zjL1XGswM47kfQANBdmyYVFTGxX3sdMzEiO6Cl?=
 =?us-ascii?Q?s9rkQCvBQEnScty09NsjD45VfElcv+9s1eZTqp9xHX6mj485e58gCoZ2hlyp?=
 =?us-ascii?Q?oWENEmZsJ30qW2M5eRMSH1B1cHDuw3X00aamyxSVgD+ZccmA2nbeVdZdevqd?=
 =?us-ascii?Q?GdV20tb1hDXKSMaL6TofKafA5u8SKTLr0oZ7WA41bYOfBvhxqXyRH9uf6kQP?=
 =?us-ascii?Q?b2yC+iRgzRL4pCULOwpVOqzPzAZxfhdnTx/qBQvJIyYCCP6In7Gie6cFWM1h?=
 =?us-ascii?Q?WIEbLHqATSgtRiqQeGzWALM2REknfDHGAP5adI7bK+8rLZbXWMFfRMfHOXXJ?=
 =?us-ascii?Q?JeozJ7OqCBWXpZ2E1nVF4PeKw17SH2gyPBH2TTcc/e1I7oZ4NUTgKLuakvlH?=
 =?us-ascii?Q?gPIbU0up7s9vErhgL5dOEIep5K/l7NhW1mTx3BpR3ud44/xyt2PmnhUG+jwb?=
 =?us-ascii?Q?yVHbqegfXQ8EeoAoOL9huS7597GjhrgRky64HyexLnH2o6Zl6f8dmJbVm98E?=
 =?us-ascii?Q?8Uefy2pH6G01XHBL7u0C1AvyV8C6Lf6l5mbjbf8S0qTZIlh2rxHzbQe4avxh?=
 =?us-ascii?Q?1wqQ6smaleoCTEgFR7LoHwxRMkO50XBDJRIAjv+9ijodOCeEEp0AlMXhgkat?=
 =?us-ascii?Q?9+7FVpMspzur2duHuBolUd/g/NIr9w+h/4mGvL2H0IDrvgTzTf75HAs1+Y5d?=
 =?us-ascii?Q?Kz+TgO/1pjD43ur11Hhwf8PiIt5QBDgPN8GePxbWvBHbXZ9hq5wF4NWRCOOI?=
 =?us-ascii?Q?jCrR5ukUc5/gTQ9NpT9XAm7WE+lZfNEgvdmyPTy6zXYkMViot+2Wth/ePni1?=
 =?us-ascii?Q?z9qbsq0s3dJ+7HfxSv76OOKw+dp9p9PN6AGqwN8NAbNE+pEXg+4mWjJj8j9c?=
 =?us-ascii?Q?kWh1uQOA4EPPCUQ0GGrsrSyHkJ/1NtkEwT4i7tQ2rrXvkaeMrZUaYjbq9yr1?=
 =?us-ascii?Q?WB1KJTPqVMoMMsEIvUzW0uD6TfLNFcXf0tBSihvsDujZ6WCFirP2HgTuwdj1?=
 =?us-ascii?Q?N4qidjerLsYmKGqK/iWgwO5X58eVaf/VoQ81281XaOAFLXmRpy+9AZYmvg6X?=
 =?us-ascii?Q?DEyJTuE690/JCy1Ul2bDHFPT9p25oROoyCV1S9ZBVfk2zObL9PYtzyr0bK4K?=
 =?us-ascii?Q?mkB16mvklgylISsaj8ZOdul5dvlcYvWLPU76hXM9b4f0YmRbiZQkkOs3itKV?=
 =?us-ascii?Q?rltXT896cs++g9NiPLfdCJiWYEyVEGXk0ctqw6E8nmzy2mWkUADxPUeGTUt6?=
 =?us-ascii?Q?Yz1WbwZnJzHTaPvSgd/eIL3pbLCD3nCDJW2nMxOTiiwjlw+1LifbEsVERyrN?=
 =?us-ascii?Q?RMMrihv544ud1RqvvQE64gWkVSp9Fec05ulLtzngcDXi3syw6NOzS8S3pki0?=
 =?us-ascii?Q?Yglk+p3LKvSaViq4Wgm3sBqe6WVQAGjS5alkr4RT41PTe4I0rgcrD0ZeIN6i?=
 =?us-ascii?Q?RA=3D=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 804b2662-cf00-4f93-b5ab-08da9d7bbcf8
X-MS-Exchange-CrossTenant-AuthSource: DM5PR1001MB2345.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2022 15:53:20.5644
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ervM7lSRtiG95/RY2t0570Euma9WZMFNTIueaUL9wN/pGM5/pasMNrUD85YOqfzS241mkn8ZXxPtNFBAVG2cUHjB/mS025NHjZcfhlcCyFs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB5173
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Sep 22, 2022 at 07:40:09PM -0700, Jakub Kicinski wrote:
> On Thu, 22 Sep 2022 19:39:06 -0700 Jakub Kicinski wrote:
> > On Wed, 21 Sep 2022 21:00:56 -0700 Colin Foster wrote:
> > > During development, it was believed that a wrapper for ocelot_regmap_init()
> > > would be sufficient for the felix driver to work in non-mmio scenarios.
> > > This was merged in during commit 242bd0c10bbd ("net: dsa: ocelot: felix:
> > > add interface for custom regmaps")
> > > 
> > > As the external ocelot DSA driver grew closer to an acceptable state, it
> > > was realized that most of the parameters that were passed in from struct
> > > resource *res were useless and ignored. This is due to the fact that the
> > > external ocelot DSA driver utilizes dev_get_regmap(dev, resource->name).
> > > 
> > > Instead of simply ignoring those parameters, refactor the API to only
> > > require the name as an argument. MMIO scenarios this will reconstruct the
> > > struct resource before calling ocelot_regmap_init(ocelot, resource). MFD
> > > scenarios need only call dev_get_regmap(dev, name).
> 
> Ah, and the modpost:
> 
> ERROR: modpost: drivers/net/dsa/ocelot/mscc_seville: 'felix_init_regmap' exported twice. Previous export was in drivers/net/dsa/ocelot/mscc_felix.ko

Yep. Since felix.c gets compiled into both drivers I don't need to
export the symbol.

And there's the NULL assignment. That one I'm surprised doesn't throw a
warning... Looking forward to more feedback before I send out v3 next
week.