Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 23 Sep 2022 08:44:25 -0700
From:   Ashok Raj <ashok.raj@intel.com>
To:     Dave Hansen <dave.hansen@intel.com>
CC:     Jason Gunthorpe <jgg@nvidia.com>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        Jacob Pan <jacob.jun.pan@intel.com>,
        "Kirill A. Shutemov" <kirill@shutemov.name>,
        Ashok Raj <ashok_raj@linux.intel.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "Andy Lutomirski" <luto@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>, <x86@kernel.org>,
        Kostya Serebryany <kcc@google.com>,
        Andrey Ryabinin <ryabinin.a.a@gmail.com>,
        Andrey Konovalov <andreyknvl@gmail.com>,
        "Alexander Potapenko" <glider@google.com>,
        Taras Madan <tarasmadan@google.com>,
        "Dmitry Vyukov" <dvyukov@google.com>,
        "H . J . Lu" <hjl.tools@gmail.com>,
        Andi Kleen <ak@linux.intel.com>,
        Rick Edgecombe <rick.p.edgecombe@intel.com>,
        <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
        Joerg Roedel <joro@8bytes.org>, Ashok Raj <ashok.raj@intel.com>
Subject: Re: [PATCHv8 00/11] Linear Address Masking enabling
Message-ID: <Yy3UWTLdIldKIfgu@araj-MOBL2.amr.corp.intel.com>
References: <YytFGqv5V4T8lbM8@araj-MOBL2.amr.corp.intel.com>
 <f1aac14e-380c-f76f-84bb-fdff56207d2f@intel.com>
 <YytT1hfRZdb9GYQK@nvidia.com>
 <20220923004239.ma2gfrmoezsff4ro@box.shutemov.name>
 <Yy1D0dLdqTr7ya71@a4bf019067fa.jf.intel.com>
 <20220923093826.kjad4qe3clwybeh6@box.shutemov.name>
 <Yy2cfppqkf85hPT7@nvidia.com>
 <fd1f54b5-010d-da65-3989-d8cf727261c7@intel.com>
 <Yy3QpOnsNJQ6MykN@araj-MOBL2.amr.corp.intel.com>
 <c3fb5e4f-a906-bdee-7b34-533f36ba59f7@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <c3fb5e4f-a906-bdee-7b34-533f36ba59f7@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?pSOlXrVkBNe87q9QozdR+NeW8OQ4aGtLTskeVsQrgQQOy1P6VZHsFHq1Vq4C?=
 =?us-ascii?Q?NdF2f0MGpqoJC1Bt/pAbRJUiFT6bDLB6JZPng+HJupUwQVZNoIGFV6I53BLU?=
 =?us-ascii?Q?r+XmWag3YC7SUx7VcCol25WW0Rqx+fYlsebf9tMYS1dlj+HJi8juwiUoZOj+?=
 =?us-ascii?Q?BPBeWXYp7n2pzjO3y4clNaBMtjdR6ncecczk3A5eY034/Axu5Cl/6muLLqEU?=
 =?us-ascii?Q?pjvR1uxBdy88cnT76pHETxZk9qjTXwJm8++WA6vIlRwMXg/LLPyV/NNiy8WA?=
 =?us-ascii?Q?lgfuH4u494XjfUG3nFingLHE568AejD58E08tKjkJHCKFCWCJMl6/E6lIr+E?=
 =?us-ascii?Q?2ULmduZev089lbdF8nl6fMWe79dJKJlWQBTGvN5O05BFil6NFSZH3ygCtwlx?=
 =?us-ascii?Q?l7fcoJFUWGnomsOZphV/XdtObpeO3wDxZgybKT8Ul+Ilnq6L2LMYaQasQvs+?=
 =?us-ascii?Q?zRoLTLNKmlA7KHr5G4KBRcw+q4iGEAWhyzBdH0jFiP+gACFVpQqPU/6X36xg?=
 =?us-ascii?Q?yJLhAALN6Phc/l0/5BRegwuwlLJkHLlbwJng0hTCtFF5DuHOF8j2TgJI5Fsn?=
 =?us-ascii?Q?Zs5wp5ll08/2pnq7K8vwg4y1CK7ba3Srd6jbg43YVJ5d7F8L5MH9xyafw8X/?=
 =?us-ascii?Q?NLvhszwLz9pJCML64Wpe896KG5ERW3CfqyhE9Rn5rcl90PpKsY8opCXv4HIV?=
 =?us-ascii?Q?+9yJNHOumU2tCKTFU2IaXC2OSo7JkfMpkd9ZKnN1LoQlAojW0YOlq7drJ97Y?=
 =?us-ascii?Q?36ygnMWYkVEobenusUkv1/lWQuYkyUuIruV9Xo6kj9GP4eGQp/UtTVYf4mGX?=
 =?us-ascii?Q?4SkVwgcfx3wCFUQ/CUPfHu/gHl5lAj0EkBQrHBLfOeapHMwWrFSDoTM+gLrh?=
 =?us-ascii?Q?0uT0zuzvNEHbL3Ye2YnToQ2n3pkKvndc4Cahpw7//SrrAkTKQW1uVi36kkhE?=
 =?us-ascii?Q?oHoSa5a6JV8JV4ERSsSI0dByzNZuwpbl7UkqnCcUFJn34DFRV6YtkxGfslPs?=
 =?us-ascii?Q?hdk9DURISpAO+WChXWUhRw2urHZJdxa/223FZb7cacubsoyccHsV/jfL44sc?=
 =?us-ascii?Q?465ACQouU0GsdMqrpu6j3p/z1V28izFtXgI9MtKvcxPPsOZIBINoaJ4PykPL?=
 =?us-ascii?Q?fTBvVI6QdgxiMN4/CjtrzrbMFa5+BrfGB40ouugA1dSMTACWFievo38zP3jL?=
 =?us-ascii?Q?8aOzPTXWK8XA2UlZOh2vt36U0N3/O6JxbTM8BzAWlLuh5w+RnIlPD2I8wfs3?=
 =?us-ascii?Q?dWm2waU0VdEEXdn8BrtwActXPXT1IVsboI9/hz2+1xnnEM+aDn+58PLU58lk?=
 =?us-ascii?Q?VwOPN/Qxxxlx1rJOsqXsIL75uYQweniZ/Bax1isUxjoeKtA3uhENPNfmjWmL?=
 =?us-ascii?Q?fKGLh0WkyHGXPlRhecdeKjdLEkMZ+vYDu+jWeJ9haSH0dlfA4eWoKy2K83IJ?=
 =?us-ascii?Q?Y8OgMLvC0yF6GRWkiaGG3oB5l5mTZcb+F6FEsc8h7gLDCUJ8Yn+UVGye56nl?=
 =?us-ascii?Q?i8jaoAJAG3fq00v/zJdJBXwKJL+TlvvEhCzDGaf7A96GQmumdUgxB1qJAa4l?=
 =?us-ascii?Q?VX1VXmYSuQqL3TfWoTCOyGIQceWZRqtdh+fM+dn6?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9be27f4c-633a-4213-c174-08da9d7a7ff9
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6201.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2022 15:44:28.6397
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZTF7UxYUZSTboJT+GToAocADtT20iiyLFHagR5vfjMQBKi1hZQO6hZTN2YrNbYJPQ1t/5yK1GXvQOmNojsViOQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5995
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Sep 23, 2022 at 08:31:13AM -0700, Dave Hansen wrote:
> On 9/23/22 08:28, Ashok Raj wrote:
> >>
> >> I thought devices also cached address translation responses from the
> >> IOMMU and stashed them in their own device-local TLB.  If the device is
> >> unaware of the tags, then how does device TLB invalidation work?  Would
> > This is coming a full circle now :-)
> > 
> > Since the device doesn't understand tagging, SVM and tagging aren't
> > compatible. If you need SVM, you can only send sanitized pointers to the
> > device period. In fact our page-request even looks for canonical checks
> > before doing the page-faulting.
> > 
> >> all device TLB flushes be full flushes of the devices TLB?  If something
> >> tried to use single-address invalidation, it would need to invalidate
> >> every possible tag alias because the device wouldn't know that the tags
> >> *are* tags instead of actual virtual addresses.
> > Once tagging is extended into the PCI SIG, and devices know to work with
> > them, so will the IOMMU, then they can all play in the same field. Until
> > then they are isolated, or let SVM only work with untagged VA's.
> 
> But, the point that Kirill and I were getting at is still that devices
> *have* a role to play here.  The idea that this can be hidden at the
> IOMMU layer is pure fantasy.  Right?

If you *can't* send tagged memory to the device, what is the
role the device need to play? 

For now you can only send proper VA's that are canonical.