Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 23 Sep 2022 18:24:34 +0200
From:   Wolfram Sang <wsa@kernel.org>
To:     Tharunkumar.Pasumarthi@microchip.com
Cc:     UNGLinuxDriver@microchip.com, krzk@kernel.org, arnd@arndb.de,
        andriy.shevchenko@linux.intel.com, robh@kernel.org,
        semen.protsenko@linaro.org, sven@svenpeter.dev,
        jarkko.nikula@linux.intel.com, linux-kernel@vger.kernel.org,
        linux-i2c@vger.kernel.org, jsd@semihalf.com, olof@lixom.net,
        rafal@milecki.pl
Subject: Re: [PATCH v4 i2c-master] i2c: microchip: pci1xxxx: Add driver for
 I2C host controller in multifunction endpoint of pci1xxxx switch
Message-ID: <Yy3dwhFSTBH9942n@shikoro>
Mail-Followup-To: Wolfram Sang <wsa@kernel.org>,
        Tharunkumar.Pasumarthi@microchip.com, UNGLinuxDriver@microchip.com,
        krzk@kernel.org, arnd@arndb.de, andriy.shevchenko@linux.intel.com,
        robh@kernel.org, semen.protsenko@linaro.org, sven@svenpeter.dev,
        jarkko.nikula@linux.intel.com, linux-kernel@vger.kernel.org,
        linux-i2c@vger.kernel.org, jsd@semihalf.com, olof@lixom.net,
        rafal@milecki.pl
References: <20220907161143.897289-1-tharunkumar.pasumarthi@microchip.com>
 <YyY1vESf5JalT6GR@shikoro>
 <55e6769b1d7e890f4211b44f821b11654a5b9f4d.camel@microchip.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="c+XyHOeASBRR/HeV"
Content-Disposition: inline
In-Reply-To: <55e6769b1d7e890f4211b44f821b11654a5b9f4d.camel@microchip.com>
Precedence: bulk


--c+XyHOeASBRR/HeV
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable


> > I need to make sure: do you intentionally want autoprobing for SPD? I
> > ask because it could be needed but it costs boottime when not needed.
> > And changing the class once exposed is troublesome.
>=20
> Autoprobing is not required. I can modify code.=20
>=20
> All these comments need to be addressed now or can be fixed later after t=
he
> patch is applied?

The issue above (autoprobing) should really not be fixed incrementally.
The other two issues could be, but if you need to resend anyhow, just
tackle them as well, please.

Thanks!


--c+XyHOeASBRR/HeV
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmMt3b4ACgkQFA3kzBSg
Kba0lw//ZuqZnoJAR1dk2RRZp2Eq2uaCuPCI7zXVK2N3XzgPVsDPG2pMEiMuJvHo
kW4j8rTbmCdGQnJ3ZC1f+CHPJkIT8UhH3NgSjG+agYVj9T3leY2pS/jF+vRhLQld
JJk9alBqn6JzPXDva3h89ZGZTyq4O3OYdCXAe0V4J9XUTxdS6y/Fj2Gy7GRdDZcq
LHmGqS8iKu8gi9YynUEdyyjYP/NKybvgUOu1cze9uGkEHgZdZTrmCZjgY39LE49b
b1csprsSoj/8i4OJ4y4D6PBYGM2hTNbF33Q6nGBfdzugT30sQLn6ENUV0SW9xAy0
MHyVdosnH7yMAjWXZ7BQU9p2VwdeymXgASQzaM5sW8qe2eg3RaDswmk0/EcD71er
PbXmHCsV/dv3YTJJoT+dMfuyKObgKQKdZnAzowFayCjoWkT7DYkZdKNvRVnCjh1Z
tZ/hMsX4CP4f14AnvCuMmFK8Vfbp71vok3mKlZVElKAJt7pUxs5Oa0fv9bU6Cd9v
hVxX7xxZB1U3UecqRgB4I9oVVjaB3pU0dWR/PCC/Kpue/UJTflezyHAnC4yJmBVH
WPSzAQ3t61K574LNo90SdxSA2gc/tMVQTbaPideLZyaDEnqQNKkiYGlz/oxQbWBA
B0C6JzfafzK2vqvIv6bXPkEQVAD/I1JoAll7L3WaXwv3+BEhe6A=
=jUZa
-----END PGP SIGNATURE-----

--c+XyHOeASBRR/HeV--