Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     netdev@vger.kernel.org
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
        Rui Sousa <rui.sousa@nxp.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        UNGLinuxDriver@microchip.com,
        Horatiu Vultur <horatiu.vultur@microchip.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Michael Walle <michael@walle.cc>,
        Vinicius Costa Gomes <vinicius.gomes@intel.com>,
        Maxim Kochetkov <fido_max@inbox.ru>,
        Colin Foster <colin.foster@in-advantage.com>,
        Richie Pearn <richard.pearn@nxp.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Vladimir Oltean <olteanv@gmail.com>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        Tony Nguyen <anthony.l.nguyen@intel.com>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        Jamal Hadi Salim <jhs@mojatatu.com>,
        Cong Wang <xiyou.wangcong@gmail.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Gerhard Engleder <gerhard@engleder-embedded.com>,
        linux-kernel@vger.kernel.org
Subject: [PATCH v2 net-next 02/12] tsnep: deny tc-taprio changes to per-tc max SDU
Date:   Fri, 23 Sep 2022 19:33:00 +0300
Message-Id: <20220923163310.3192733-3-vladimir.oltean@nxp.com>
In-Reply-To: <20220923163310.3192733-1-vladimir.oltean@nxp.com>
References: <20220923163310.3192733-1-vladimir.oltean@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?NGir6i9IyVOwh93IBTH2rlFe6O1qgE4kiqMU2xB7eilxjjxPvHLp03VNwavG?=
 =?us-ascii?Q?mLlJ+Lnbh0pJN/BJNgzxMz1T0AViSoKJ2ROcW2GT+BJNESY5JZr52EGGgWwB?=
 =?us-ascii?Q?dfV+hqxGsQurrIrAO/cwDj083WR3QIiLg3A2RzqZoKWyS1ePYC9W7QonRtPa?=
 =?us-ascii?Q?Q5jW1GD09HA4Yy6KNNjJBHbwSGXmh1KJA5x+dvQIlaaLHAxD+LFGODwiS/e5?=
 =?us-ascii?Q?mn2xiJ+ebddV4dGiy9ppqj7mNzDbSpxpWn/2syNDmk9YvcttSSRbgBzOoTi3?=
 =?us-ascii?Q?Y9jgrj39sjpsL8JTAy/GrLv64SDvaZGlaKqI9iXxnA9nCDYQz611U6Oqp+ZO?=
 =?us-ascii?Q?9BU2M6ct+aTbAFzjUqPo4UZG1KCr/R99q4h22vcWF8jGyciW2rtOoLcjntP3?=
 =?us-ascii?Q?m8I9vv2l/jVeix9g8W7DOD9QTz9PFSBv29t1+baiYFD7nqX787ISrgFYmmBv?=
 =?us-ascii?Q?aVceB/9d3R/7Hh0UNx8ZSC01RXdj4YZG3xb5QdhWn5PsVVcJJvTzK2oxxWVF?=
 =?us-ascii?Q?f2cmDmIKKEVUGlMuYly2B4AHbi5qejq+jfVDH42d2fXcjFs1c9nVS6HxYP0i?=
 =?us-ascii?Q?LJzlwQAkq9cYesC7686ajBU8yD7Ok83wMkuqlxrSNdXGUcdwh7zKbS0rKJD8?=
 =?us-ascii?Q?8Bv1aqobiqvMJ5ki89Ct+VGJYqJ7S1qBTeuOzfnVl3//AgXcRNMM59ybMZmo?=
 =?us-ascii?Q?kNV6DQd3yrA37dq+AVcXMHJdCelwO6er0x/UMqWAoH+Qio1ChlI8HG9lv9Ix?=
 =?us-ascii?Q?lYeVMRIMq6F4H6WJgHsPdt+qAydHBqXbHk5TV5BE3TuZ4DM4vKfMWZeyoZ4i?=
 =?us-ascii?Q?aYL8SY6JotpPqdizt33Fiy4FqcfhWkdSp0BNmXG2Xjn7LS9cW5cBWvSPo5Or?=
 =?us-ascii?Q?2ttQzwQgDd4Gtulxd5BFY3md/QDzEjVEj0vpxosAGB0HL5jqk8PrtZZUDEov?=
 =?us-ascii?Q?NecaNi3JSE2uL3TyHSldTdblIId3sCivmi5Jw+rYgtM7xCqPH9GGqNNZ+cSf?=
 =?us-ascii?Q?CUnTAVZk+tYphL3r9PFGfyiNxsLQfYo6KOjk5MVVbcAz8Gc7YtGDi1wKsIhg?=
 =?us-ascii?Q?IS+FRQuwj3+Kj496YehP10Uww45BL91HF8uE1z9gvNZp/VbqmNIWyb2yzBar?=
 =?us-ascii?Q?QXWxZVML25BSGeXe4fpFB2YbqQ0W7n1uPsNcDXFE3y6vgPi01qRyMCUP9MwK?=
 =?us-ascii?Q?oZEtkSEee74Xu7MQslJ6Hd0zqbeJdnQnRR27PlHRcOZJf9+s9KnLuFPY8Ouv?=
 =?us-ascii?Q?TIVrua/4n9lEgjdnyLwY0HYSwOrHkmIRMMFokCmLnT9nMEMexCPL7qm7jKzs?=
 =?us-ascii?Q?W73Z1vP+ugIKambUNNZyHA35D5GGeG8PqxmSaXF8GdlldidjL6d13nbOim2r?=
 =?us-ascii?Q?OlntqMXSvWv/QbOU2lBVe8XDKRYXwtOtPw0p/ldNQcOOpXdpVX8R4UsO+e3O?=
 =?us-ascii?Q?kdwkPAPBafUaFLqOXzZxemebjVBTmkNH4OvGpLoQ5MKfhrvQnltY1dhOFWTY?=
 =?us-ascii?Q?3dj2ZhkM2t1Sfl5R/i84jsT5ZwIk5jUgwyjVLr7ysE3EGDZUmLL6gAOXHdVJ?=
 =?us-ascii?Q?IH39ttVDd6JlpKa2k3IztBclVNbEE3NadllzXujwsSAYlsdov5JmVBSX3vWc?=
 =?us-ascii?Q?cA=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 782b1eb7-0857-4df8-3378-08da9d81585d
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2022 16:33:28.7847
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PFnj+okgWkNX6u8LwttD9vNNK2phhMkn3F0KAW9FFPNHEHQq+eK6cvChYQby16b4mPmGMfqLUGsr1aQsB1BvXQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7023
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Since the driver does not act upon the max_sdu argument, deny any other
values except the default all-zeroes, which means that all traffic
classes should use the same MTU as the port itself.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
v1->v2: none

 drivers/net/ethernet/engleder/tsnep_tc.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/engleder/tsnep_tc.c b/drivers/net/ethernet/engleder/tsnep_tc.c
index c4c6e1357317..82df837ffc54 100644
--- a/drivers/net/ethernet/engleder/tsnep_tc.c
+++ b/drivers/net/ethernet/engleder/tsnep_tc.c
@@ -320,11 +320,15 @@ static int tsnep_taprio(struct tsnep_adapter *adapter,
 {
 	struct tsnep_gcl *gcl;
 	struct tsnep_gcl *curr;
-	int retval;
+	int retval, tc;
 
 	if (!adapter->gate_control)
 		return -EOPNOTSUPP;
 
+	for (tc = 0; tc < TC_MAX_QUEUE; tc++)
+		if (qopt->max_sdu[tc])
+			return -EOPNOTSUPP;
+
 	if (!qopt->enable) {
 		/* disable gate control if active */
 		mutex_lock(&adapter->gate_control_lock);
-- 
2.34.1