Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     netdev@vger.kernel.org
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
        Rui Sousa <rui.sousa@nxp.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        UNGLinuxDriver@microchip.com,
        Horatiu Vultur <horatiu.vultur@microchip.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Michael Walle <michael@walle.cc>,
        Vinicius Costa Gomes <vinicius.gomes@intel.com>,
        Maxim Kochetkov <fido_max@inbox.ru>,
        Colin Foster <colin.foster@in-advantage.com>,
        Richie Pearn <richard.pearn@nxp.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Vladimir Oltean <olteanv@gmail.com>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        Tony Nguyen <anthony.l.nguyen@intel.com>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        Jamal Hadi Salim <jhs@mojatatu.com>,
        Cong Wang <xiyou.wangcong@gmail.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Gerhard Engleder <gerhard@engleder-embedded.com>,
        linux-kernel@vger.kernel.org
Subject: [PATCH v2 net-next 04/12] net: stmmac: deny tc-taprio changes to per-tc max SDU
Date:   Fri, 23 Sep 2022 19:33:02 +0300
Message-Id: <20220923163310.3192733-5-vladimir.oltean@nxp.com>
In-Reply-To: <20220923163310.3192733-1-vladimir.oltean@nxp.com>
References: <20220923163310.3192733-1-vladimir.oltean@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?zRbpt6asnOwz6iftdEW/NbAnX94ZwOb82y4lBGxCqUpXYX+QoAf6KFrnfTnV?=
 =?us-ascii?Q?Id8+O+UiSUvB1SdUBDDVr0EAf3MsqF00iZ1Cd5du9dWwFzkWdPHB94glaBnH?=
 =?us-ascii?Q?IjIyL4+KUBvDriaibRzxPHZGPKhzdrCRPaf1Njv024BvMLfJV3GYDaHIh/5w?=
 =?us-ascii?Q?XTwKQBjRAxXXWdi9msLSJN8ZAN489Js1yJxKaBkC0aP1jCW+YoQpykknf4Vf?=
 =?us-ascii?Q?lwtN30WgHkxLpqjjpdlSx2A95vfpXf4fi2AKKLwSyDE3s3OMN38ESIec9UAU?=
 =?us-ascii?Q?NZSKqOa6YGfmzx3VBlWeF15mWlg+vWZtKIx+F7YtoYu6muRVgu3+2UWj0pNF?=
 =?us-ascii?Q?/RvHeQdzK3RRjduAp9k41L+G2FmvuePp1shqqNzLS6h0SCeqXfiyzM4JHBH8?=
 =?us-ascii?Q?i3xSxvn7dh6l2oMQQnmo5nlMUJusfw0bE0H4uHWpZPYy5NLW/HRSKvinbyyS?=
 =?us-ascii?Q?0JQrfmLxE+BEhZ+YGUHRzL7fcv0C5245TyyrAFhWWoFiPxCI/lz0w0edm51+?=
 =?us-ascii?Q?dMHUBCmJCt0lZZN0bN64xDxh6bcrTTapelibAwNb9GKpaLujDUaHc4BGPII6?=
 =?us-ascii?Q?2aqRkJmn/Oh4NxnjMYbvon73Ygsq9tN4b5luve3PFIj8bKSRAYNSDa/g5q6t?=
 =?us-ascii?Q?KO5Fw3KeEDY7gI8SGvg68pUMjeVxBG2/OwNG+f+Z0mNNMOaVodYO4qitRvPI?=
 =?us-ascii?Q?SX8Nw3GKoIw0gasa64zwrkDPXNFJpnUqBJJuVqnfGdPgg5kWgY3VXzcd10Dn?=
 =?us-ascii?Q?LtnaZjRLst/d3e6grTliEFV+18upaqPB3/iZRdLUbwLbCpnhMjymrh6Qs8bz?=
 =?us-ascii?Q?TMYGs6ozfNWRCGudpzrDtY09B3ej+aaY4PCcKslEVwK+5rsVpt0NyFAWBbTw?=
 =?us-ascii?Q?mIR9sq6ithCdDKhQN0CRMROEKePQPPh8vvsPDYhtg2k3r9ys7ZffSL0nJu4y?=
 =?us-ascii?Q?duj3fcpXZXQ2SMeml0dRl9CdkBNyFcuRqKxtzZWYFqbx/zTAeFOGW9uBrcE5?=
 =?us-ascii?Q?uiu8EAWjMXJ2bLCU/Rx5mfkCmVgdkkDURqYsQyhDi+nDF7EeCEmLbQmX2SBR?=
 =?us-ascii?Q?TWEjmEBeo3C3kxDJtQAzT6J37rbgwU76vQd3ehCSRlEx35Hif3/OHSgBMpJV?=
 =?us-ascii?Q?2/uYJSYGG2RLDZ2n0kDrXTXa+NuDQzWg0Zgl8TMkiXLvC+kWJ49oM7C8Y6m3?=
 =?us-ascii?Q?TYbxmudR9X5nFapkfTWltFEAbIRb6xRHd7eQb+WzHAz02BS3ZXQ7LHkT8ArG?=
 =?us-ascii?Q?TEYpmBK/HHrkO9E6gwPBpNY9RFalY6eROKUyoY1RxTKlZ+EpO38fyvaKss1V?=
 =?us-ascii?Q?GpY3No9KnICkOLXLZ3WuKpKDXprobaq83nZ+st1CrlzZmP+vkLe5nfp6fizE?=
 =?us-ascii?Q?gEvCY1E8UROzmt/i16f0kD+2xqogDd/5sxD5vf9K1C7o5kKbZeJChDFwv1Xh?=
 =?us-ascii?Q?5kWoqL5iVTU5xaAemwyRskfNuWOK2W2Wlyf05IpZhW87YHwcmCXsH71aqY1V?=
 =?us-ascii?Q?Y4I7XpZSNc3bZVwU/IIo2yZk1LJtH5InXCFrS/tiRfMA7cYawcFOL+YXKaTI?=
 =?us-ascii?Q?0XnS6yl9m4oMYwF5c3bnat/pHtjc3Tu9DitE+ZAmwxJe4wc+W77W4NIAy9wn?=
 =?us-ascii?Q?wA=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 88c577e0-05de-4fbb-c24d-08da9d815ba6
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2022 16:33:34.2999
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 33HhG0Hzjn+zW5rCLG4BBTgRaMjeGh2aG24GA/uCITygPPOkpI9qEO8Z/gn+vVpcg3i8UktxRPirxmS7kALrVw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7023
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Since the driver does not act upon the max_sdu argument, deny any other
values except the default all-zeroes, which means that all traffic
classes should use the same MTU as the port itself.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
v1->v2: none

 drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c
index 773e415cc2de..8e9c7d54fb4c 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c
@@ -922,13 +922,17 @@ static int tc_setup_taprio(struct stmmac_priv *priv,
 	struct plat_stmmacenet_data *plat = priv->plat;
 	struct timespec64 time, current_time, qopt_time;
 	ktime_t current_time_ns;
+	int i, tc, ret = 0;
 	bool fpe = false;
-	int i, ret = 0;
 	u64 ctr;
 
 	if (!priv->dma_cap.estsel)
 		return -EOPNOTSUPP;
 
+	for (tc = 0; tc < TC_MAX_QUEUE; tc++)
+		if (qopt->max_sdu[tc])
+			return -EOPNOTSUPP;
+
 	switch (wid) {
 	case 0x1:
 		wid = 16;
-- 
2.34.1