Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     netdev@vger.kernel.org
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
        Rui Sousa <rui.sousa@nxp.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        UNGLinuxDriver@microchip.com,
        Horatiu Vultur <horatiu.vultur@microchip.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Michael Walle <michael@walle.cc>,
        Vinicius Costa Gomes <vinicius.gomes@intel.com>,
        Maxim Kochetkov <fido_max@inbox.ru>,
        Colin Foster <colin.foster@in-advantage.com>,
        Richie Pearn <richard.pearn@nxp.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Vladimir Oltean <olteanv@gmail.com>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        Tony Nguyen <anthony.l.nguyen@intel.com>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        Jamal Hadi Salim <jhs@mojatatu.com>,
        Cong Wang <xiyou.wangcong@gmail.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Gerhard Engleder <gerhard@engleder-embedded.com>,
        linux-kernel@vger.kernel.org
Subject: [PATCH v2 net-next 06/12] net: lan966x: deny tc-taprio changes to per-tc max SDU
Date:   Fri, 23 Sep 2022 19:33:04 +0300
Message-Id: <20220923163310.3192733-7-vladimir.oltean@nxp.com>
In-Reply-To: <20220923163310.3192733-1-vladimir.oltean@nxp.com>
References: <20220923163310.3192733-1-vladimir.oltean@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?v6HeFBEM2bwoSoj0j3Ljkyi83g1DTORueW4QSyE4LSxno7bCCFFapvAEXcUq?=
 =?us-ascii?Q?YdzWrJSRJ6lxTWLL46ONeuuC/3dZjLAzaS3UehWAJnqePDcpLY9ygwamPBBO?=
 =?us-ascii?Q?54HvcB3ospB0B8aUBD8fLbbl/tN0QSXnyjJI5gbUROKEC+Y7YxjJds5DNhay?=
 =?us-ascii?Q?7c0u3Z/E+AVQDEPAo0odwndWZP2Er5fpry4IYN1WgKUT+SMxo1BR0QGSnkh9?=
 =?us-ascii?Q?wNxaBQ3nPvapSF71VuunScauFd2JkQo+Dfh+j0laoTwlhNFUJZYXP+ejXSAv?=
 =?us-ascii?Q?L5lE+G5NtqqKklT931gM3ZJ/5UGDrRZpi2IR4hNauA99YaggsY/+dMUhx9/i?=
 =?us-ascii?Q?PrR8gnZgByCfzyhjpPQGeFR6TbbJ0p3Z//NTD8GIMnCLjOagqsdR4Zua4cKU?=
 =?us-ascii?Q?xMQMZhz/CuRnlR3CgGDpSCuIcOTTnnHQsQB6bpCRoucyYRK8Blcrec7Szrtt?=
 =?us-ascii?Q?kFYurpVWRzhlMNsZjFlGRc7sSPWXuptUtaTTlps4T484TkVDFD6uRf7CLlXt?=
 =?us-ascii?Q?BuvyZ+j/E+BLfr0QpI8UhMhi781DR2RAsPpyCEw+IpsmGiny61Q54eRklM5s?=
 =?us-ascii?Q?/4//k0PGX9Jr3adwmhbHIitclQe1KKfMdH9k1ajbMWK0S7PMka0idtQ50YIv?=
 =?us-ascii?Q?QzEwpPMj9nG0r1Zi7jxPTmDrYnQskwITvu4TuKUM4H4aLKP3IXPzbRSKBxBO?=
 =?us-ascii?Q?oZ3iIU8Z8MbyxKdfzZW5g8c4G6ltIKhKTNdTiKL6sU2/Ud2JwlNbHK2gYrsL?=
 =?us-ascii?Q?Js3JV4LIKrV3qnbLC7zKPRgYKqtdfBPrHawVWQH0L+6o1C5lpK6HXvWsC5ut?=
 =?us-ascii?Q?wrPdnax/CH0BzikAEwP4wlMuVAuzHBo9dsNoAFbMLNjQVU5xHl5ubAGQ7xq6?=
 =?us-ascii?Q?PnGJfIERO0mZrsqeeNFrFuZ2YROthYHDIi7V8gZ0L9t/I9PFpoQ1CYUH1pQd?=
 =?us-ascii?Q?0yv/b5/1RHblMz3fXPDJRR6ECRftli3u8iauJAjysQLgjZFq1sASjRyGcIUH?=
 =?us-ascii?Q?yT0iNPFp/j+4hfXo+VTziD1R6cs9H4XMMrPJFjrsithypdHdwk1n5ZGXiCFB?=
 =?us-ascii?Q?QlzK9xUyTY0VHiNL14X9YdVjMn6BP9HiPA/876hSvLePARYXAax4Tt0hwRIO?=
 =?us-ascii?Q?1vS2c4HK8QZYKsWCIOsMFUI95Baie4kVHgCNAwnlYlKhxDYk9ZRsC0rj3XUB?=
 =?us-ascii?Q?7byWMseSLKlkLTXbQ1ishmxprUxhhVy3ecbw/i9xF0+JdUuvsepYunlMJjTr?=
 =?us-ascii?Q?fSEDaJQ77ZO7NjSbHoZT63UCQkYANwD15sLRVtgnbdKIMA7nzn5+yxtCMwM5?=
 =?us-ascii?Q?F7h/CcPcZRabqX6LYv+dLgKq17Qw051w2MzzAbqr6/jW6wLWWkh3Ho4ijC9/?=
 =?us-ascii?Q?fVXgA9UBtKTOBEYL3gXzuqmTfHcOf9/zzFqE2mEKvAq9Jxbjaf88SxO8+6lN?=
 =?us-ascii?Q?7nlz4TK49Olui2ZCgc6dH10nSVHrQw2bxtYoP92Mu1JEKg/lqnwSWTBpK9PC?=
 =?us-ascii?Q?UGuG/hpvW5SGWWvsAbW3/WWbMPwCe2Y9N47A+POm5CH7KR9zmRgpU0curYAn?=
 =?us-ascii?Q?eJXKikXrmseFryz5W6z4+yBTAah1ApIHkqVoxMrH3cSqM28oiXoy3gwp05FI?=
 =?us-ascii?Q?tw=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f3543c90-68b6-4cd0-7816-08da9d815ef7
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2022 16:33:39.7683
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Jsp/t3xVyzCCvC/HuDWMQcy1d/FLZSiIJ2ztq5n1tX3iBqI1uOeIZZnHBmqsWfWbDR14ijz/TdMtn0XV3ksIfA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7023
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Since the driver does not act upon the max_sdu argument, deny any other
values except the default all-zeroes, which means that all traffic
classes should use the same MTU as the port itself.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
v1->v2: patch is new

 drivers/net/ethernet/microchip/lan966x/lan966x_taprio.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/net/ethernet/microchip/lan966x/lan966x_taprio.c b/drivers/net/ethernet/microchip/lan966x/lan966x_taprio.c
index 3f5b212066c5..96367819ff96 100644
--- a/drivers/net/ethernet/microchip/lan966x/lan966x_taprio.c
+++ b/drivers/net/ethernet/microchip/lan966x/lan966x_taprio.c
@@ -219,8 +219,16 @@ static int lan966x_taprio_find_list(struct lan966x_port *port,
 static int lan966x_taprio_check(struct tc_taprio_qopt_offload *qopt)
 {
 	u64 total_time = 0;
+	int tc;
 	u32 i;
 
+	/* Offloading queueMaxSDU is not supported at the moment,
+	 * only accept the default port MTU
+	 */
+	for (tc = 0; tc < 8; tc++)
+		if (qopt->max_sdu[tc])
+			return -EOPNOTSUPP;
+
 	/* This is not supported by th HW */
 	if (qopt->cycle_time_extension)
 		return -EOPNOTSUPP;
-- 
2.34.1