Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     netdev@vger.kernel.org
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
        Rui Sousa <rui.sousa@nxp.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        UNGLinuxDriver@microchip.com,
        Horatiu Vultur <horatiu.vultur@microchip.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Michael Walle <michael@walle.cc>,
        Vinicius Costa Gomes <vinicius.gomes@intel.com>,
        Maxim Kochetkov <fido_max@inbox.ru>,
        Colin Foster <colin.foster@in-advantage.com>,
        Richie Pearn <richard.pearn@nxp.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Vladimir Oltean <olteanv@gmail.com>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        Tony Nguyen <anthony.l.nguyen@intel.com>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        Jamal Hadi Salim <jhs@mojatatu.com>,
        Cong Wang <xiyou.wangcong@gmail.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Gerhard Engleder <gerhard@engleder-embedded.com>,
        linux-kernel@vger.kernel.org
Subject: [PATCH v2 net-next 07/12] net: dsa: sja1105: deny tc-taprio changes to per-tc max SDU
Date:   Fri, 23 Sep 2022 19:33:05 +0300
Message-Id: <20220923163310.3192733-8-vladimir.oltean@nxp.com>
In-Reply-To: <20220923163310.3192733-1-vladimir.oltean@nxp.com>
References: <20220923163310.3192733-1-vladimir.oltean@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?mdp9B6vuBHFVWyiMT+o98J5D/ZjyuyOC+rml8g9x/0kV39MQJQip8o4J16xX?=
 =?us-ascii?Q?7ZkQWlMNhvk3ynzZRR9d+8rA2v5Ca5jiY5285LfRFFBuH0FNADeLThIlVR9g?=
 =?us-ascii?Q?jnRPo3FMiF6ym1L5UCSvlk8nRa7pRusFSbS0TWlii1mb0frE6LVUjpyrRbP+?=
 =?us-ascii?Q?tMj+sGOwE6iFcBfsyPjrPobAV+DGzFKcQSkB7k3I4qjXkQmiy/qCQQHHL1RS?=
 =?us-ascii?Q?Tl1DoaubAcA5oYi+u5IYE9pcEcuVBPBNKBW+B7TbbVifIV8buGRO1q+uUqr4?=
 =?us-ascii?Q?R6SweDMpLxZs2fcALhw2sqKlk/4pT+RZOJuMnDK0zhb/SIrN32VhtSMtYP6I?=
 =?us-ascii?Q?6h8GwMtLJWyZBNqlPkf3GP9n/CChSfOjgiMHeXfTeKXWFDAj/B+Kw+RInaig?=
 =?us-ascii?Q?ma2UFArNqbzv/dAIN5Qc7oyY8Vhxu8B0t1sV8DpTUlhBbBgVCG3F5oVZhBeh?=
 =?us-ascii?Q?YUpGEnaK12BoqqCT3hDyWQtA78Tti5VYrz3StkoR/glrNVt6xYnaVVVmhptQ?=
 =?us-ascii?Q?pfkRHpAYajY5QjQp9XifNMGKtlR2zHAXeoQ/HxD9kfnipKTqXWdurcq2nBDz?=
 =?us-ascii?Q?Pk2t/ZIsSVFUeflqgduWQ1Yn5CZkRCEHW22dq4RqDLK9s/qkzqyaTI4QTaiq?=
 =?us-ascii?Q?m8rOz2vMz2FYYLfC2sFlInI/B8FhlF4bP6OXzZp0tqe/yQHzuJxS6dBJ5E/R?=
 =?us-ascii?Q?hhWz956CySAseuN07FpKbTRUkJER5g7r0P28y9pkyTG56KuPYDYuIMlhkjZa?=
 =?us-ascii?Q?/PDtRH53OkkELPIr4r0Ryzy99ltir2e+i4pwJlnp9dCfBzLUqKzZpiDZFXJE?=
 =?us-ascii?Q?CFAepXL3xAdb8Hqj3CK5Rg022RQ826jjnfFkd34vvRSknBrfhUfMPQGVPKjZ?=
 =?us-ascii?Q?i+DwoHgk6YjHRfRVo95J6OIbkIjzNo87d4TLnB+jC7uW2ixCxi9ZfG9OqqfP?=
 =?us-ascii?Q?aax6xrRm9CtPgNRA3OCSACaM5dAyqCBxXXawFpQhEcWuuO7YgKK/LoD+nyox?=
 =?us-ascii?Q?Kb+D14UTKzRyuXbDMJ66RvOBIUHysGn4qXluXdcVv3YzpQ/AfE3T8jhssKsA?=
 =?us-ascii?Q?0X+lRs3CHg87iJzZuRZyYlxsIF4xaKmDIJhcqxrqPDYqTKxMIefIOdOxM4gW?=
 =?us-ascii?Q?hIyOj0mglc4s6M0m6mpBAC2mdPrFKwmc76IJjBlynkSDJJiTEeZSQqj6RUlx?=
 =?us-ascii?Q?rD/37U2Z7Yt3bD2tNyS9QTNvSOR+g7oqS6Ciqne7mtszfDZIZc1O/rcqoJkg?=
 =?us-ascii?Q?zxvyVDMYbWqaW1A9pw6bIEUTRMPdR63DJDa6O1Q2nIlNPISl31UFzOEQ7X/g?=
 =?us-ascii?Q?WGhL3DoViveRm/ZVV5D87SfsPb0K/ZWiXKN/bjDJ/YPnxgWp1r+OPxqbYJvM?=
 =?us-ascii?Q?tZM2LQYo64NexH/JzIj/kjy/ocm7wu9CdKGWQze8c5jx7Lytcu9wFOgC+Cb5?=
 =?us-ascii?Q?7Pf0IPlAoF5FHr0DM1zqVgV9V5qc3/5YqaJ0SwEgGSiHJ87NhfWzWxyPwM1H?=
 =?us-ascii?Q?lrsvOuFu/KreDxRILjv49tzLTctJlnXRKPf9S00B3rS3nIpKgLPmWJrlzMP7?=
 =?us-ascii?Q?JGLDTEXYmBEPCmGeZ+Htg/pa1p6rapoC/zTBFLPW/kJonvzN4tQpMUiFHQZq?=
 =?us-ascii?Q?rg=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d442722d-9d1a-4b5c-e78d-08da9d816093
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2022 16:33:42.4869
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nWE7ybO5DnvfsyCjZtY/ZvAyFXy0VzjuhfzGfRd0GcCi7iNY5eFrwaVjwyoHl7nXxjsGxJuI/bqgvxAZWyKCBQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7023
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Since the driver does not act upon the max_sdu argument (which it
should, in full offload mode), deny any other values except the default
all-zeroes, which means that all traffic classes should use the same MTU
as the port itself.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
v1->v2: none

 drivers/net/dsa/sja1105/sja1105_tas.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/net/dsa/sja1105/sja1105_tas.c b/drivers/net/dsa/sja1105/sja1105_tas.c
index e6153848a950..607f4714fb01 100644
--- a/drivers/net/dsa/sja1105/sja1105_tas.c
+++ b/drivers/net/dsa/sja1105/sja1105_tas.c
@@ -511,7 +511,7 @@ int sja1105_setup_tc_taprio(struct dsa_switch *ds, int port,
 {
 	struct sja1105_private *priv = ds->priv;
 	struct sja1105_tas_data *tas_data = &priv->tas_data;
-	int other_port, rc, i;
+	int other_port, rc, i, tc;
 
 	/* Can't change an already configured port (must delete qdisc first).
 	 * Can't delete the qdisc from an unconfigured port.
@@ -519,6 +519,10 @@ int sja1105_setup_tc_taprio(struct dsa_switch *ds, int port,
 	if (!!tas_data->offload[port] == admin->enable)
 		return -EINVAL;
 
+	for (tc = 0; tc < TC_MAX_QUEUE; tc++)
+		if (admin->max_sdu[tc])
+			return -EOPNOTSUPP;
+
 	if (!admin->enable) {
 		taprio_offload_free(tas_data->offload[port]);
 		tas_data->offload[port] = NULL;
-- 
2.34.1