Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     netdev@vger.kernel.org
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
        Rui Sousa <rui.sousa@nxp.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        UNGLinuxDriver@microchip.com,
        Horatiu Vultur <horatiu.vultur@microchip.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Michael Walle <michael@walle.cc>,
        Vinicius Costa Gomes <vinicius.gomes@intel.com>,
        Maxim Kochetkov <fido_max@inbox.ru>,
        Colin Foster <colin.foster@in-advantage.com>,
        Richie Pearn <richard.pearn@nxp.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Vladimir Oltean <olteanv@gmail.com>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        Tony Nguyen <anthony.l.nguyen@intel.com>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        Jamal Hadi Salim <jhs@mojatatu.com>,
        Cong Wang <xiyou.wangcong@gmail.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Gerhard Engleder <gerhard@engleder-embedded.com>,
        linux-kernel@vger.kernel.org
Subject: [PATCH v2 net-next 03/12] igc: deny tc-taprio changes to per-tc max SDU
Date:   Fri, 23 Sep 2022 19:33:01 +0300
Message-Id: <20220923163310.3192733-4-vladimir.oltean@nxp.com>
In-Reply-To: <20220923163310.3192733-1-vladimir.oltean@nxp.com>
References: <20220923163310.3192733-1-vladimir.oltean@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?a7kLhEP8n4ApgQnUTUCkoRSUsma9liiE2JJ959kD6rvekXI31V+v905QpcaZ?=
 =?us-ascii?Q?9xS0Qy+PT4X/wNxuDcpGN7Nq0CxLw3eDDKMaKZwO3nLlh3vtlGdtjCXAt/qH?=
 =?us-ascii?Q?gJMi+/S5Xh/vCgLAct/wz6zKFpWYDpHifjOe8BSXg8XCYuZbWwAteEGcCJ+m?=
 =?us-ascii?Q?QRWkW0SnhmVYz1amXg2tFZRj44g6uBn1tfr6Q2orjoQMkx4klGT8wH177Aad?=
 =?us-ascii?Q?5UTkDXR33xHj28af4E2X3rLvFER9zCwTQTEC122XR9+w9sOvn7aQ/m7c7LRN?=
 =?us-ascii?Q?qotMko7MlWj+I5Wx2YpyiS6bMoOQ9sRzMcY2FfRMfwVnKaGwnziHIH+Mkbfq?=
 =?us-ascii?Q?xO5H8onht/BKCx+gEqICfOSmyps0cMYWPlYMUdMjeqp+aUUZtTMHvwGcTuJj?=
 =?us-ascii?Q?7T+8+YvsJSy4xG/ad3hKhUO1hEC/c5tmrUApBnNh1Y+YZyTZ3OTTmSV5E2Br?=
 =?us-ascii?Q?lOLRjInB2ypL0/e2JAMnEGkr51PpAFHN6CgTeVIUBwl/U1fB0JE4NeWpT7zV?=
 =?us-ascii?Q?xr19iFY3A8tL5RLBHLUGsxyfvSTW25CoeeTT79rGTtAC/W39gHhfix1GL4p6?=
 =?us-ascii?Q?V/gRRhDdfkx3u4uzgzSOGg5L3tRJEisUB8ymiOPWfqcHF+io9XC5MwNOtxSx?=
 =?us-ascii?Q?X7j2ehfr/dsHX5uU8S5MUScGAN61J1DhXo+F/RSlYVE1+NDFLSTFI4G2+yAH?=
 =?us-ascii?Q?jA/mwK0ZtXavwNMbrmoQsRMptX30eQBBvv3+2Zu4/Ie0BjlMBnxpavR+Qk3c?=
 =?us-ascii?Q?5HlogcndUEm0kmRGm7SaKv4kpjFr1vTJ9QO32eSMFbpsSoHd4TWB8wIVe7Lw?=
 =?us-ascii?Q?+7sTeML+o80KD175uEYYs/+5dCg8geUkYL6MEJGXaBvtW6+nHOtVObnYyw8a?=
 =?us-ascii?Q?46ElHdeVfinYSCdbzHKDEYvFggha0+tiKGyH3NEd5o+UEgENpxJp03opMAyb?=
 =?us-ascii?Q?FNWVKupT3Fex0KiOQ1Dlg0DU9JOEigAkZNtwdEt0wOoyJ6Tsqj+TzT4R6QqS?=
 =?us-ascii?Q?WX53CzyKL8mpUskN2hVeQt5qJBT/G7QakcWLz9BJxNA6MWlAco9T0NDn6T+1?=
 =?us-ascii?Q?lMG+8i+vrSmhH8k+G4EYLwIx1nyofpK0l93BONvDfzcfx+628XIzIExvo4zP?=
 =?us-ascii?Q?x8m3c189qDB4Bj4MeB9D+hHBpdYrvYAuRCKn43W8XuW6P9q0oviPsKAOPITA?=
 =?us-ascii?Q?c01Z4ZE9Ucu2NFDxturERB6JEarb/tVYhZfbqjyOd61IYpaeDSZKo8fGVMA0?=
 =?us-ascii?Q?IlYdO22ozGDhskjtVq14tgTLIveWutOOBcSjs3YS3LbthzwIuSK1NEwe9PR9?=
 =?us-ascii?Q?vIzXX2aSby3kxUq8qdobNs76AkJXdQHsTHbKprw1tm6WxHRfhDhQqsgB+253?=
 =?us-ascii?Q?hxGY2kNEYfuzlm9JrACo+BdrW+Z5NZ98hM/CVfFArQfz+dp+cA4V3f1K0Gr6?=
 =?us-ascii?Q?kU0R662O63L5CyU4f4MCcV9GN/spPTsbk3zHObCpUq+p8ksKMmaLsCO+eSf+?=
 =?us-ascii?Q?BFJ91uU1hA+H36mjAmMJjvEqCmytjIw2Tx5yw5F2RfgRNPlL3OED/hcAgSTN?=
 =?us-ascii?Q?6FE/qv/FqznK3J8B4t2Lp6mmqMQghvHsxNA1Z9QiWQu4QfiGVr33HJxAIk0/?=
 =?us-ascii?Q?Ug=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c7e6b287-e209-4f5a-f0ab-08da9d815a07
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2022 16:33:31.5189
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0Z2jsUWFg4ulAByrPRNd0zYBHiCISEoxwLUkVQZEzoZBI3WbovDmkXN/8uzkcPLIvaWD4z3uD3UIPmktz43Mcw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7023
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Since the driver does not act upon the max_sdu argument, deny any other
values except the default all-zeroes, which means that all traffic
classes should use the same MTU as the port itself.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
v1->v2: none

 drivers/net/ethernet/intel/igc/igc_main.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c
index bf6c461e1a2a..47fae443066c 100644
--- a/drivers/net/ethernet/intel/igc/igc_main.c
+++ b/drivers/net/ethernet/intel/igc/igc_main.c
@@ -5965,11 +5965,15 @@ static int igc_tsn_enable_qbv_scheduling(struct igc_adapter *adapter,
 					 struct tc_taprio_qopt_offload *qopt)
 {
 	struct igc_hw *hw = &adapter->hw;
-	int err;
+	int tc, err;
 
 	if (hw->mac.type != igc_i225)
 		return -EOPNOTSUPP;
 
+	for (tc = 0; tc < TC_MAX_QUEUE; tc++)
+		if (qopt->max_sdu[tc])
+			return -EOPNOTSUPP;
+
 	err = igc_save_qbv_schedule(adapter, qopt);
 	if (err)
 		return err;
-- 
2.34.1