Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp1301960rwb; Fri, 23 Sep 2022 10:37:45 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7Ls+OUNXGMbjcTljeDbszRSIRxpia0bMdow8F6Pmv0SHCmBFxDWthyKlv3YMmZT907Ibaw X-Received: by 2002:a05:6a00:230f:b0:53e:2c2c:5c03 with SMTP id h15-20020a056a00230f00b0053e2c2c5c03mr10307557pfh.11.1663954665077; Fri, 23 Sep 2022 10:37:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663954665; cv=none; d=google.com; s=arc-20160816; b=00d2I31AftStWqht7jmf2Zbn+oGKK9Up5cdxanrYei1gq49dBWqSfvZxxcaA0ErH+6 od5HhrMGHt3JDQjVpBznRkolSdlqZvLJHCpHvLdZ4Vm3fTlGiTY5MrmtEFVSYp5DJ8/6 7r+zXR3MsklYT2xuc1i3pKdA0rTur/lJRqXh348nL8IJOhQI+bmv5+YY73SPe11lkA6k SsQ3OmOSro0LNryHZEsUuwzx680JJol3mLr9zoC/NNhC4cHGZ0BcyzVzJOlQgKNsDtuI srp7Ad/xMX0TandYUdXuXzoEshqjrVgMA3NbpS5xF0g1GU0a898GiPU+3BhIZvaL/CU/ 9nTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=s7i5uSFILjXZ8SHIdzqLcqBhK3PdtjsmFKfe/MwhZqs=; b=rS5UhfMn6Z0qgrW+a/uZwmn93k7uvr3WYRNGf0bAqy4JH5rXT35h50em8UTwWfB+PN klYLOxrkxAjl77nFxRqbbjqGSHpKHULK4+qe3z5OkXVJk/xjyX0Pl+I9JNrdPXlSg7rF 2IYiF1kl5zaqJnwIJuudXNG0/kvNAS+bntvfgFBg7G2KCTHW5zOBgqegDy/yfilZXEtu xGfgUx2oySpcBORGwX7Q5KyohIM9R2K+AtT3nC/rqFd6w53IFkt4YdlHlS+jcxfKI3tF CzFJ9trWXMvWO/AzJ3noITlvtjuImOpr8EZYCMhzGlXf7fYaa13FinpxLlUZeq/tSjNR g8Cw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sPYgRfnH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n29-20020a63591d000000b004360383b3a7si9784894pgb.185.2022.09.23.10.37.31; Fri, 23 Sep 2022 10:37:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sPYgRfnH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232234AbiIWRHO (ORCPT + 99 others); Fri, 23 Sep 2022 13:07:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232213AbiIWRHL (ORCPT ); Fri, 23 Sep 2022 13:07:11 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04E9514B865; Fri, 23 Sep 2022 10:07:10 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B62F4B8331C; Fri, 23 Sep 2022 17:07:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5AF0DC4314B; Fri, 23 Sep 2022 17:07:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663952827; bh=OHPc09XdtkB69hHy9A41/zPZ29zpuKb1HP+2+9skeBA=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=sPYgRfnHuP+icV2S/4rnjYWWFaj8e6xIPXcYr3UlywAG6ubQqFuZ4kEsz5L6sWeFT cLcHRONKOEfSqNv+DSKMzrb7ORks/ew5Q8Cl645OdytW8p/oFiFeqF0SOrW/DEF+h9 qpWNmSG28hJJ7IbXp5KYjVZngeXfWYFhBHZ5oA4hYallbJRkFck4oY0McTfYnRnzDZ GGn0rjC9ZVSjPw9cqucDA0ynJ/zJdsqCQxR4+3vbEkkBEyb78mKQtbslRNp0/h8wcy BMudEc9Jt4SOJiPXHxky4bPdkDrNzyC95CB3Jdn9YDyD2G0RE3SmtewOI94F+yq/Mn TVhI4rx9Mcdtg== From: Mark Brown To: Srinivas Kandagatla , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Banajit Goswami , Vinod Koul , Krzysztof Kozlowski , Pierre-Louis Bossart , Takashi Iwai , Jaroslav Kysela , Liam Girdwood Cc: stable@vger.kernel.org In-Reply-To: <20220921145354.1683791-1-krzysztof.kozlowski@linaro.org> References: <20220921145354.1683791-1-krzysztof.kozlowski@linaro.org> Subject: Re: [PATCH 1/2] ASoC: wcd9335: fix order of Slimbus unprepare/disable Message-Id: <166395282508.610218.13514868920079222413.b4-ty@kernel.org> Date: Fri, 23 Sep 2022 18:07:05 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Mailer: b4 0.10.0-dev-fc921 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 21 Sep 2022 16:53:53 +0200, Krzysztof Kozlowski wrote: > Slimbus streams are first prepared and then enabled, so the cleanup path > should reverse it. The unprepare sets stream->num_ports to 0 and frees > the stream->ports. Calling disable after unprepare was not really > effective (channels was not deactivated) and could lead to further > issues due to making transfers on unprepared stream. > > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/2] ASoC: wcd9335: fix order of Slimbus unprepare/disable commit: ea8ef003aa53ad23e7705c5cab1c4e664faa6c79 [2/2] ASoC: wcd934x: fix order of Slimbus unprepare/disable commit: e96bca7eaa5747633ec638b065630ff83728982a All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark