Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 23 Sep 2022 11:18:33 -0700
From:   Colin Foster <colin.foster@in-advantage.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, netdev@vger.kernel.org,
        Russell King <linux@armlinux.org.uk>,
        Linus Walleij <linus.walleij@linaro.org>,
        UNGLinuxDriver@microchip.com,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Lee Jones <lee@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Vladimir Oltean <olteanv@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH v2 net-next 12/14] dt-bindings: net: dsa: ocelot: add
 ocelot-ext documentation
Message-ID: <Yy34edNkKopsETcg@colin-ia-desktop>
References: <20220922040102.1554459-1-colin.foster@in-advantage.com>
 <20220922040102.1554459-13-colin.foster@in-advantage.com>
 <35ba126d-be10-2566-63df-3c474cdc8887@linaro.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <35ba126d-be10-2566-63df-3c474cdc8887@linaro.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xBI52VHh+IJl/WWv0F9wPYv1sLzdiQTJu4Bumi/k7+V/IyhpGRQpIheuxCjM?=
 =?us-ascii?Q?SSneObwamtyDkdBNiergKTMMpmOUc1YMQ/gwE9hf/wi51QCECOCoto5QIMma?=
 =?us-ascii?Q?5sHnoZiiv2/0ljDWCXqtN77QRk2R1jA+dzdNhCoYS2M7R3BPMSdQoIGd/Pjr?=
 =?us-ascii?Q?j623a+OpshA14JD8/65z+GEcLWlMhXmzBFJpC+boeNH8e9LDwkKeO6zZexwv?=
 =?us-ascii?Q?+rEd2RH0zvACUiJagO5j7XqYff5lJybnnRQiVH20D8FahysHwBxXqlDlM47k?=
 =?us-ascii?Q?bWDZJFKyTm5vfQZN5AVSTjdX4Igb6Gn/3Z6O2vlxcZdtNkVuMu2X1ZRypseF?=
 =?us-ascii?Q?lrDN1VGqtoQrLLFatjdpX/Zd2rVFaI4cME3X9UU0t9QDl0E7XfnHUZydTxqH?=
 =?us-ascii?Q?SOZHLsiIvJulsIRqYWcjc5LGj2z660AoRkEJRakdTgh74Hqk0Tq3fPMcMyBn?=
 =?us-ascii?Q?z0PwSI4HyX/Ua2DO77D5T8H+R1GKF93llt+lHPX+dtdBDUOqtMBY8gQp5WXg?=
 =?us-ascii?Q?/mWGaChHXQ6tttuXeWIy7R2slbR55LATYCt0ryQr8V8ttNLpTU/+BJDFrIDb?=
 =?us-ascii?Q?hN6XRKFFfYfodwtwvfp2z4cQCmWSIs4FHLCoJygaJs+LzTitOddL/N5AdkWH?=
 =?us-ascii?Q?IthkKdjnDMOWilEaiEVjB64tGmJy4MpB5weIO8oKDbxrS+NZq9GYBMcfW9YE?=
 =?us-ascii?Q?XcYXx1bHmqu5u/XLU+Gss+/MpWZobqx/1VDddlPpnuihfN02TSvrqdNac+Qm?=
 =?us-ascii?Q?kXt18lcHuqLu25PZfEa1u9ltXs/KPET7yBeYtT0sjIKbLyV3Ow+9dequXPIp?=
 =?us-ascii?Q?CFkX/jviQyn092x4/aFud21SI4mAJw8DsT1/FKiJleq7rIPPDAp7H+u3Izuf?=
 =?us-ascii?Q?x3Mayi0FOhci4TSr4L/1EHVhsAZlwA38D+W+bm9rHZVOtnj+QV013VbAmTM2?=
 =?us-ascii?Q?kwKuqmaoMXEOicxNH4hKQ8lDLj1eIVE3JmXd7BGeE2VgLsPHS/2rwsG/XQ4B?=
 =?us-ascii?Q?izB6EBj0E3ANiJx1uPxuNb8qDugjDOPfUCM7D7J7VR3tAW87fsKbX9c6PTnz?=
 =?us-ascii?Q?eVBy+vlDba+8n1Xu2XBF0aSLnexFYGzIYNcnhq7ONOSC/d5UzSbjwIJEdpOj?=
 =?us-ascii?Q?UBN3fvHJsrJl4kfG6GEDrJJKlX8tYvqR7Op6j8dVNd91y+yT1e6PKqsiatrS?=
 =?us-ascii?Q?o08onrv5VculBhufOT6/VpM4CPeQyKGmuxe8dpbnepLXpe21igylVlTR8Whm?=
 =?us-ascii?Q?5afPEfsJ7U2TPldNNJfHyrPjsFCDwpLd4zn8oRVnHs8jlnx1fj6YghU2BpI2?=
 =?us-ascii?Q?8pSWWU/voQqSJsRSNBMkJJX6elyGebipEkIYTxGV2izrEd5ET7wWJch3j7Gb?=
 =?us-ascii?Q?kavxqp3f7kDOpa1tzama4jcoGkJcYiNUFyHz6Lzz1ON5GCz3kET30skjT4Nz?=
 =?us-ascii?Q?Agjalv0gQyg/ZQ5aUYNLMHidgBbUFhuC0UUVsPw/bdhy3Td1TJpyI6KBGN5F?=
 =?us-ascii?Q?5IeIm7lra+S96iZnPkUkVccJU53SD0yzK/+cwAPAK3PcDOzXJyKGLJHFJhs0?=
 =?us-ascii?Q?2begwjkBm1tjipEztphp4es9yrJZwjg2loP7O1hexCF4dLxLX2glF1qde6h3?=
 =?us-ascii?Q?jQ=3D=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7b4d2c16-e188-4d2c-3980-08da9d900915
X-MS-Exchange-CrossTenant-AuthSource: DM5PR1001MB2345.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2022 18:18:38.1771
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: izLtiWuiDf8xuaw4C4bpTMM4Zwao1JjvgyEA9GvjNCEI+32fEY5KVxmj6DlpsGIMLZsmnlv5xMje6zJMwirudNDieQ5y98dBUuwDZcQzSBs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB5947
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Sep 23, 2022 at 08:08:53PM +0200, Krzysztof Kozlowski wrote:
> On 22/09/2022 06:01, Colin Foster wrote:
> > diff --git a/Documentation/devicetree/bindings/net/dsa/mscc,ocelot.yaml b/Documentation/devicetree/bindings/net/dsa/mscc,ocelot.yaml
> > index 8d93ed9c172c..bed575236261 100644
> > --- a/Documentation/devicetree/bindings/net/dsa/mscc,ocelot.yaml
> > +++ b/Documentation/devicetree/bindings/net/dsa/mscc,ocelot.yaml
> > @@ -54,9 +54,21 @@ description: |
> >        - phy-mode = "1000base-x": on ports 0, 1, 2, 3
> >        - phy-mode = "2500base-x": on ports 0, 1, 2, 3
> >  
> > +  VSC7412 (Ocelot-Ext):
> > +
> > +    The Ocelot family consists of four devices, the VSC7511, VSC7512, VSC7513,
> > +    and the VSC7514. The VSC7513 and VSC7514 both have an internal MIPS
> > +    processor that natively support Linux. Additionally, all four devices
> > +    support control over external interfaces, SPI and PCIe. The Ocelot-Ext
> > +    driver is for the external control portion.
> > +
> > +    The following PHY interface type are currently supported:
> > +      - phy-mode = "internal": on ports 0, 1, 2, 3
> 
> "Currently supported" by hardware or by some specific, chosen
> implementation? If the latter, drop it. If the former, maybe this should
> be constrained in allOf:if:then.

Hi Krzysztof,

Currently supported by the software. This patch set explicitly adds
support for the four internal ports. There'll be another patch set right
around the corner that'll add QSGMII to ports 4-7.

I see your point though. I'll drop "currently" and have it match the
wording of the other drivers.