Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fa9201a4-13ec-714d-9b7f-7498a4c6c86b@linaro.org>
Date:   Fri, 23 Sep 2022 20:02:57 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH v3 0/2] pinctrl: nuvoton: add pinmux and GPIO driver for
 NPCM8XX
Content-Language: en-US
To:     Tomer Maimon <tmaimon77@gmail.com>, avifishman70@gmail.com,
        tali.perry1@gmail.com, joel@jms.id.au, venture@google.com,
        yuenn@google.com, benjaminfair@google.com,
        linus.walleij@linaro.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, j.neuschaefer@gmx.net,
        zhengbin13@huawei.com
Cc:     openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
References: <20220921095053.88658-1-tmaimon77@gmail.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20220921095053.88658-1-tmaimon77@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 21/09/2022 11:50, Tomer Maimon wrote:
> This patch set adds pinmux and GPIO controller for the Arbel NPCM8XX 
> Baseboard Management Controller (BMC).
> 
> Arbel BMC NPCM8XX pinctrl driver based on Poleg NPCM7XX, except the
> pin mux mapping difference the NPCM8XX GPIO supports adjust debounce
> period time.
> 
> Arbel BMC NPCM8XX Pinmux functions accessible only for pin groups 
> and pin configuration parameters available only for individual pins.
> 
> Arbel BMC NPCM8XX has eight identical GPIO modules,
> each module has 32 GPIO ports.
> 
> Most of the GPIO ports are multiplexed with other system functions.
> 
> The NPCM8XX pinctrl and GPIO driver were tested on NPCM845 evaluation board.
> 
> Addressed comments from:
>  - Andy Shevchenko: https://lkml.org/lkml/2022/7/14/1218
>  - Rob Herring: https://lkml.org/lkml/2022/7/18/1165
>  - Krzysztof Kozlowski: https://lkml.org/lkml/2022/9/19/68

How did you address this comment?

> 

Best regards,
Krzysztof