Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a1e98754-114e-b401-e927-5f2b71c3c641@oracle.com>
Date:   Fri, 23 Sep 2022 13:01:32 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH V2 2/3] vdpa_sim_net: support feature provisioning
Content-Language: en-US
To:     Jason Wang <jasowang@redhat.com>, mst@redhat.com
Cc:     elic@nvidia.com, parav@nvidia.com, wuzongyong@linux.alibaba.com,
        virtualization@lists.linux-foundation.org,
        linux-kernel@vger.kernel.org, eperezma@redhat.com,
        lingshan.zhu@intel.com, gdawar@xilinx.com, lulu@redhat.com,
        xieyongji@bytedance.com
References: <20220922024305.1718-1-jasowang@redhat.com>
 <20220922024305.1718-3-jasowang@redhat.com>
From:   Si-Wei Liu <si-wei.liu@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <20220922024305.1718-3-jasowang@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RFhKWGxNdkc1MDRNT2s0TFJIT285VDlsUUtsVXNyRmxYaGpTWnF6SmdXWGdk?=
 =?utf-8?B?TnZFUzlxTTVRUC92TEZjcGZUWS9oamw4UUorRjRYSitkWU8wSXhRN3c3VllX?=
 =?utf-8?B?L3lrWllXemU0MkNsb2ZkWkNaRzgzUzNkcHhkWlNFYmJZdFhWbmUxU2VFUGdW?=
 =?utf-8?B?V0V1QWc0RXpMMnp3cVpLci9jYWdZT2svNVdYUlMyTDUxcWRWWDJoOWd0UDNI?=
 =?utf-8?B?ODJSU0RzQnZFLzdEeVkyTkc0QnZSTndxM2NWRHVpVFh2VU1BYVNrS3hDRHE4?=
 =?utf-8?B?QlhuZEVUWlFDNmZLOWVDZ3V1K0NNUGIwU0EzZS9ZOWRhSGI0dCtmMFFzNlBV?=
 =?utf-8?B?RzFENWhWSVQ5WlRwVVdMTkQvNG5FcmpTdHpjODNsWWRzYmY4UTBRcVEveGRm?=
 =?utf-8?B?c1lUUDd6blRvUFhLNlhEYVFIcVJlTEhrWXhpcHBZQVFDRlQrcUU2OU50eWxo?=
 =?utf-8?B?N2x1MDRIVmFmek9OaVRPRlo1aldSek9wbDVnQUlUZEhhamJ4dWU1NGE0aGtV?=
 =?utf-8?B?MUZMU2QvQWNkeVBPa1lWSlh1WVlWVHVyaE1SSEJTTW54L1hGZEVIRUNON2lF?=
 =?utf-8?B?bVVBSnRlSFZvekV6aHFyRVNUWG5LbmVmWjdiazdmN2loN3RJZ1JHMnFKS3Ir?=
 =?utf-8?B?dks1cWV2UlEvQmRIQkpZeTk2cm1SOHNIZlJhNjJmRTFXY3Bsc0plZ09yRS8y?=
 =?utf-8?B?VERmdG5oaFdZVHptcExINWhiZGRSbkVKQzBQdmNJMGpXREp1RkJub21CVUVs?=
 =?utf-8?B?djREMEwwZkllMXpZMXVSM2o2WGEzWFp5OHJYTjllQjRBU2w4SE5waDVSaVJk?=
 =?utf-8?B?MWZBU1krR1lLN0ZGSzFtcm54WkVaY04rYXlVT2hoSHJDT1ROZVEremNtVWRT?=
 =?utf-8?B?ZGdVSFliaHRpd1NaOTluckZVSjFuRlhWVXpNQnZZd1Fub0tGaTM5Uk42WlZT?=
 =?utf-8?B?T3VvbjhJWDBNdGV5dklxTUpwdDZFT3h5azEyMnZZdDBYeDN0NjVHaFYrclZ5?=
 =?utf-8?B?MGY3bXFhV25hTTBtS204K0JLYWJhZjRVMG1GZ3d5R1RMMEdNRE5EeTk5eGlq?=
 =?utf-8?B?QWNXM3EzK2lGaVNaSEtPRlZNY2ZYb0RlR0t4VCtGc0lHWGJrbmY5KzBJYkkv?=
 =?utf-8?B?UWRyZUdBdkczZm4wNFVOVlREMkZtVTl2T3ZhaXJiWkNnY21POHl3Z01aN1ZP?=
 =?utf-8?B?cHRrckwvTjNKOStxRlZGMmx5R3VDa2YzMzc4bS95L1ZueXliL2pSTUZhamp6?=
 =?utf-8?B?Y2g4M3FwRXEvWjQ1c0IxMi8vakpKdkZTREw2a2tENitod1BYVmR1bnV1aXRE?=
 =?utf-8?B?TGk2NXo2b3QzclFnU1JhVjVSY0hXcTN1bkdpSC9pUjVDRjdjbnkybFVFR0ha?=
 =?utf-8?B?Zy9ENUs4UllDWUZNZlFxckNmeXNxNWh4ZEhZdHdaSjRoZTd1S2VQaCs5UGg4?=
 =?utf-8?B?dUNSd0pIU1NWdTIyZlI2T3JuNFU5bEplQ1F6dHFmWldIQTMzRHdmZlVva0Zz?=
 =?utf-8?B?ekRGdW5vSDRldU55TkFDRjhkc3VWY1BMSVgzRmZFcmR0dHN3aHAzVWRVREZv?=
 =?utf-8?B?Wkhjb1dPb1RHcnJ2eklyREtDMG44cmRiZWY3SmJKUEV4WVVISWhFRW9OQzk2?=
 =?utf-8?B?MXdQdlNRYUFzVkEzSmFwOFI0MGptWncrVlEzT0Jzc3Z3UytER0dza1h0c1FN?=
 =?utf-8?B?cHJuZ1VVNkpLeGRqc2E4TERvUVBpUTlNQWMxdEZOeWRnZDVST3JlOThsM1JU?=
 =?utf-8?B?dUdCS2dmOU9YQ3BpVEdtd2NRWktlanNFMFZtL3ExUWF1eHpNVGh5dnBmQ1lK?=
 =?utf-8?B?MThxN2dSbFlTYTRVT1h5S1VxMDNPcXFmTGJVczAyTkcvcTRyZVNIMkF0bVFW?=
 =?utf-8?B?K0tKYjNiVEtockVjTXVDc2xLaDByaElMeVBLVjl6N2JLYldzazNRS3ViazdG?=
 =?utf-8?B?bGhZZ1BGaWJ4OHRmbXhGaS9UM3V1SGl0MURPZ2FJaXZzOHRYcjE5bVRjMXp6?=
 =?utf-8?B?Wjd1VGhmQ2ZnSnluK1lmaHZZT1V1TWo0d0tsSjNhcEJiRW1YRjYxMXdhM3kr?=
 =?utf-8?B?RDBoYnZ0b0FGcmlJVGpmOWE5WnFLMmE1dTFYYXQ5S1dnSTFqMkhjSUhWTTZu?=
 =?utf-8?Q?N4TA/rPQpPHvwGK6A2R1ENhgm?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8bea809f-0d0f-4378-4c62-08da9d9e6b6b
X-MS-Exchange-CrossTenant-AuthSource: MW4PR10MB6535.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2022 20:01:36.0652
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LrwtKA+P4P0UAU8P2BFqj4quPFcOJnm6PNgDU9SWf16Z9Bsjvzt6NXZFuduJIBZ2pJjQfubpXSJ8CLRtf6X24Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB5063
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-09-23_08,2022-09-22_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 phishscore=0 mlxlogscore=999
 bulkscore=0 suspectscore=0 adultscore=0 spamscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000
 definitions=main-2209230130
X-Proofpoint-GUID: a8_wFlepIYMNlxNq4_56L-Fqpb7IrwdD
X-Proofpoint-ORIG-GUID: a8_wFlepIYMNlxNq4_56L-Fqpb7IrwdD
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 9/21/2022 7:43 PM, Jason Wang wrote:
> This patch implements features provisioning for vdpa_sim_net.
>
> 1) validating the provisioned features to be a subset of the parent
>     features.
> 2) clearing the features that is not wanted by the userspace
>
> For example:
>
> # vdpa mgmtdev show
> vdpasim_net:
>    supported_classes net
>    max_supported_vqs 3
>    dev_features MTU MAC CTRL_VQ CTRL_MAC_ADDR ANY_LAYOUT VERSION_1 ACCESS_PLATFORM
Sighs, not to blame any one and it's perhaps too late, but this 
"dev_features" attr in "mgmtdev show" command output should have been 
called "supported_features" in the first place.

>
> 1) provision vDPA device with all features that are supported by the
>     net simulator
>
> # vdpa dev add name dev1 mgmtdev vdpasim_net
> # vdpa dev config show
> dev1: mac 00:00:00:00:00:00 link up link_announce false mtu 1500
>    negotiated_features MTU MAC CTRL_VQ CTRL_MAC_ADDR VERSION_1 ACCESS_PLATFORM
Maybe not in this patch, but for completeness for the whole series, 
could we also add device_features to the output?

When simply look at the "vdpa dev config show" output, I cannot really 
tell the actual device_features that was used in vdpa creation. For e.g. 
there is a missing feature ANY_LAYOUT from negotiated_features compared 
with supported_features in mgmtdev, but the orchestration software 
couldn't tell if the vdpa device on destination host should be created 
with or without the ANY_LAYOUT feature.

Thanks,
-Siwei


>
> 2) provision vDPA device with a subset of the features
>
> # vdpa dev add name dev1 mgmtdev vdpasim_net device_features 0x300020000
> # vdpa dev config show
> dev1: mac 00:00:00:00:00:00 link up link_announce false mtu 1500
>    negotiated_features CTRL_VQ VERSION_1 ACCESS_PLATFORM
>
> Reviewed-by: Eli Cohen <elic@nvidia.com>
> Signed-off-by: Jason Wang <jasowang@redhat.com>
> ---
>   drivers/vdpa/vdpa_sim/vdpa_sim_net.c | 11 ++++++++++-
>   1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim_net.c b/drivers/vdpa/vdpa_sim/vdpa_sim_net.c
> index 886449e88502..a9ba02be378b 100644
> --- a/drivers/vdpa/vdpa_sim/vdpa_sim_net.c
> +++ b/drivers/vdpa/vdpa_sim/vdpa_sim_net.c
> @@ -254,6 +254,14 @@ static int vdpasim_net_dev_add(struct vdpa_mgmt_dev *mdev, const char *name,
>   	dev_attr.work_fn = vdpasim_net_work;
>   	dev_attr.buffer_size = PAGE_SIZE;
>   
> +	if (config->mask & BIT_ULL(VDPA_ATTR_DEV_FEATURES)) {
> +		if (config->device_features &
> +		    ~dev_attr.supported_features)
> +			return -EINVAL;
> +		dev_attr.supported_features &=
> +			 config->device_features;
> +	}
> +
>   	simdev = vdpasim_create(&dev_attr);
>   	if (IS_ERR(simdev))
>   		return PTR_ERR(simdev);
> @@ -294,7 +302,8 @@ static struct vdpa_mgmt_dev mgmt_dev = {
>   	.id_table = id_table,
>   	.ops = &vdpasim_net_mgmtdev_ops,
>   	.config_attr_mask = (1 << VDPA_ATTR_DEV_NET_CFG_MACADDR |
> -			     1 << VDPA_ATTR_DEV_NET_CFG_MTU),
> +			     1 << VDPA_ATTR_DEV_NET_CFG_MTU |
> +		             1 << VDPA_ATTR_DEV_FEATURES),
>   	.max_supported_vqs = VDPASIM_NET_VQ_NUM,
>   	.supported_features = VDPASIM_NET_FEATURES,
>   };