Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7af4b1f0-2757-4016-cb48-5fc5bc9f6bc2@samsung.com>
Date:   Sat, 24 Sep 2022 00:02:57 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0)
        Gecko/20100101 Thunderbird/91.13.0
Subject: Re: [PATCH v4 10/30] thermal/drivers/exynos: Replace
 of_thermal_is_trip_valid() by thermal_zone_get_trip()
Content-Language: en-US
To:     Daniel Lezcano <daniel.lezcano@linaro.org>, rafael@kernel.org
Cc:     linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
        rui.zhang@intel.com,
        Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Amit Kucheria <amitk@kernel.org>,
        Alim Akhtar <alim.akhtar@samsung.com>,
        "open list:SAMSUNG THERMAL DRIVER" 
        <linux-samsung-soc@vger.kernel.org>,
        "moderated list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES" 
        <linux-arm-kernel@lists.infradead.org>
From:   Marek Szyprowski <m.szyprowski@samsung.com>
In-Reply-To: <cdbe5e4b-b0b1-3539-2a9a-bbf87a4d8e92@linaro.org>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 201P
References: <20220921094244.606948-1-daniel.lezcano@linaro.org>
        <20220921094244.606948-11-daniel.lezcano@linaro.org>
        <CGME20220923140903eucas1p180002df0deb308d5148cc6004aef7efe@eucas1p1.samsung.com>
        <bc3a5137-b2be-0bfe-003a-db201a7a50e8@samsung.com>
        <cdbe5e4b-b0b1-3539-2a9a-bbf87a4d8e92@linaro.org>
Precedence: bulk

Hi Daniel,

On 23.09.2022 19:40, Daniel Lezcano wrote:
>
> Hi Marek,
>
> thanks for reporting
>
> On 23/09/2022 16:09, Marek Szyprowski wrote:
>
> [ ... ]
>
>> Exception stack(0xf082dfb0 to 0xf082dff8)
>>
>> [deadlock]
>>
>> Something is wrong in locking in the functions from the above 
>> stacktrace.
>
> Are you sure this deadlock is coming from this patch? Does a revert of 
> this patch solve the issue ?
>
Ups, my fault. It looks that I've copied SHA from the wrong window while 
preparing the report. The bisection pointed to the 78ffa3e58d93 
("thermal/core: Add a generic thermal_zone_get_trip() function") commit 
and I've already found how to fix the deadlock. I will report it again 
under the proper patch.


Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland