Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp1680442rwb; Fri, 23 Sep 2022 17:07:35 -0700 (PDT) X-Google-Smtp-Source: AMsMyM56LW4PF7yknH60ymRnAZLMG3DBeeNUKp0i/5frWNb2OE+ZOndfNlpZ5+KR9y/2YQwbDGgN X-Received: by 2002:a05:6402:1e96:b0:451:129e:1a2c with SMTP id f22-20020a0564021e9600b00451129e1a2cmr11269804edf.60.1663978055736; Fri, 23 Sep 2022 17:07:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663978055; cv=none; d=google.com; s=arc-20160816; b=FCeZndBBc/qxnaChfjSQWzf90wNvvSlsQxI5XYwRcJlZac9GjOrG7TEXO7yxFa5gQw 8TEiSmmQM18nCRW+gme3HteTJJgKz5soRTsutCrHWTqFStP7HXJ8wC8q2nG7WUuGhL/8 vONlHDKt/9DV5wMtx73udUfpUsI8m1a97GsqI3G4s0DELgPap0GO/57EK9z0yYXfkzEF eTPDQPV3HXxD5dM6zmA8ebKhDFqWxABNhRqkOyPIEsJZgWFZqfEwSLZRxxzzjhaVzuWM 1rl/DOavcMWKZjkUrHDopsnWo2gK0rtRGGwTrYvqUXjAz0DZSw1NdiTJeRKHcGsqCLzw MfiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:dkim-signature :dkim-signature:from; bh=5V3Z6AhMdpsVP4d3DckyHZHpUKQGjS72cEceALWthyY=; b=LK/ljia5tKmJqP3p+QWFgeE+AlpQ28mB0fPHR7kcFR/tQ2aYzB6nWecM4iQlzeb3U6 Q4S9Jnd8sUaT8NetAIpky6WcnPQbwzDu3DsE7Pp6ekEFsnS3LiRPuU5S2SOrDzNJNZyO CymAtKeMELkixxf+7O8OEUvs/9SBFYZcuYymF6097QMsS5O9LStyl68u5ifIJMx/WcA3 BHtk5Muoxgl87iTLAD6V3NLqnYRYjbgDmHKRcmulucut9qDH9gmzR29HkN7goKwXWF7u BwlpZwV5xSQOpHb/xkafTmoGryhrFKVS+lhShTuzINBoFvMhdnuUw5h4uK6rvgrRSBv9 J/vA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=YbT35guZ; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m4-20020a50d7c4000000b0045242332b55si8678498edj.296.2022.09.23.17.07.09; Fri, 23 Sep 2022 17:07:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=YbT35guZ; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232810AbiIXAFL (ORCPT + 99 others); Fri, 23 Sep 2022 20:05:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232959AbiIXAFE (ORCPT ); Fri, 23 Sep 2022 20:05:04 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67A839DFAB; Fri, 23 Sep 2022 17:04:58 -0700 (PDT) From: John Ogness DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1663977896; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5V3Z6AhMdpsVP4d3DckyHZHpUKQGjS72cEceALWthyY=; b=YbT35guZgiSYqZPsZ7HEpaJ0sOvKpQbPePGoaeyTUm7H/wO1/IFAkSjQMkNg4HoC1rMjla jOG2WQmkJFxhuw2YenY92/zVcdEBo8eSRyStxb7OnII/aJAGAhnWzSRDfyJebHiDKEtYsH VNDjMh4g98gPQQl/3zb/cwRcC7g7EU9DyDPbTqF/6nqU9EH06kz9Dc6JPBe3Kgtp2H0HBH dzs1e8znzH4R2m53tahOEpKMFCwYjvzSFUCrkVqO/G6He6rIqI0eJfHtg/e0V6xFjFnvHn e5shoEqTJMDYCVlN2zoS/cBXquWRftl9TI/0+Iz99De6KVyJMNk7i3vBAsXKLA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1663977896; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5V3Z6AhMdpsVP4d3DckyHZHpUKQGjS72cEceALWthyY=; b=bbbCxJXlhztbHC/ejFyxV3FY+WbK3/0ecpHf3f2KN7q4Su9QrnsgmRYIkGnOJILcTg0FE5 gaPedLj1PMB++VDg== To: Petr Mladek Cc: Sergey Senozhatsky , Steven Rostedt , Thomas Gleixner , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: [PATCH printk 02/18] printk: Declare log_wait properly Date: Sat, 24 Sep 2022 02:10:38 +0206 Message-Id: <20220924000454.3319186-3-john.ogness@linutronix.de> In-Reply-To: <20220924000454.3319186-1-john.ogness@linutronix.de> References: <20220924000454.3319186-1-john.ogness@linutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,INVALID_DATE_TZ_ABSURD, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Thomas Gleixner kernel/printk/printk.c:365:1: warning: symbol 'log_wait' was not declared. Should it be static? Signed-off-by: Thomas Gleixner Signed-off-by: John Ogness Reviewed-by: Sergey Senozhatsky --- fs/proc/kmsg.c | 2 -- include/linux/syslog.h | 3 +++ 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/proc/kmsg.c b/fs/proc/kmsg.c index b38ad552887f..9d6950ac10fe 100644 --- a/fs/proc/kmsg.c +++ b/fs/proc/kmsg.c @@ -18,8 +18,6 @@ #include #include -extern wait_queue_head_t log_wait; - static int kmsg_open(struct inode * inode, struct file * file) { return do_syslog(SYSLOG_ACTION_OPEN, NULL, 0, SYSLOG_FROM_PROC); diff --git a/include/linux/syslog.h b/include/linux/syslog.h index 86af908e2663..955f80e34d4f 100644 --- a/include/linux/syslog.h +++ b/include/linux/syslog.h @@ -8,6 +8,8 @@ #ifndef _LINUX_SYSLOG_H #define _LINUX_SYSLOG_H +#include + /* Close the log. Currently a NOP. */ #define SYSLOG_ACTION_CLOSE 0 /* Open the log. Currently a NOP. */ @@ -35,5 +37,6 @@ #define SYSLOG_FROM_PROC 1 int do_syslog(int type, char __user *buf, int count, int source); +extern wait_queue_head_t log_wait; #endif /* _LINUX_SYSLOG_H */ -- 2.30.2