Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d9e15a0b-0ec9-894b-b0a6-3425af2ddeff@gmail.com>
Date:   Sat, 24 Sep 2022 11:31:16 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] string: Rewrite and add more kern-doc for the str*()
 functions
Content-Language: en-US
To:     Kees Cook <keescook@chromium.org>
Cc:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org,
        linux-doc@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
        Akira Yokosawa <akiyks@gmail.com>
References: <20220922062817.2283352-1-keescook@chromium.org>
From:   Akira Yokosawa <akiyks@gmail.com>
In-Reply-To: <20220922062817.2283352-1-keescook@chromium.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Kees,

On Wed, 21 Sep 2022 23:28:17 -0700, Kees Cook wrote:
> While there were varying degrees of kern-doc for various str*()-family
> functions, many needed updating and clarification, or to just be
> entirely written. Update (and relocate) existing kern-doc and add missing
> functions, sadly shaking my head at how many times I have written "Do
> not use this function". Include the results in the core kernel API doc.
> 
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
> Follow up to https://lore.kernel.org/lkml/20220902223507.2537469-1-keescook@chromium.org
> Note that this is on top of my recent fortify-string.h series:
> https://lore.kernel.org/lkml/20220920192202.190793-1-keescook@chromium.org/
I wanted to test this change, but I've not able to find a good commit
where the fortify-string.h series and this one can be applied cleanly.

Would you mind creating a topic branch somewhere on your git tree
and sharing it?

Regards,
Akira

> ---
>  Documentation/core-api/kernel-api.rst |   3 +
>  include/linux/fortify-string.h        | 133 ++++++++++++++++++++++++--
>  lib/string.c                          |  82 ----------------
>  scripts/kernel-doc                    |   4 +
>  4 files changed, 130 insertions(+), 92 deletions(-)
> 
[...]