Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp1841566rwb; Fri, 23 Sep 2022 20:50:09 -0700 (PDT) X-Google-Smtp-Source: AMsMyM45TqETAvk7yBJzEfxLPT0odCrVQXqbmf7pldywpiZ/2BDUAmffF6AHYfqti5fNMSHVVuPy X-Received: by 2002:a17:902:ea12:b0:178:8e76:c781 with SMTP id s18-20020a170902ea1200b001788e76c781mr11767654plg.136.1663991409512; Fri, 23 Sep 2022 20:50:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663991409; cv=none; d=google.com; s=arc-20160816; b=kjF3k4Ad/ynrdlyTFI3uN3weGrxrKpz4ZrWxKO7cbjXJtOgZypGHDWaSbqy2WOOg3u IQCxelN9770kHUMvLYtX/Q/KeSPfbMNy6HJ17UCMMPZbi+WvlpTSBHCDUSMFXg/y+Vpo zmBThKbpFN79RQd+io/UsNFUyJnB/bEVa2mKfXtwRYkM3J+jJMX99js9p+j3Q/fkz1OL QHEAIc4+xpl0n0mv2pBzuNtEooWZ+IbaTeH9vxB7kto22d6GbloFbXUPRDUJagE5Ug+2 naIIQsv19+pZQWC5kOZqal+9rHypA3bDlBQH+DyI6WaxJQtNNbYEAFz25zDpWL52GHf/ uEeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:sender:dkim-signature; bh=6ie65mmUX7k2h2mobWPlWsffXk7OzouDQ0Bfk3M0MI0=; b=0n0kfTiMeZ5XU8jMwAq7XlgK/xU0HBi8x9jlv2MzkdofA8bNI22yoDIGWqtiC/25af sVDAl5kacu/AEiaEmpzdEV1w0K9FRf4oreaWmQElV6IWuFZcbNOR1awTyM5ZJmq4Cd5l b5SaMIfkle51UP5S8IVy1bLie8GzNxJc1IVcKMvWXy7sBnC2JWBo9nbYmujawQhTYcMU zYA96qT+/ZpKXr1aDcBePNpzPhBAYXU3tRU3ca4UnDB3sQaFnoMgtuq/zdFxg/dr9QV1 9xVSoiNfXoaVHaoCAkNiXkxU+e1qxTAw+8GO16ob3pIvYUKA0FgrmtD74oK/nhihuacQ 9RoA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=YcQRQDG3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ls4-20020a17090b350400b001faf26eed66si5222219pjb.150.2022.09.23.20.49.57; Fri, 23 Sep 2022 20:50:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=YcQRQDG3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233202AbiIXDcV (ORCPT + 99 others); Fri, 23 Sep 2022 23:32:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47486 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233179AbiIXDcQ (ORCPT ); Fri, 23 Sep 2022 23:32:16 -0400 Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [IPv6:2607:f8b0:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E0EFA12AECA; Fri, 23 Sep 2022 20:32:13 -0700 (PDT) Received: by mail-pg1-x52e.google.com with SMTP id bh13so1888630pgb.4; Fri, 23 Sep 2022 20:32:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date; bh=6ie65mmUX7k2h2mobWPlWsffXk7OzouDQ0Bfk3M0MI0=; b=YcQRQDG3wliRsfpTrJV9HWJOu75ovx7pV9imXwjWYU82Ib3R4WOEC6s1Xm9NvHfdmD 1jaOX9sJo7ytEjcafhg8PmEvLfMYCTL1X3P/RNhnbHZsNmOsmfRfsUIkUIMo3DysC4LG KbppjXtOulf0E5s06vwtdd1SDx+0HVHG8zVgcfQBaBKtSr90lW7NVpiX2MVA5Tq/IpZC GZyBtBDB8M/qZGmPfKyAN3F5r+2gi/Cabq2aceYGQkU6rI8yROOnZ8aenzfPcJsDynCg ziHkgKYb1MvZabDayhfI0rqQFqM58/yCLRFJ8nW4gOmKgCuBFNfvdFjXj9lvhqgiUiYV 9Inw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date; bh=6ie65mmUX7k2h2mobWPlWsffXk7OzouDQ0Bfk3M0MI0=; b=eeJuHPTxBdR7QbbI1UYYjMBPJJ9cls4tCDSCTglU8Xn9uffCJuMMJozzH/aYzmx456 I3eOdVPhQg71W7rUM8PmWFD+UmsSK8yc7mMmwzuIplzkwfXxwH2pYORXGNzLofISb70k Zyp7Y0zEa4Ina0lzbJazZvrBYdk5wnyzwq5zcc6VDZ4JxNaSHJ7TZr0ngRCq2l0r58xi 9id/fzhIN1JqtPq126WTPZld3aZX8Aw6cObqyvYyVJdTIuGPS1CZEhZChjf1UHDeTCzK rApovp2+fGsJRWk3XscCI83Ln3/dY+V5yOSC+vvJq7XPPB+42KKv6/WuSWvzIN+ETPGn /kcw== X-Gm-Message-State: ACrzQf2fVrmbPCd6foE2lwbWN+MltJ9cVelWthwjZbvF9QeZqFuJjJS4 Hya1TxHGNHPSVGoRkfoKA9gontALuQ0muA== X-Received: by 2002:a63:942:0:b0:43c:428d:16a9 with SMTP id 63-20020a630942000000b0043c428d16a9mr5963727pgj.423.1663990333192; Fri, 23 Sep 2022 20:32:13 -0700 (PDT) Received: from localhost (2603-800c-1a02-1bae-a7fa-157f-969a-4cde.res6.spectrum.com. [2603:800c:1a02:1bae:a7fa:157f:969a:4cde]) by smtp.gmail.com with ESMTPSA id g10-20020a170902c38a00b001750b31faabsm6646022plg.262.2022.09.23.20.32.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Sep 2022 20:32:12 -0700 (PDT) Sender: Tejun Heo Date: Fri, 23 Sep 2022 17:32:11 -1000 From: Tejun Heo To: Yu Kuai Cc: axboe@kernel.dk, cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, yukuai3@huawei.com, yi.zhang@huawei.com Subject: Re: [PATCH 2/2] blk-throttle: improve bypassing bios checkings Message-ID: References: <20220921095309.1481289-1-yukuai1@huaweicloud.com> <20220921095309.1481289-3-yukuai1@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220921095309.1481289-3-yukuai1@huaweicloud.com> X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 21, 2022 at 05:53:09PM +0800, Yu Kuai wrote: > From: Yu Kuai > > "tg->has_rules" is extended to "tg->has_rules_iops/bps", thus bios that > don't need to be throttled can be checked accurately. > > With this patch, bio will be throttled if: > > 1) Bio is read/write, and corresponding read/write iops limit exist. > 2) If corresponding doesn't exist, corresponding bps limit exist and > bio is not throttled before. > > Signed-off-by: Yu Kuai Acked-by: Tejun Heo Thanks. -- tejun