Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp1904629rwb; Fri, 23 Sep 2022 22:31:10 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4OHmBm+QqY3hQ3I8DXnkIGQu5y5Li8O4+xFFMwvV1V/zR4Mz0xWaj/Wyx6iWLgmVlY+D01 X-Received: by 2002:a05:6402:1941:b0:457:13a:cce9 with SMTP id f1-20020a056402194100b00457013acce9mr492832edz.265.1663997469954; Fri, 23 Sep 2022 22:31:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663997469; cv=none; d=google.com; s=arc-20160816; b=fEBPz/YbTZD4orAV21Q+G/Rsi9P0n/HwjS/jxcwZ2JcHy65+spixJXfdFQBCl5AFjO 3WJgxxPWfGaUh4HdNhGQIuu2IerFtBdiGXNw1lNfl3h5qVsjOZAw8M9lvchfHGacEO79 yoMIl/B6Y6/jwWNTmLOPFsrt5W+V1WzNa8u1W5xmOz0MPS5MTv9cF2JZbADft4QnbxMj LWJBKc3cj28kbipayoTpgCtthqhAyHJGrZohA3lU1B4nnbBi1i5Zav0ZuWGhi/sJDuRy yJwSDv2TR1Gywg0hhzdsDuvpUvlhz7MAYrhZBtdrFvgfdTeDeKSial0GfL5kumCsz0CX nz7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=SryvsTQwltO56wFoDvYodwqQ1nJOEHCTIO0SJE5NltI=; b=NMT93lkGjU67y1XTDSphPQVn6OXBWFlF1nhodGFk6mFeZ8mM4xazum5JHINuu3DicY /TuFmE5lQIZ6wj09OynjkIQkSWAZpnoqbd+0vV3lfbcdiQ2MW0Ce0ErpM/O0jxEudaTC r2YmNSG01hL+JYwA0Ii0j/H4AGBiSzEmlTSO+CHSJOn+2etKjjsps1f02TklruVCt+QA t9K0Q8SxCNBDfaP5hBQ2MYS68UMbC1MhYA+xjdb8XHKCuaUw80+o9LsbLO1R+UKXk+c2 6qO/imEeHK9cDvPaC8WfH2C6DjFedEQLpxhOuS7SFxODB7MXYj5GD9feVGdG/6LN9RGD S3Mw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=ObuYdtRh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ga26-20020a1709070c1a00b007823919b88bsi10505142ejc.654.2022.09.23.22.30.44; Fri, 23 Sep 2022 22:31:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=ObuYdtRh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232550AbiIXEZk (ORCPT + 99 others); Sat, 24 Sep 2022 00:25:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231379AbiIXEZi (ORCPT ); Sat, 24 Sep 2022 00:25:38 -0400 Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 450611903A for ; Fri, 23 Sep 2022 21:25:02 -0700 (PDT) Received: by mail-pj1-x102e.google.com with SMTP id s90-20020a17090a2f6300b00203a685a1aaso1986262pjd.1 for ; Fri, 23 Sep 2022 21:25:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=SryvsTQwltO56wFoDvYodwqQ1nJOEHCTIO0SJE5NltI=; b=ObuYdtRhhEO7gwpcaf1j2KjwMFpw8F5W/TLQdvkECdKCrvzl5XhjxOIVWCFrX9Pum/ Ie1/G7co8F4srMEufyH74VkvfDtJCE9BD7NEc4LuOBhrmD6dRNV5H/A7IBng9Yt9p6wM dJpmNomGeevmMKL2gfWwYGOAY0fBJgpMugGrA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=SryvsTQwltO56wFoDvYodwqQ1nJOEHCTIO0SJE5NltI=; b=xDd4tPQlQOLXIVA8JHVqPsl7/P41G7zLpFXrhJ+PkgYhF5XYzMldiHNdeXLE987aKE nmyq3+pAdkwFhE+lb+Q4iE3OSpaP1PgjpjCWog1aka6+b/Hkj2E2JvzwoJ9hfxgQm0EB g0F8DXkyocFGZaVxcqCzMx2+T+J/nJ3AKFDvypmJdP0lWpxD/VWIUpITJH9/Ade/Nd8A 8vo7yIxobOQkG49zrLfAgPYFspv0PD7aS+fLAHYy2cndKhkYZgWMK7QjJplixsByszcD UVatKg8AWIEJoJh2Ou7qDThRCK6C4K/YKRRPuvF3ZIJLxzdB6q7HceHwAkFJ1eI4/rF6 Ssxg== X-Gm-Message-State: ACrzQf1SjIR812hJcVcaRE3OXniGKaKf6MmxlzN2eDK04Gqwz096tLjx bmo9jPErL7tXob1Ljn4apqsFHA== X-Received: by 2002:a17:90b:38cb:b0:203:100:bb53 with SMTP id nn11-20020a17090b38cb00b002030100bb53mr13412364pjb.107.1663993501436; Fri, 23 Sep 2022 21:25:01 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id b20-20020a630c14000000b0043ab80adf63sm6323708pgl.36.2022.09.23.21.25.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Sep 2022 21:25:00 -0700 (PDT) Date: Fri, 23 Sep 2022 21:24:59 -0700 From: Kees Cook To: Akira Yokosawa Cc: Mauro Carvalho Chehab , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, linux-doc@vger.kernel.org, Jonathan Corbet Subject: Re: [PATCH] string: Rewrite and add more kern-doc for the str*() functions Message-ID: <202209232124.F8233E7@keescook> References: <20220922062817.2283352-1-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 24, 2022 at 11:31:16AM +0900, Akira Yokosawa wrote: > Hi Kees, > > On Wed, 21 Sep 2022 23:28:17 -0700, Kees Cook wrote: > > While there were varying degrees of kern-doc for various str*()-family > > functions, many needed updating and clarification, or to just be > > entirely written. Update (and relocate) existing kern-doc and add missing > > functions, sadly shaking my head at how many times I have written "Do > > not use this function". Include the results in the core kernel API doc. > > > > Signed-off-by: Kees Cook > > --- > > Follow up to https://lore.kernel.org/lkml/20220902223507.2537469-1-keescook@chromium.org > > Note that this is on top of my recent fortify-string.h series: > > https://lore.kernel.org/lkml/20220920192202.190793-1-keescook@chromium.org/ > I wanted to test this change, but I've not able to find a good commit > where the fortify-string.h series and this one can be applied cleanly. > > Would you mind creating a topic branch somewhere on your git tree > and sharing it? Sure! It's part of my devel/hardening branch: https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git/log/?h=devel/hardening Thanks for taking a look! -- Kees Cook