Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 24 Sep 2022 12:47:15 +0530
From:   Vinod Koul <vkoul@kernel.org>
To:     Haotien Hsu <haotienh@nvidia.com>
Cc:     p.zabel@pengutronix.de, jckuo@nvidia.com, kishon@ti.com,
        thierry.reding@gmail.com, jonathanh@nvidia.com,
        linux-phy@lists.infradead.org, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org, Wayne Chang <waynec@nvidia.com>
Subject: Re: [PATCH] phy: tegra: xusb: Enable usb role switch attribute
Message-ID: <Yy6u+9x/oDo4Gd+F@matsya>
References: <20220921112500.798282-1-haotienh@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220921112500.798282-1-haotienh@nvidia.com>
Precedence: bulk

On 21-09-22, 19:25, Haotien Hsu wrote:
> From: Wayne Chang <waynec@nvidia.com>
> 
> This patch enables the usb-role-switch atrribute
> to have the user-space check current device role
> of otg cability ports

typo cability


You can use 72 chars for changelog rather than limiting at 50chars :-(

> 
> Signed-off-by: Wayne Chang <waynec@nvidia.com>
> Signed-off-by: Haotien Hsu <haotienh@nvidia.com>
> ---
>  drivers/phy/tegra/xusb.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
> index aa5237eacd29..220ab7719ade 100644
> --- a/drivers/phy/tegra/xusb.c
> +++ b/drivers/phy/tegra/xusb.c
> @@ -656,6 +656,7 @@ static int tegra_xusb_setup_usb_role_switch(struct tegra_xusb_port *port)
>  	struct usb_role_switch_desc role_sx_desc = {
>  		.fwnode = dev_fwnode(&port->dev),
>  		.set = tegra_xusb_role_sw_set,
> +		.allow_userspace_control = true,
>  	};
>  	int err = 0;
>  
> -- 
> 2.25.1

-- 
~Vinod