Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp2013506rwb; Sat, 24 Sep 2022 01:05:43 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7Gl5pWu8+oPtCHSXtNfrwi3VIXVXrYyC1iIsyIurdaiLeNL+YGssd1Sm90PkumdTAaSwZ9 X-Received: by 2002:a17:902:ac96:b0:178:9faa:6280 with SMTP id h22-20020a170902ac9600b001789faa6280mr12526242plr.34.1664006742820; Sat, 24 Sep 2022 01:05:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664006742; cv=none; d=google.com; s=arc-20160816; b=t4hPmVI2C8chmqz8hWAJJVLqv0qv7B9EbTa+WQpHa48coIwm6imK86kMjZOj2X+sxa MK2Gh+VFS+WVTSGNXVTIvpjsC7d9tDtIo5nyv+xmlwTAm0KntcmZC/VTje3KycjK9zVg BLNn1qb4a13fvdPs21vxaW6iIGhMmv/LnhD6S9tYRFdIvzuSbhh7i06uUiN+qJ3x+AgU 10FjN1o4atArJOtzDg5LlCRhT3gkimqp2vDHnwCPwF2klgPiaq1D4NFMgK5aCrdJ+N4/ +3hqcXKr7AuTXEPDGaB9KeywgszxzwAT8jB8mp41CqVTwyTemYR81gjKrbW/UBLnXt53 k7YA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=4dgFL329LaemJVU3My9q+2jjRpM+44b4x0AiOaFx12Q=; b=Ire8r5zS+nMQSx2p+ItRiQODxEtfUppAcx3Ir8C/rpJThQp86PbyTguXhWvtkEuSdM l8GP7+O+MkDCfBrgDyVI9wk6FsbPqb8H6WFNj+x1Bal+H744djFHaYsHF4cbtUp1HQXt MdYh0F5TBvKTBBBHQWpbuAHSP49Jb37j0f6bqusqar/gD76rIdNGo25j8DJtW5S4ZJKp Ku2g87xHSrbIkEgljtraDeHB2/vO3GRjoOBJqJOsY1cFiB2xBADhjdi2yb69x6SgcuW/ JTXzB4hRRL/CGfayJC0WAlbX0ev077y1EnZR+Pm4aJKNIezvR1kjuSf0Eh4uEUjn4pPO ZG2Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z12-20020a170902cccc00b00172ccb3f4eesi5445245ple.113.2022.09.24.01.05.31; Sat, 24 Sep 2022 01:05:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233507AbiIXHZI (ORCPT + 99 others); Sat, 24 Sep 2022 03:25:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233439AbiIXHYX (ORCPT ); Sat, 24 Sep 2022 03:24:23 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5006913EAC9; Sat, 24 Sep 2022 00:24:22 -0700 (PDT) Received: from canpemm500004.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4MZL4S1dJ4zHtgV; Sat, 24 Sep 2022 15:19:36 +0800 (CST) Received: from huawei.com (10.175.127.227) by canpemm500004.china.huawei.com (7.192.104.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sat, 24 Sep 2022 15:24:19 +0800 From: Jason Yan To: , CC: , , , , , , , Jason Yan Subject: [PATCH v2 8/8] scsi: libsas: use sas_phy_match_port_addr() instead of open coded Date: Sat, 24 Sep 2022 15:34:55 +0800 Message-ID: <20220924073455.2186805-9-yanaijie@huawei.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220924073455.2186805-1-yanaijie@huawei.com> References: <20220924073455.2186805-1-yanaijie@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.127.227] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To canpemm500004.china.huawei.com (7.192.104.92) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The sas address comparation of asd_sas_port and expander phy is open coded. Now we can replace it with sas_phy_match_port_addr(). Signed-off-by: Jason Yan --- drivers/scsi/libsas/sas_expander.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/libsas/sas_expander.c b/drivers/scsi/libsas/sas_expander.c index c9d738ad8176..129e5e365f4e 100644 --- a/drivers/scsi/libsas/sas_expander.c +++ b/drivers/scsi/libsas/sas_expander.c @@ -1005,8 +1005,7 @@ static int sas_ex_discover_dev(struct domain_device *dev, int phy_id) } /* Parent and domain coherency */ - if (!dev->parent && (SAS_ADDR(ex_phy->attached_sas_addr) == - SAS_ADDR(dev->port->sas_addr))) { + if (!dev->parent && sas_phy_match_port_addr(dev->port, ex_phy)) { sas_add_parent_port(dev, phy_id); return 0; } -- 2.31.1