Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Asutosh Das <quic_asutoshd@quicinc.com>,
        "mani@kernel.org" <mani@kernel.org>,
        "quic_nguyenb@quicinc.com" <quic_nguyenb@quicinc.com>,
        "quic_xiaosenh@quicinc.com" <quic_xiaosenh@quicinc.com>,
        "quic_cang@quicinc.com" <quic_cang@quicinc.com>,
        "quic_nitirawa@quicinc.com" <quic_nitirawa@quicinc.com>,
        "quic_rampraka@quicinc.com" <quic_rampraka@quicinc.com>,
        "quic_richardp@quicinc.com" <quic_richardp@quicinc.com>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "adrian.hunter@intel.com" <adrian.hunter@intel.com>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "beanhuo@micron.com" <beanhuo@micron.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>
CC:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        Alim Akhtar <alim.akhtar@samsung.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        open list <linux-kernel@vger.kernel.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-arm-kernel@lists.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@lists.infradead.org>
Subject: RE: [PATCH v1 02/16] ufs: core: Introduce Multi-circular queue
 capability
Thread-Topic: [PATCH v1 02/16] ufs: core: Introduce Multi-circular queue
 capability
Thread-Index: AQHYzujOjRzRZsX1YUi97UOeZb9uua3uO/+g
Date:   Sat, 24 Sep 2022 08:13:38 +0000
Message-ID: <DM6PR04MB6575F55C0A33C049E22C72B6FC509@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <cover.1663894792.git.quic_asutoshd@quicinc.com>
 <fa3d70c1642c64ce75461f630eabe84b3b974d4e.1663894792.git.quic_asutoshd@quicinc.com>
In-Reply-To: <fa3d70c1642c64ce75461f630eabe84b3b974d4e.1663894792.git.quic_asutoshd@quicinc.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?oH08onJLXsrpa6cf5EEmi2J7T7ZfUWgIzEfcoMsmFnmqxsirviz0HQAUZkqe?=
 =?us-ascii?Q?qwKGA1fqJUW39yBI/ma4VlpYmJkBfQAWtewytWbXez4Mwa3rcnjrLolTy2RD?=
 =?us-ascii?Q?kHSv9utwz6xnWVUsVK+EVWrj1+Mz9BhTn8uNgU982rKql/PPzxECZGGRf1wm?=
 =?us-ascii?Q?DfEeNQPRi2Uposg4NKnX3A5tI33wi4SsEXLuQeRq/9NxdxzsRktzzw9uXU+l?=
 =?us-ascii?Q?2ZpLSdDedR+807E60QcJjYkp1epiPGT3hbQLpcowMzxOe06myEkxgILK/Tgs?=
 =?us-ascii?Q?JZvMRYIugNsdspwAQexSQCe42itbt+FR/rhpJ+QnJCzdd0S1hKEvsT2Ky188?=
 =?us-ascii?Q?bwKhBQyD+GWvrUJnvBGXWz+eHZH08KPy1Lv1DQa9lWqbsQC6Kt1+obwSJVFR?=
 =?us-ascii?Q?586L2rl1MXiwPFotnQmagMmwRHW3WDj7TcolsHMN+MT/KRGv6m/Im06bD7tD?=
 =?us-ascii?Q?vVna2lBhCFqgGT+zxG5DbgTkFvgoFSTYFlVZjdRfCpZrUxMyLKSI31CrwyIe?=
 =?us-ascii?Q?OCvf7hxrXL1y8mn9V7UCEfntc/GlCPoNCiu+oX6QW6om9AUFnESRzmPbL2H0?=
 =?us-ascii?Q?t6JNGkJygjK/6sULC/xof9vjnyNdt/rNrcVVKdDtB37Cnb0WxKKavxfxWsnT?=
 =?us-ascii?Q?g61LAsmUQ34LyNWhatQWIfdsii1BePVD+awbX+CFDxFPOMKh6u0iFs10pxSW?=
 =?us-ascii?Q?RjjvG7bHtPbp4OrzU1To7XawGbTvleNsSgw37Is2M2zHP0Mrf5c7/6vd90sr?=
 =?us-ascii?Q?LG5kfAmrx+DIS6cjtpCqnT1YfJXRlx377Zvbd3Q1ZoFNsfnI4im37Q4+b18u?=
 =?us-ascii?Q?WADbaGxPqJloeDaJHUkEgGPQIUwOx/Gvc5xm9Rk/hSRiGIbRu4Wexl2T+Gla?=
 =?us-ascii?Q?qy2fNeGRwQlTyuzcS3xg1MJnRldLcChSaSgrMfVl8dQyhn9BTYc0HI/GCXmC?=
 =?us-ascii?Q?M+ceotKoP1T0iHPXoCgV/s+NTODY9Z86UJ2SUp/N6V8imbge8RsX8GhkY68P?=
 =?us-ascii?Q?H0qxFJQQZsGbp959k9B5/zWnavlZQs8+rC2XZjS8DXdQ+QCFtsn7483BhQBD?=
 =?us-ascii?Q?y0tJ5KbdGLI/Oy/8M1n8AMXy0u6yBh+FlfiEfSN3NOgLT45Oe+aFNWQZZyG/?=
 =?us-ascii?Q?z3lXeV6S7viCPNE7pSwJtDPt4aSUs/XubSh1IL55ZZ9kUDLVjU/6aPYPGAsw?=
 =?us-ascii?Q?LQvMz5bkau2ZQ1kIftDnQmgdE5QJSyDFfykYtTECn9AncOl2bCTcP2jQ0wXS?=
 =?us-ascii?Q?rjOObM+9ZUlesVgFN6yCsnlAYpzBNb7+2xxM43jFstcQA9AE29J/TtniXbeI?=
 =?us-ascii?Q?rmaHjdfhAlAsLI+dxFV7d4g+bo7NM7u3cl+8Ci9e6BPRBx34PbCiVpzXfjB4?=
 =?us-ascii?Q?7my22+VxGil0LBG4XqmCMDV83eV09tMziXR6LtMn8flwQg5bnHPKofv08Umh?=
 =?us-ascii?Q?xCAGXulJz8QhtZBLjEaSuUFou35L9Pca/d2McUe01c0w/W9RtCtIJkmRnUnG?=
 =?us-ascii?Q?GCe4A/2D2MJpnhAATGxRFS5vWoOLa5wD+ujEtIbfd96nd1Ze7MbJx1gkDu+x?=
 =?us-ascii?Q?JyE3QX6Vj4ZZ9ieAwlB7WzCD4KMN+5VVu2sFfxH8?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6575.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c61f4ecf-f9a2-48df-603e-08da9e04af27
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Sep 2022 08:13:38.1841
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: rBtlOlsgyOdv3820V4pbxF4vjVGm5jz3UNClPu+7R5VACyqanQWbkuWGf1zF7Mu2SmrUCKNwV4BJ8eYK0Uwo1A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR04MB8284
X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>=20
>  #define EXT_IID_CAP_SHIFT 10
> +#define MCQ_SUPP_SHIFT 30
>  #define ufshcd_toggle_vreg(_dev, _vreg, _on)                           \
>         ({                                                              \
>                 int _ret;                                               \
> @@ -2240,6 +2241,10 @@ static inline int ufshcd_hba_capabilities(struct
> ufs_hba *hba)
>         if (err)
>                 dev_err(hba->dev, "crypto setup failed\n");
>=20
> +       hba->mcq_sup =3D (hba->capabilities & MASK_MCQ_SUPPORT) >>
> MCQ_SUPP_SHIFT;
Since you are just testing for bit30, MASK_MCQ_SUPPORT is not really needed=
.
Maybe just:
hba->mcq_sup =3D (hba->capabilities >> MCQ_SUPP_SHIFT) & 1;

Thanks,
Avri