Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fcc5bc9f-6b6b-b9ca-45aa-ff2c880a4774@linaro.org>
Date:   Sat, 24 Sep 2022 10:17:50 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH] dt-bindings: firmware: document Qualcomm SM6375 SCM
Content-Language: en-US
To:     Guru Das Srinagesh <quic_gurus@quicinc.com>,
        Konrad Dybcio <konrad.dybcio@somainline.org>
Cc:     ~postmarketos/upstreaming@lists.sr.ht, martin.botka@somainline.org,
        angelogioacchino.delregno@somainline.org,
        marijn.suijten@somainline.org, jamipkettunen@somainline.org,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Robert Marko <robimarko@gmail.com>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220921001020.55307-1-konrad.dybcio@somainline.org>
 <95fb2bfb-6eb8-012d-88f8-c739d229ef70@linaro.org>
 <8faecd72-0cfd-18eb-d07a-53b3a23ed05a@somainline.org>
 <20220924000932.GA1450@quicinc.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20220924000932.GA1450@quicinc.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 24/09/2022 02:09, Guru Das Srinagesh wrote:
> On Sep 21 2022 20:43, Konrad Dybcio wrote:
>> Does it? I did not define this compatible in the driver, so it does
>> not consume any clocks.
> 
> The bindings should describe only those compatibles that the driver supports -
> that is, both the driver and its bindings should be in sync.

That's not entirely true. Bindings describe the hardware in the most
complete way we can. Not the driver. Whether driver supports something
or not, is not relevant here, except that we don't want to document
non-existing things or stuff out of tree.

> 
> Could you please update the driver with this compatible as well? Let's not
> merge this change without that first.

This could be even merged without change in the driver. However it's not
the case here as driver already supports it, so your request is fulfilled.


Best regards,
Krzysztof