Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 24 Sep 2022 11:34:13 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Alex Elder <elder@linaro.org>
Cc:     Douglas Anderson <dianders@chromium.org>, stable@vger.kernel.org,
        swboyd@chromium.org, Mike Tipton <mdtipton@codeaurora.org>,
        Georgi Djakov <djakov@kernel.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Georgi Djakov <georgi.djakov@linaro.org>,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-pm@vger.kernel.org
Subject: Re: [5.10 PATCH] interconnect: qcom: icc-rpmh: Add BCMs to commit
 list in pre_aggregate
Message-ID: <Yy7PFenCa0Sa3B3n@kroah.com>
References: <20220922141725.5.10.1.I791715539cae1355e21827ca738b0b523a4a0f53@changeid>
 <00eb82ca-8bf6-c744-d04d-96b97ce06b17@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <00eb82ca-8bf6-c744-d04d-96b97ce06b17@linaro.org>
Precedence: bulk

On Thu, Sep 22, 2022 at 04:28:25PM -0500, Alex Elder wrote:
> On 9/22/22 4:18 PM, Douglas Anderson wrote:
> > From: Mike Tipton <mdtipton@codeaurora.org>
> > 
> > commit b95b668eaaa2574e8ee72f143c52075e9955177e upstream.
> > 
> > We're only adding BCMs to the commit list in aggregate(), but there are
> > cases where pre_aggregate() is called without subsequently calling
> > aggregate(). In particular, in icc_sync_state() when a node with initial
> > BW has zero requests. Since BCMs aren't added to the commit list in
> > these cases, we don't actually send the zero BW request to HW. So the
> > resources remain on unnecessarily.
> > 
> > Add BCMs to the commit list in pre_aggregate() instead, which is always
> > called even when there are no requests.
> > 
> > Signed-off-by: Mike Tipton <mdtipton@codeaurora.org>
> > [georgi: remove icc_sync_state for platforms with incomplete support]
> > Link: https://lore.kernel.org/r/20211125174751.25317-1-djakov@kernel.org
> > Signed-off-by: Georgi Djakov <djakov@kernel.org>
> > [dianders: dropped sm8350.c which isn't present in 5.10]
> > Signed-off-by: Douglas Anderson <dianders@chromium.org>
> 
> Whoops, sorry about that.
> 
> Acked-by: Alex Elder <elder@linaro.org>

Now queued up, thanks.

greg k-h