Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH v5 08/10] livepatch: Improve the search performance of
 module_kallsyms_on_each_symbol()
From:   "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
To:     Josh Poimboeuf <jpoimboe@kernel.org>,
        Jiri Kosina <jikos@kernel.org>,
        Miroslav Benes <mbenes@suse.cz>,
        Petr Mladek <pmladek@suse.com>,
        Joe Lawrence <joe.lawrence@redhat.com>,
        <live-patching@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Masahiro Yamada <masahiroy@kernel.org>,
        Alexei Starovoitov <ast@kernel.org>,
        Jiri Olsa <jolsa@kernel.org>,
        Kees Cook <keescook@chromium.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        "Luis Chamberlain" <mcgrof@kernel.org>,
        <linux-modules@vger.kernel.org>,
        "Steven Rostedt" <rostedt@goodmis.org>,
        Ingo Molnar <mingo@redhat.com>
References: <20220923112033.1958-1-thunder.leizhen@huawei.com>
 <20220923112033.1958-9-thunder.leizhen@huawei.com>
 <4ef46874-4dbc-2663-ebad-7adbbbfa3b18@huawei.com>
Message-ID: <6cddc5ab-6af5-c221-9383-a45d955af52b@huawei.com>
Date:   Sat, 24 Sep 2022 20:10:57 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.0
MIME-Version: 1.0
In-Reply-To: <4ef46874-4dbc-2663-ebad-7adbbbfa3b18@huawei.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2022/9/24 9:11, Leizhen (ThunderTown) wrote:
> 
> On 2022/9/23 19:20, Zhen Lei wrote:
>> Currently we traverse all symbols of all modules to find the specified
>> function for the specified module. But in reality, we just need to find
>> the given module and then traverse all the symbols in it.
>>
>> In order to achieve this purpose, split the call to hook 'fn' into two
>> phases:
>> 1. Finds the given module. Pass pointer 'mod'. Hook 'fn' directly returns
>>    the comparison result of the module name without comparing the function
>>    name.
>> 2. Finds the given function in that module. Pass pointer 'mod = NULL'.
>>    Hook 'fn' skip the comparison of module name and directly compare
>>    function names.
> Sorry, I forgot to change the description. I will fix it in v6, after I've
> collected review comments.

Oh, It's Saturday, and I don't think anyone's seen v5 yet. So I'll post the v6.
Please skip v5.

> 

-- 
Regards,
  Zhen Lei