Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 24 Sep 2022 14:27:09 +0300
From:   Leon Romanovsky <leon@kernel.org>
To:     Guangbin Huang <huangguangbin2@huawei.com>, kuba@kernel.org
Cc:     davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        lipeng321@huawei.com, lanhao@huawei.com
Subject: Re: [PATCH net-next 00/14] redefine some macros of feature abilities
 judgement
Message-ID: <Yy7pjTX8VLLIiA0G@unreal>
References: <20220924023024.14219-1-huangguangbin2@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220924023024.14219-1-huangguangbin2@huawei.com>
Precedence: bulk

On Sat, Sep 24, 2022 at 10:30:10AM +0800, Guangbin Huang wrote:
> The macros hnae3_dev_XXX_supported just can be used in hclge layer, but
> hns3_enet layer may need to use, so this serial redefine these macros.

IMHO, you shouldn't add new obfuscated code, but delete it.

Jakub,

The more drivers authors will obfuscate in-kernel primitives and reinvent
their own names, macros e.t.c, the less external reviewers you will be able
to attract.

IMHO, netdev should have more active position do not allow obfuscated code.

Thanks

> 
> Guangbin Huang (14):
>   net: hns3: modify macro hnae3_dev_fec_supported
>   net: hns3: modify macro hnae3_dev_udp_gso_supported
>   net: hns3: modify macro hnae3_dev_qb_supported
>   net: hns3: modify macro hnae3_dev_fd_forward_tc_supported
>   net: hns3: modify macro hnae3_dev_ptp_supported
>   net: hns3: modify macro hnae3_dev_int_ql_supported
>   net: hns3: modify macro hnae3_dev_hw_csum_supported
>   net: hns3: modify macro hnae3_dev_tx_push_supported
>   net: hns3: modify macro hnae3_dev_phy_imp_supported
>   net: hns3: modify macro hnae3_dev_ras_imp_supported
>   net: hns3: delete redundant macro hnae3_dev_tqp_txrx_indep_supported
>   net: hns3: modify macro hnae3_dev_hw_pad_supported
>   net: hns3: modify macro hnae3_dev_stash_supported
>   net: hns3: modify macro hnae3_dev_pause_supported
> 
>  drivers/net/ethernet/hisilicon/hns3/hnae3.h   | 55 +++++++++----------
>  .../hns3/hns3_common/hclge_comm_cmd.c         |  2 +-
>  .../hns3/hns3_common/hclge_comm_cmd.h         |  3 -
>  .../ethernet/hisilicon/hns3/hns3_debugfs.c    |  2 +-
>  .../net/ethernet/hisilicon/hns3/hns3_enet.c   | 10 ++--
>  .../ethernet/hisilicon/hns3/hns3_ethtool.c    | 14 ++---
>  .../hisilicon/hns3/hns3pf/hclge_debugfs.c     |  2 +-
>  .../hisilicon/hns3/hns3pf/hclge_main.c        | 38 ++++++-------
>  .../hisilicon/hns3/hns3pf/hclge_ptp.c         |  2 +-
>  .../hisilicon/hns3/hns3vf/hclgevf_main.c      |  2 +-
>  10 files changed, 62 insertions(+), 68 deletions(-)
> 
> -- 
> 2.33.0
>