Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0e3053c1-4a6b-987a-3bbd-1c01cdd31657@linux.alibaba.com>
Date:   Sat, 24 Sep 2022 21:25:45 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.2.2
Subject: Re: [PATCH] tracing/eprobe: Fix alloc event dir failed when event
 name no set
To:     "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Cc:     Steven Rostedt <rostedt@goodmis.org>,
        Ingo Molnar <mingo@redhat.com>,
        Tzvetomir Stoyanov <tz.stoyanov@gmail.com>,
        linux-kernel@vger.kernel.org
References: <1663504148-40723-1-git-send-email-chentao.kernel@linux.alibaba.com>
 <20220923142914.3488abb9f60422f27584896e@kernel.org>
From:   Tao Chen <chentao.kernel@linux.alibaba.com>
In-Reply-To: <20220923142914.3488abb9f60422f27584896e@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

在 2022/9/23 下午1:29, Masami Hiramatsu (Google) 写道:
> On Sun, 18 Sep 2022 20:29:08 +0800
> Tao Chen <chentao.kernel@linux.alibaba.com> wrote:
> 
>> The event dir will alloc failed when event name no set, using the
>> command:
>> "echo "e:esys/ syscalls/sys_enter_openat file=\$filename:string"
>>>> dynamic_events"
>> It seems that dir name="syscalls/sys_enter_openat" is not allowed
>> in debugfs. So just use the "sys_enter_openat" as the event name.
> 
> Good catch!
> 
>>
>> Fixes: 7491e2c44278 ("tracing: Add a probe that attaches to trace
>> events")
> 
> But actually, this code was introduced by below commit, so Fixes tag
> must be updated. (this is important because stable backport version
> will be decided by this tag.)
> 
> Fixes: 95c104c378dc ("tracing: Auto generate event name when creating a group of events")
> 
> Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> 
> Thank you!
> 
>> Signed-off-by: Tao Chen <chentao.kernel@linux.alibaba.com>
>> ---
>>   kernel/trace/trace_eprobe.c | 3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/kernel/trace/trace_eprobe.c b/kernel/trace/trace_eprobe.c
>> index 1783e3478912..a8938e54cd34 100644
>> --- a/kernel/trace/trace_eprobe.c
>> +++ b/kernel/trace/trace_eprobe.c
>> @@ -968,8 +968,7 @@ static int __trace_eprobe_create(int argc, const char *argv[])
>>   	}
>>   
>>   	if (!event) {
>> -		strscpy(buf1, argv[1], MAX_EVENT_NAME_LEN);
>> -		sanitize_event_name(buf1);
>> +		strscpy(buf1, sys_event, MAX_EVENT_NAME_LEN);
>>   		event = buf1;
>>   	}
>>   
>> -- 
>> 2.32.0
>>
> 
> 
Thank you for your review, i will change it in v2.