Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220924004221.841024-1-namhyung@kernel.org> <20220924004221.841024-3-namhyung@kernel.org>
 <7c89e623-c90f-181b-d22a-e1349ddb3340@intel.com>
In-Reply-To: <7c89e623-c90f-181b-d22a-e1349ddb3340@intel.com>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Sat, 24 Sep 2022 09:50:04 -0700
Message-ID: <CAM9d7ciURCEeJGPDRtSN9U1JD7dtYWB_Mthf4m=Svw314ZtSvw@mail.gmail.com>
Subject: Re: [PATCH 3/3] perf test: Add kernel lock contention test
To:     Adrian Hunter <adrian.hunter@intel.com>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Jiri Olsa <jolsa@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Ian Rogers <irogers@google.com>,
        linux-perf-users <linux-perf-users@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, Sep 24, 2022 at 1:10 AM Adrian Hunter <adrian.hunter@intel.com> wrote:
>
> On 24/09/22 03:42, Namhyung Kim wrote:
> > Add a new shell test to check if both normal perf lock record +
> > contention and BPF (with -b) option are working.  Use perf bench
> > sched messaging as a workload since it'd create some contention for
> > sending and receiving messages.
> >
> > Signed-off-by: Namhyung Kim <namhyung@kernel.org>
>
> There are a few things below that don't need to be fixed but
> are perhaps things to be aware of.
>
> Nevertheless:
>
> Acked-by: Adrian Hunter <adrian.hunter@intel.com>

Thanks Adrian, I'll install and run shellcheck next time.

Arnaldo, please let me know if you want me to resend it
with the suggested changes.

Thanks,
Namhyung