Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=utf-8
MIME-Version: 1.0
Subject: Re: [PATCH] mm: fix misuse of update_mmu_cache() in
 do_anonymous_page()
From:   Muchun Song <muchun.song@linux.dev>
In-Reply-To: <20220924053239.91661-1-zhengqi.arch@bytedance.com>
Date:   Sun, 25 Sep 2022 09:43:34 +0800
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Linux MM <linux-mm@kvack.org>, linux-kernel@vger.kernel.org,
        chris@zankel.net, jcmvbkbc@gmail.com, maobibo@loongson.cn
Content-Transfer-Encoding: quoted-printable
Message-Id: <3A09E40A-E2C5-4C6F-8550-DD0E17B7DAB9@linux.dev>
References: <20220924053239.91661-1-zhengqi.arch@bytedance.com>
To:     Qi Zheng <zhengqi.arch@bytedance.com>
Precedence: bulk


> On Sep 24, 2022, at 13:32, Qi Zheng <zhengqi.arch@bytedance.com> =
wrote:
>=20
> As message in commit 7df676974359 ("mm/memory.c: Update local TLB
> if PTE entry exists") said, we should update local TLB only on the
> second thread. So fix the misuse of update_mmu_cache() by using
> update_mmu_tlb() in the do_anonymous_page().
>=20
> Signed-off-by: Qi Zheng <zhengqi.arch@bytedance.com>

The change looks good to me. However, I am not sure what is the =
user-visible
effect to xtensa users. So Cc xtensa=E2=80=99s maintainer and the author =
of 7df676974359
to double check this.


But anyway:

Reviewed-by: Muchun Song <songmuchun@bytedance.com>