Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 25 Sep 2022 10:23:08 +0900
From:   Masami Hiramatsu (Google) <mhiramat@kernel.org>
To:     Chen Zhongjin <chenzhongjin@huawei.com>
Cc:     <linux-kernel@vger.kernel.org>, <tglx@linutronix.de>,
        <mingo@redhat.com>, <bp@alien8.de>, <dave.hansen@linux.intel.com>,
        <x86@kernel.org>, <hpa@zytor.com>, <mhiramat@kernel.org>,
        <jpoimboe@kernel.org>, <rostedt@goodmis.org>,
        <peterz@infradead.org>, <namit@vmware.com>
Subject: Re: [PATCH -next] x86: kprobes: Remove unused macro stack_addr
Message-Id: <20220925102308.96ed6863020cfbebd69223ee@kernel.org>
In-Reply-To: <20220924072629.104759-1-chenzhongjin@huawei.com>
References: <20220924072629.104759-1-chenzhongjin@huawei.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Sat, 24 Sep 2022 15:26:29 +0800
Chen Zhongjin <chenzhongjin@huawei.com> wrote:

> An unused macro reported by [-Wunused-macros].
> 
> This macro is used to access the sp in pt_regs because at that time
> x86_32 can only get sp by kernel_stack_pointer(regs).
> 
> '3c88c692c287 ("x86/stackframe/32: Provide consistent pt_regs")'
> This commit have unified the pt_regs and from them we can get sp from
> pt_regs with regs->sp easily. Nowhere is using this macro anymore.
> 
> Refrencing pt_regs directly is more clear. Remove this macro for
> code cleaning.

Thanks for the clean up!

Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>

Thank you,

> 
> Signed-off-by: Chen Zhongjin <chenzhongjin@huawei.com>
> ---
>  arch/x86/kernel/kprobes/core.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/x86/kernel/kprobes/core.c b/arch/x86/kernel/kprobes/core.c
> index 4c3c27b6aea3..eb8bc82846b9 100644
> --- a/arch/x86/kernel/kprobes/core.c
> +++ b/arch/x86/kernel/kprobes/core.c
> @@ -59,8 +59,6 @@
>  DEFINE_PER_CPU(struct kprobe *, current_kprobe) = NULL;
>  DEFINE_PER_CPU(struct kprobe_ctlblk, kprobe_ctlblk);
>  
> -#define stack_addr(regs) ((unsigned long *)regs->sp)
> -
>  #define W(row, b0, b1, b2, b3, b4, b5, b6, b7, b8, b9, ba, bb, bc, bd, be, bf)\
>  	(((b0##UL << 0x0)|(b1##UL << 0x1)|(b2##UL << 0x2)|(b3##UL << 0x3) |   \
>  	  (b4##UL << 0x4)|(b5##UL << 0x5)|(b6##UL << 0x6)|(b7##UL << 0x7) |   \
> -- 
> 2.17.1
> 


-- 
Masami Hiramatsu (Google) <mhiramat@kernel.org>