Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp3258841rwb; Sun, 25 Sep 2022 03:21:15 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4Sivx8HmCpM7OT9cluzzmH3mMKQ084u/kK+BvzEj2j5ee3KyWv86SewvOP+dMqXg+MeuPw X-Received: by 2002:a17:907:7615:b0:77b:1426:1ae8 with SMTP id jx21-20020a170907761500b0077b14261ae8mr13709858ejc.137.1664101275332; Sun, 25 Sep 2022 03:21:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664101275; cv=none; d=google.com; s=arc-20160816; b=yWeb/QMLOCPYQ+TYEV+L9fwNvb38D3KFfmXszw8p/yHmz7MRVqiCvHSl2i1LudvnCI jD7xcsuPy1PeG4tiDiIMQPoOCAAZzMfKGr2pjjTWjqPrsRHiTnilrzqK5agSTvXBMLoI JdiOxVxl4hhEDkZK3l2fYQluNqBsT1yOrOlNGHpT6or7LD18Mi1wjoqvna9XBvJZmAbe J5frtxwzaozVeHrA5g6WegqErLpGmQGeDxo/72/OA5rpbyNUNzA8CVe/N513Xm15+k3L z9+ttG93k+i2LBmn0IRubRFnVqHX47+BfmbVGVbpfoREfnrAN/kBXEiH0c/AruioFGF4 ITDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=643kmgQHWhl12/k6/HF2CRMqw21HVBXmthYTfb7XxiA=; b=FiDvQg5BOkJVlv5cPwVU3S/TSHWaJSe8eGPLIuIZWMKy5VULnb7M94ht8CZf5a2tfJ +mGwin+aL3KNO52gsd0P2NIJ9JRfLjZgjAAEUQg+HjMv62TuXECsDpzm99O17SbkIRr8 O2vvu1IPyepoXXvhZ4Pos+s2x+WbZ5ymIkaFfoF5n5moqFrT7Byp+gJccEq6ICc0oLUC S508MZ+qY9wPIaEujkJ+84zzvuIr8cHhQw9IuoPX/X9x77i+pzMRpSqgY9LgNONmyFMg QFbNpk4d/2+YgI03bWoRnGxBo1IqQOOU6CTlzaohrxkEbXzcvAN6aJBqtuZ3Ky0FR5ax 6CQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=rr+0KUBp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ht13-20020a170907608d00b00780e89ce0b0si11884601ejc.600.2022.09.25.03.20.49; Sun, 25 Sep 2022 03:21:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=rr+0KUBp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230381AbiIYKHV (ORCPT + 99 others); Sun, 25 Sep 2022 06:07:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230230AbiIYKHT (ORCPT ); Sun, 25 Sep 2022 06:07:19 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 053182F658; Sun, 25 Sep 2022 03:07:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9DE8C6068C; Sun, 25 Sep 2022 10:07:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A4831C433C1; Sun, 25 Sep 2022 10:07:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1664100438; bh=zlpoVVnJkiDuk0yXJbjiyJ92BfoyGTcKVWHPSNH/Q4w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rr+0KUBp+DomVZlSUpT81467stBA08w7bFb6FF7fucOxYFxsQzBv81bhm+/LtZ0P3 zhA3efJ2RzQpAmLZLAD4ERA2kntyuPA+C/JJ4vm//m3pAFDMKVHJxD/+UEn42NUbgj uRYdoYImwHz6G8AKBT6WyE5XXXa55bXRzVKCgFNY= Date: Sun, 25 Sep 2022 12:07:15 +0200 From: Greg KH To: Jens Glathe Cc: mathias.nyman@intel.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] fix: add XHCI_SPURIOUS_SUCCESS to ASM1042 despite being a V0.96 controller Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 25, 2022 at 10:02:53AM +0000, Jens Glathe wrote: > Yep, found it. Them pesky editors... > > thanks, > > Jens Glathe > > --- > > > From 8d6e467569118b83a4622edf09768ba20aef5086 Mon Sep 17 00:00:00 2001 > From: Jens Glathe > Date: Sun, 28 Aug 2022 16:23:41 +0200 > Subject: [PATCH] fix: add XHCI_SPURIOUS_SUCCESS to ASM1042 despite being a > V0.96 controller > > only if it reports as a V0.96 XHCI controller. Appears to fix the errors > "xhci_hcd
; ERROR Transfer event TRB DMA ptr not part of > current TD ep_index 2 comp_code 13" that appear spuriously (or pretty > often) when using a r8152 USB3 ethernet adapter with integrated hub. > > Signed-off-by: Jens Glathe > --- > drivers/usb/host/xhci-pci.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c > index dce6c0ec8d34..d1b8e7148dd1 100644 > --- a/drivers/usb/host/xhci-pci.c > +++ b/drivers/usb/host/xhci-pci.c > @@ -306,8 +306,12 @@ static void xhci_pci_quirks(struct device *dev, struct > xhci_hcd *xhci) > } > > if (pdev->vendor == PCI_VENDOR_ID_ASMEDIA && > - pdev->device == PCI_DEVICE_ID_ASMEDIA_1042_XHCI) > + pdev->device == PCI_DEVICE_ID_ASMEDIA_1042_XHCI) { > + /* try to tame the ASMedia 1042 controller which is 0.96 */ > + if (xhci->hci_version == 0x96) > + xhci->quirks |= XHCI_SPURIOUS_SUCCESS; > xhci->quirks |= XHCI_BROKEN_STREAMS; > + } > if (pdev->vendor == PCI_VENDOR_ID_ASMEDIA && > pdev->device == PCI_DEVICE_ID_ASMEDIA_1042A_XHCI) { > xhci->quirks |= XHCI_TRUST_TX_LENGTH; > -- > 2.25.1 > > --- > > replaced spaces with tabs Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - Your patch is malformed (tabs converted to spaces, linewrapped, etc.) and can not be applied. Please read the file, Documentation/email-clients.txt in order to fix this. - Your patch was attached, please place it inline so that it can be applied directly from the email message itself. - This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what needs to be done here to properly describe this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot