Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Xiaochun XC17 Li <lixc17@lenovo.com>
To:     kernel test robot <lkp@intel.com>,
        Xiaochun Lee <lixiaochun.2888@163.com>,
        "nirmal.patel@linux.intel.com" <nirmal.patel@linux.intel.com>,
        "jonathan.derrick@linux.dev" <jonathan.derrick@linux.dev>
CC:     "kbuild-all@lists.01.org" <kbuild-all@lists.01.org>,
        "lpieralisi@kernel.org" <lpieralisi@kernel.org>,
        "robh@kernel.org" <robh@kernel.org>, "kw@linux.com" <kw@linux.com>,
        "bhelgaas@google.com" <bhelgaas@google.com>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [External] Re: [PATCH v1] PCI: Set no io resource for bridges
 that behind VMD controller
Thread-Topic: [External] Re: [PATCH v1] PCI: Set no io resource for bridges
 that behind VMD controller
Thread-Index: AQHYz2BIWx7Cgru9UkOHmlkYLatCTq3v5wzg
Date:   Sun, 25 Sep 2022 09:52:21 +0000
Message-ID: <SEYPR03MB68772E818ECCE020FEF785DBBC539@SEYPR03MB6877.apcprd03.prod.outlook.com>
References: <1663075485-20591-1-git-send-email-lixiaochun.2888@163.com>
 <202209240714.ronvmf1X-lkp@intel.com>
In-Reply-To: <202209240714.ronvmf1X-lkp@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?EgyYetiNmjW5u5UcO2n3E02xCWQkFJsrGdq/61FgzaMztzfpeAFfVcWH+9qC?=
 =?us-ascii?Q?K/bmFRsxhLifo2vL4eTakLD8V7mW5qf0ljBTqj/dcqLKZqa2der2n70zZcul?=
 =?us-ascii?Q?aXYbu1nww08/uB6UTeNkAei9lOpY7TOVIW5XoHCGj/UiJHqegzSCgkKgb41f?=
 =?us-ascii?Q?qa5iCRkIrNUvosPTvdxJFQKZKTsFwEKM80Qp9VFsQFlBbDgLqj6RmelOb1KO?=
 =?us-ascii?Q?D9D+1x+u7JLkCTsFDd4ILNvZifT9vvr+efuEtmXcvGO9EzrbYF75NMAybwFc?=
 =?us-ascii?Q?30HLtltX+nwMyICUFhXZS4rhw05HjSoFOAqAbaIkjzBZtb6bGmA4zAYas7RO?=
 =?us-ascii?Q?MePTL8iFvh3SEOLlft4ZTnrqpH1I/Ipj1BgwzZ6U9I4w3+dybFHGwCO3baqJ?=
 =?us-ascii?Q?saU1+Sgo/uRnmVDMCYubEmAM/lIby2Wqwv4YgvSA47kPsb2UD+k3SjlL1ntp?=
 =?us-ascii?Q?yhj4/uWZfg6aaxqfn1KlK3R4IFcYvruaWKoA/Hp+avsxAiSUlgjicBrP0fzm?=
 =?us-ascii?Q?khPFBGEgDpSUorTfZOcSfTFrj6D0q3ocDwgkvMheVyTfJtPNjfj1dyUzQEzs?=
 =?us-ascii?Q?aaIRqy8TBPysdGRMYJpC+cBZ+IUdIvXTP5M4qTiJL44eM5U6p2EyTVaiKwKh?=
 =?us-ascii?Q?slqhQcbmZrvFxRzN0nnmKyRsvKKaxg8EQ3rkqeRssyCPBojHBziWd9t6rJRn?=
 =?us-ascii?Q?/Ag2/EK2shv9PTekP+bD4GsDkvtk3gkdlC/DdP1Hq0eCrZvr5ZwGGqsJPN2J?=
 =?us-ascii?Q?YsNzmAQvi+RPvn7VSNQNgFha6GeVgscETIpV7LfOxpOwR9PlsuS5HWZWyLgc?=
 =?us-ascii?Q?2WDCtHA1+Wf3V17N8Z4GilAuiuo57/CEl5Ju1VaT7oRjnYT+jU/FmcdfdUuK?=
 =?us-ascii?Q?ogNyQ+JjWDx7/fVP3Ub1hpVHvU8Vv6/PdIN7AZVphIVMEKpF75U754RSuey2?=
 =?us-ascii?Q?0xwnBonCpnFBEd9AUyz7P6YsA9qTUBD2e3Oce/xcEXZd81vXshYuZCjB3M2J?=
 =?us-ascii?Q?ZCEUX6d4a7DNIFspvuWM7sJS3Clu6jPM9TqABqsCpihuux6MgZTbKZLE+Cu6?=
 =?us-ascii?Q?ChBd6WVfgU9QcCd9l1U2oNTK9n2jawukZvzrQfMR0jH37K1bvnNbeA+lnAvx?=
 =?us-ascii?Q?5KAGZ98XgPJ+YgYD9LrPFZNHgUpR5BPxbC/zLZZyPawNmBtQbkI+PaIRQopo?=
 =?us-ascii?Q?CYg6wgdxpPapUBtOmnSBwBDgLltjzBO8G3/2fiG97rzLRDVKJU7Tr4uq8DTz?=
 =?us-ascii?Q?+GcDk4ZS4mRW8eqZaRfrlJR2x86nqg0A3K9ApVTifajV0peIJqtthsCsZ0o3?=
 =?us-ascii?Q?4eaqbVQwlP053prAfcokssHIg2cgJ6R6SrwZGZUmv1DHjDda7Ryd8MKURhr+?=
 =?us-ascii?Q?VsKsuG1IkhhEvinDt30V1J4ShL0EaP2LA6+EAsMMNebfE3EdhjnlG3nc7Unu?=
 =?us-ascii?Q?JCOfooG2ec/q3cu1yqVUzPDLKZoQrRR2+B78sH7ZLoZuiFRgbBHXgBRvHOVf?=
 =?us-ascii?Q?oDWroGBc25Ssa2DN4vhtg8aUq6GPUds1c+SxonCkd3fQ5QskWGQDkDxWONlH?=
 =?us-ascii?Q?ZRpO0sWkGZMBN6ff05Q=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: lenovo.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SEYPR03MB6877.apcprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 49690291-e6a8-4704-b0de-08da9edba412
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Sep 2022 09:52:21.3905
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5c7d0b28-bdf8-410c-aa93-4df372b16203
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Wre+P3+8Pw0vLhO8nTQT+22qMtzcbGjlkAqga6MefIH5Fk3Fw0KhAKODtPhZqS2kun6rINpOgZKHRz33xjVV0w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR03MB5831
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

> -----Original Message-----
> From: kernel test robot <lkp@intel.com>
> Sent: Friday, September 23, 2022 11:21 PM
> To: Xiaochun Lee <lixiaochun.2888@163.com>;
> nirmal.patel@linux.intel.com; jonathan.derrick@linux.dev
> Cc: kbuild-all@lists.01.org; lpieralisi@kernel.org; robh@kernel.org;
> kw@linux.com; bhelgaas@google.com; linux-pci@vger.kernel.org; linux-
> kernel@vger.kernel.org; Xiaochun XC17 Li <lixc17@lenovo.com>
> Subject: [External] Re: [PATCH v1] PCI: Set no io resource for bridges th=
at
> behind VMD controller
>=20
> Hi Xiaochun,
>=20
> Thank you for the patch! Yet something to improve:
>=20
> [auto build test ERROR on helgaas-pci/next] [also build test ERROR on
> linus/master v6.0-rc6 next-20220923] [If your patch is applied to the wro=
ng
> git tree, kindly drop us a note.
Hi, thanks for your reply, this patch is only expected to be applied
on x86 or x64, actually function "is_vmd()" is just defined in
arch/x86/include/asm/pci.h, do we need to support it on arch um?

> And when submitting patch, we suggest to use '--base' as documented in
> https://apc01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgit-
> scm.com%2Fdocs%2Fgit-format-
> patch%23_base_tree_information&amp;data=3D05%7C01%7Clixc17%40lenov
> o.com%7C63bd7990b33f4dd9b4bc08da9d77696c%7C5c7d0b28bdf8410caa9
> 34df372b16203%7C0%7C0%7C637995433448231363%7CUnknown%7CTWF
> pbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJX
> VCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=3DTGZ2LnHsHCrJLW7WBBMZ
> lFxv8SIaQNmCGC1bEv2BEDE%3D&amp;reserved=3D0]
>=20
> url:
> https://apc01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgithu
> b.com%2Fintel-lab-lkp%2Flinux%2Fcommits%2FXiaochun-Lee%2FPCI-Set-
> no-io-resource-for-bridges-that-behind-VMD-controller%2F20220913-
> 213745&amp;data=3D05%7C01%7Clixc17%40lenovo.com%7C63bd7990b33f4d
> d9b4bc08da9d77696c%7C5c7d0b28bdf8410caa934df372b16203%7C0%7C0
> %7C637995433448231363%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLj
> AwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C
> %7C%7C&amp;sdata=3D3NULvkgYg0fWTopgYY5EYHsLIBPdTEcMxbz5Tj12D0E%
> 3D&amp;reserved=3D0
> base:
> https://apc01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgit.k
> ernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fhelgaas%2Fpci.git&a
> mp;data=3D05%7C01%7Clixc17%40lenovo.com%7C63bd7990b33f4dd9b4bc08
> da9d77696c%7C5c7d0b28bdf8410caa934df372b16203%7C0%7C0%7C63799
> 5433448231363%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiL
> CJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&a
> mp;sdata=3DZTZ7kKlwOk7IB3MN0rRwqHaNGGl4OiwrR7AjImBbTqc%3D&amp;
> reserved=3D0 next
> config: um-allmodconfig
> (https://apc01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fdow
> nload.01.org%2F0day-
> ci%2Farchive%2F20220924%2F202209240714.ronvmf1X-
> lkp%40intel.com%2Fconfig&amp;data=3D05%7C01%7Clixc17%40lenovo.com%
> 7C63bd7990b33f4dd9b4bc08da9d77696c%7C5c7d0b28bdf8410caa934df372
> b16203%7C0%7C0%7C637995433448231363%7CUnknown%7CTWFpbGZsb3
> d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0
> %3D%7C3000%7C%7C%7C&amp;sdata=3D6xMM7Fh9bKGnzBlmeu8kki3yvGGQ
> 2k%2FKCp%2BqvoLt4zU%3D&amp;reserved=3D0)
> compiler: gcc-11 (Debian 11.3.0-5) 11.3.0 reproduce (this is a W=3D1 buil=
d):
>         #
> https://apc01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgithu
> b.com%2Fintel-lab-
> lkp%2Flinux%2Fcommit%2Ff97a8ba561d7cf5a755c8f42421138e8b1073cf9&
> amp;data=3D05%7C01%7Clixc17%40lenovo.com%7C63bd7990b33f4dd9b4bc0
> 8da9d77696c%7C5c7d0b28bdf8410caa934df372b16203%7C0%7C0%7C6379
> 95433448387557%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAi
> LCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&
> amp;sdata=3D4mjCA86AEbwN9eIiw1%2BLUPlf0%2BV2juqoDo7ojKSMweY%3D
> &amp;reserved=3D0
>         git remote add linux-review
> https://apc01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgithu
> b.com%2Fintel-lab-
> lkp%2Flinux&amp;data=3D05%7C01%7Clixc17%40lenovo.com%7C63bd7990b3
> 3f4dd9b4bc08da9d77696c%7C5c7d0b28bdf8410caa934df372b16203%7C0%
> 7C0%7C637995433448387557%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC
> 4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000
> %7C%7C%7C&amp;sdata=3DYusFni1tvPN89d2e%2B8yADL3jbwjuydLs0RD3NSjj
> 2MA%3D&amp;reserved=3D0
>         git fetch --no-tags linux-review Xiaochun-Lee/PCI-Set-no-io-resou=
rce-
> for-bridges-that-behind-VMD-controller/20220913-213745
>         git checkout f97a8ba561d7cf5a755c8f42421138e8b1073cf9
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         make W=3D1 O=3Dbuild_dir ARCH=3Dum SHELL=3D/bin/bash
>=20
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@intel.com>
>=20
> All errors (new ones prefixed by >>):
>=20
>    drivers/pci/quirks.c: In function 'quirk_vmd_no_iosize':
> >> drivers/pci/quirks.c:5985:13: error: implicit declaration of function
> >> 'is_vmd' [-Werror=3Dimplicit-function-declaration]
>     5985 |         if (is_vmd(bridge->bus) && bridge->is_hotplug_bridge) =
{
>          |             ^~~~~~
>    cc1: some warnings being treated as errors
>=20
>=20
> vim +/is_vmd +5985 drivers/pci/quirks.c
>=20
>   5959
>   5960	#if defined(CONFIG_X86_64) || defined(CONFIG_X86)
>   5961	/*
>   5962	 * VMD-enabled root ports use Enhanced Configuration Access
> Mechanism (ECAM)
>   5963	 * access PCI Express configuration space, and offer VMD_CFGBAR
> as
>   5964	 * base of PCI Express configuration space for the bridges behind =
it.
>   5965	 * The configuration space includes IO resources, but these IO
>   5966	 * resources are not actually used on X86, especially the NVMes as
>   5967	 * device connnected on this hot plug bridges, and it can result
>   5968	 * in BAR#13 assign IO resource failed. So we clear IO resources
>   5969	 * by setting an IO base value greater than limit to these bridges=
.
>   5970	 * Hence, append kernel parameter "pci=3Dhpiosize=3D0KB" can avoid
>   5971	 * this BAR#13 failed messages show out.
>   5972	 */
>   5973	static void quirk_vmd_no_iosize(struct pci_dev *bridge)
>   5974	{
>   5975		u8 io_base_lo, io_limit_lo;
>   5976		u16 io_low;
>   5977		u32 io_upper16;
>   5978		unsigned long io_mask,  base, limit;
>   5979
>   5980		io_mask =3D PCI_IO_RANGE_MASK;
>   5981		if (bridge->io_window_1k)
>   5982			io_mask =3D PCI_IO_1K_RANGE_MASK;
>   5983
>   5984		/* VMD Domain */
> > 5985		if (is_vmd(bridge->bus) && bridge->is_hotplug_bridge) {
>=20
> --
> 0-DAY CI Kernel Test Service
> https://apc01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2F01.or
> g%2Flkp&amp;data=3D05%7C01%7Clixc17%40lenovo.com%7C63bd7990b33f4
> dd9b4bc08da9d77696c%7C5c7d0b28bdf8410caa934df372b16203%7C0%7C0
> %7C637995433448387557%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLj
> AwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C
> %7C%7C&amp;sdata=3D4qYtyE86mw9VyFbB3QKJqtldq6relV2Cunv9STAmmqA
> %3D&amp;reserved=3D0