Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a4146b46-4936-80c9-8839-45bbe2c39cb6@gmx.de>
Date:   Sun, 25 Sep 2022 13:12:19 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH] fbdev: remove redundant initialization to variable
 identical
Content-Language: en-US
To:     Colin Ian King <colin.i.king@gmail.com>,
        Bernie Thompson <bernie@plugable.com>,
        linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org
Cc:     kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220907135056.679617-1-colin.i.king@gmail.com>
From:   Helge Deller <deller@gmx.de>
In-Reply-To: <20220907135056.679617-1-colin.i.king@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 9/7/22 15:50, Colin Ian King wrote:
> The variable identical is being initialized with a value that is never
> read. The variable is being re-assigned later on. The initialization is
> redundant and can be removed.
>
> Cleans up clang scan-build warning:
> drivers/video/fbdev/udlfb.c:373:6: warning: Value stored to 'identical'
> during its initialization is never read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

applied.

Thanks!
Helge

> ---
>   drivers/video/fbdev/udlfb.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/udlfb.c b/drivers/video/fbdev/udlfb.c
> index c863244ef12c..216d49c9d47e 100644
> --- a/drivers/video/fbdev/udlfb.c
> +++ b/drivers/video/fbdev/udlfb.c
> @@ -370,7 +370,7 @@ static int dlfb_trim_hline(const u8 *bback, const u8=
 **bfront, int *width_bytes)
>   	const unsigned long *back =3D (const unsigned long *) bback;
>   	const unsigned long *front =3D (const unsigned long *) *bfront;
>   	const int width =3D *width_bytes / sizeof(unsigned long);
> -	int identical =3D width;
> +	int identical;
>   	int start =3D width;
>   	int end =3D width;
>