Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d11a981a-1974-3092-5c81-e1f8c998c440@gmx.de>
Date:   Sun, 25 Sep 2022 13:09:55 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH] video: fbdev: arkfb: Remove the unused function
 dac_read_reg()
Content-Language: en-US
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc:     linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, Abaci Robot <abaci@linux.alibaba.com>
References: <20220914102301.87981-1-jiapeng.chong@linux.alibaba.com>
 <20220914102301.87981-3-jiapeng.chong@linux.alibaba.com>
From:   Helge Deller <deller@gmx.de>
In-Reply-To: <20220914102301.87981-3-jiapeng.chong@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 9/14/22 12:23, Jiapeng Chong wrote:
> The function dac_read_reg() is defined in the arkfb.c file, but not
> called elsewhere, so delete this unused function.
>
> drivers/video/fbdev/arkfb.c:322:18: warning: unused function 'dac_read_r=
eg'.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3D2155
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

applied.

Thanks,
Helge

> ---
>   drivers/video/fbdev/arkfb.c | 8 --------
>   1 file changed, 8 deletions(-)
>
> diff --git a/drivers/video/fbdev/arkfb.c b/drivers/video/fbdev/arkfb.c
> index a317d9fe1d67..5f8fec9e5fd4 100644
> --- a/drivers/video/fbdev/arkfb.c
> +++ b/drivers/video/fbdev/arkfb.c
> @@ -318,14 +318,6 @@ struct dac_info
>   	void *data;
>   };
>
> -
> -static inline u8 dac_read_reg(struct dac_info *info, u8 reg)
> -{
> -	u8 code[2] =3D {reg, 0};
> -	info->dac_read_regs(info->data, code, 1);
> -	return code[1];
> -}
> -
>   static inline void dac_read_regs(struct dac_info *info, u8 *code, int =
count)
>   {
>   	info->dac_read_regs(info->data, code, count);