Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <abde96de-193c-fa78-53c6-e65629b419e9@gmx.de>
Date:   Sun, 25 Sep 2022 13:11:22 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH] video: fbdev: controlfb: Remove the unused function
 VAR_MATCH()
Content-Language: en-US
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc:     linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, Abaci Robot <abaci@linux.alibaba.com>
References: <20220914102301.87981-1-jiapeng.chong@linux.alibaba.com>
From:   Helge Deller <deller@gmx.de>
In-Reply-To: <20220914102301.87981-1-jiapeng.chong@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 9/14/22 12:22, Jiapeng Chong wrote:
> The function VAR_MATCH is defined in the controlfb.c file, but not
> called elsewhere, so delete this unused function.
>
> drivers/video/fbdev/controlfb.c:111:19: warning: unused function 'VAR_MA=
TCH'.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3D2153
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

applied.

Thanks,
Helge


> ---
>   drivers/video/fbdev/controlfb.c | 7 -------
>   1 file changed, 7 deletions(-)
>
> diff --git a/drivers/video/fbdev/controlfb.c b/drivers/video/fbdev/contr=
olfb.c
> index aba46118b208..6bbcd9fc864e 100644
> --- a/drivers/video/fbdev/controlfb.c
> +++ b/drivers/video/fbdev/controlfb.c
> @@ -108,13 +108,6 @@ static inline int PAR_EQUAL(struct fb_par_control *=
x, struct fb_par_control *y)
>   	return (!DIRTY(cmode) && !DIRTY(xres) && !DIRTY(yres)
>   		&& !DIRTY(vxres) && !DIRTY(vyres));
>   }
> -static inline int VAR_MATCH(struct fb_var_screeninfo *x, struct fb_var_=
screeninfo *y)
> -{
> -	return (!DIRTY(bits_per_pixel) && !DIRTY(xres)
> -		&& !DIRTY(yres) && !DIRTY(xres_virtual)
> -		&& !DIRTY(yres_virtual)
> -		&& !DIRTY_CMAP(red) && !DIRTY_CMAP(green) && !DIRTY_CMAP(blue));
> -}
>
>   struct fb_info_control {
>   	struct fb_info		info;