Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ce61fb9a-dcf4-27a2-ac03-62060a1512f9@manjaro.org>
Date:   Sun, 25 Sep 2022 14:39:54 +0200
MIME-Version: 1.0
Subject: Re: [PATCH] arm64: dts: rockchip: fix quartz64-a bluetooth
 configuration
To:     Lev Popov <leo@nabam.net>, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Heiko Stuebner <heiko@sntech.de>
Cc:     Peter Geis <pgwipeout@gmail.com>,
        Nicolas Frattaroli <frattaroli.nicolas@gmail.com>,
        Michael Riesch <michael.riesch@wolfvision.net>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20220925123144.70639-1-leo@nabam.net>
Content-Language: da-DK
From:   Dan Johansen <strit@manjaro.org>
Organization: Manjaro ARM
In-Reply-To: <20220925123144.70639-1-leo@nabam.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


Den 25.09.2022 kl. 14.31 skrev Lev Popov:
> For "Quartz64 Model A" add missing RTS line to the UART interface used by
> bluetooth and swap bluetooth host-wakeup and device-wakeup gpio pins to
> match the boards physical layout. This changes are necessary to make
> bluetooth provided by the wireless module work.
You should add
Fixes:  cd414d5ac1fdeecf0617737e688a1af00858253a (arm64: dts: rockchip: 
rename Quartz64-A bluetooth gpios)
I think, as that was the last commit that touched the gpio lines.
> Signed-off-by: Lev Popov <leo@nabam.net>
> ---
>   arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts
> index a05460b92415..91908081c5ed 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts
> @@ -740,7 +740,7 @@ &uart0 {
>   
>   &uart1 {
>   	pinctrl-names = "default";
> -	pinctrl-0 = <&uart1m0_xfer &uart1m0_ctsn>;
> +	pinctrl-0 = <&uart1m0_xfer &uart1m0_ctsn &uart1m0_rtsn>;
>   	status = "okay";
>   	uart-has-rtscts;
>   
> @@ -748,8 +748,8 @@ bluetooth {
>   		compatible = "brcm,bcm43438-bt";
>   		clocks = <&rk817 1>;
>   		clock-names = "lpo";
> -		device-wakeup-gpios = <&gpio2 RK_PC1 GPIO_ACTIVE_HIGH>;
> -		host-wakeup-gpios = <&gpio2 RK_PC0 GPIO_ACTIVE_HIGH>;
> +		host-wakeup-gpios = <&gpio2 RK_PC1 GPIO_ACTIVE_HIGH>;
> +		device-wakeup-gpios = <&gpio2 RK_PC0 GPIO_ACTIVE_HIGH>;
>   		shutdown-gpios = <&gpio2 RK_PB7 GPIO_ACTIVE_HIGH>;
>   		pinctrl-names = "default";
>   		pinctrl-0 = <&bt_host_wake_l &bt_wake_l &bt_enable_h>;
-- 
Kind regards
*Dan Johansen*
Project lead of the *Manjaro ARM* project
Manjaro-ARM <https://manjaro.org>