Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
To:     Kees Cook <keescook@chromium.org>
Cc:     "James E.J. Bottomley" <jejb@linux.ibm.com>,
        Sachin Sant <sachinp@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-hardening@vger.kernel.org
Subject: Re: [PATCH] scsi: scsi_transport_fc: Adjust struct fc_nl_event flex
 array usage
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1bkr3s8ev.fsf@ca-mkp.ca.oracle.com>
References: <20220921205155.1451649-1-keescook@chromium.org>
Date:   Sun, 25 Sep 2022 12:53:13 -0400
In-Reply-To: <20220921205155.1451649-1-keescook@chromium.org> (Kees Cook's
        message of "Wed, 21 Sep 2022 13:51:55 -0700")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8QrEyzPqTEW/PM6vMup9fcL6tobCrZkBue4NQtyQ7w5vArPNRMrEhwXmS9hR?=
 =?us-ascii?Q?sQp4zSECoD5wYDMRMdG7o+H0QRzDmAAaLmTWFfA0eKRY1rSahjN+EHg+4aaD?=
 =?us-ascii?Q?3bmLWTKmunGlccjJIRMInrbiYMcLi+NNB+YZrUSP1lr7Il3uYw1uuKlXO1Rc?=
 =?us-ascii?Q?GlZVNuPtNBpLw6VORQXe7fSmsHwryQy9rMMev1THPQq/d/WoY2cIkGSQ6bpp?=
 =?us-ascii?Q?W+s5bAuJ6n3d10u2KSvEmEZItU5UFVW+aygc2LnKki9HF0/TxYhbTq0VpMyz?=
 =?us-ascii?Q?nAxfy4hAr8lQEL1xB3ZqHoxX4JiV/KkANiNr21x5y99oWH+5lW2vOIPNI271?=
 =?us-ascii?Q?ZZLvBaRjyhgEAyTKXrqWfyHk9+DPy25tno3yhVxJ4grvXPzrLklqfgkl7OEc?=
 =?us-ascii?Q?UX/Lga3SLrP8vjo8iq4SMBXAKduSj53vS6fOU+LMhfEXb4BW07KTKE+aabFJ?=
 =?us-ascii?Q?nBZj5+jFngsE6VkQkrKwNb5jtgCyNLL6PLlp9ELpBKnY/SmztQc01hQ/+Od/?=
 =?us-ascii?Q?2laiuof/T06SUDru70DyDu41wJkce+Bbd/vjt1DCYB1C7XLkI22tNkZ/wMfu?=
 =?us-ascii?Q?z9Os1KNsx9QpJ1ceytomxxfs5zcjo84CAWyzzXP/4KggYRdiehXZRtkYElUr?=
 =?us-ascii?Q?MIsLUpgsXj0SPQFwZTwPfrE361QcLST3t/0zqg3fgqRy6yAGSqRXI29kHDmz?=
 =?us-ascii?Q?EGyuip3+wnZHDj8PPIONHhe2JHQcSr5A6+m09oi2E9O2pNSzLwYQ54QdDJRU?=
 =?us-ascii?Q?uYdQviATeoiNDO3PotjsenCcxRyqxOa6nZR6lndBQ6DiclD1lYtUZUbqFM78?=
 =?us-ascii?Q?whG1G/xDAHtEsKcG2NjYKH5Qg8sUTO1uiFQvGp84JgKyLR7bu0+Wiwd/GtyW?=
 =?us-ascii?Q?Ku/OD+w0pOXx6hVLgL53sheWSnrVbkWh63hAAhwbidoXFmyU2o9sQEh7Ixpv?=
 =?us-ascii?Q?rVbXcxNrARaH+KPI6FWf3Pwaq1Z7pjprddGNQRe+5ZnEypHyJRw4F1uHeaQt?=
 =?us-ascii?Q?OdrIZqwUaViDrvCSdgkompxppi3P6HV0yphG1rIndxyZ+L/ysMxkThJqmdnA?=
 =?us-ascii?Q?Lsas4f9I/IavSPXCSPlo2QbyDhyIFObHkKjQR+aHA+QWbbBh91Oj1x7Nnnxc?=
 =?us-ascii?Q?ipheBTljtEtB12TnDyVqaflBrgeQsdRB0WxLdTExLxDRFmdcthxMPxENxM0n?=
 =?us-ascii?Q?AkmJMGIWle+cjDeDf7YhtSnI5DnsM6/omF+AQb+InqAl6aN3GvDtFas5VsRn?=
 =?us-ascii?Q?ZCCT8XL6L14V6qcpmS3O/SpoPgNnikSUs/Y210DOaQJfFvB0kP74mH7LyxUd?=
 =?us-ascii?Q?tcZ7wNagylwoN39+tERd9X7gZsJFAMKCvgYDT4nLV3aBKQG00JTqaz23UHTh?=
 =?us-ascii?Q?QpSndR1Cna0YYdUuC+5Xhg1dAlpDrQAstapmqQiV3ub+/mPphBmDjinUQh/4?=
 =?us-ascii?Q?+oeXP+p7wLg0cSm/GdEJU7MBexDtKtwLRgpsoo2LkLU1Qtuli9n4NYGfjFdQ?=
 =?us-ascii?Q?qwhYGF3ynG1ri390SS9VloPQgZfGm8OMMEHDCuBJYZlUOGl89eSU60d2A1X+?=
 =?us-ascii?Q?NSlgjWnF8Jmz1bK18DE2S1YRK96IXOsl5+UCnmJ2HnkBSwQtdOZRDZC2X2Nx?=
 =?us-ascii?Q?sw=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6885126a-2dd1-4b2b-84af-08da9f1670bb
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Sep 2022 16:53:15.8605
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HEKQuySPftPZZY/W146kdMXBznQok6Z6dWNeLUmkjBmGQPjEdQz7Wlu1ia+aVkNOIzwuBKUAfZLtDb0OnhjXVac6rgD2joj3FJY2GkWek1c=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4413
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-09-25_01,2022-09-22_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 malwarescore=0
 suspectscore=0 adultscore=0 mlxscore=0 spamscore=0 bulkscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2209250123
X-Proofpoint-ORIG-GUID: l9QB3zgQdcbOTjPsZwnbZC0bcj7iJTsc
X-Proofpoint-GUID: l9QB3zgQdcbOTjPsZwnbZC0bcj7iJTsc
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Kees,

> In order to help the compiler reason about the destination buffer in
> struct fc_nl_event, add a flexible array member for this purpose.
> However, since the header is UAPI, it must not change size or layout,
> so a union is used.

Applied to 6.1/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering