Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c5addc04-f29a-1366-6513-7d3bbc306e3b@gmail.com>
Date:   Mon, 26 Sep 2022 04:01:33 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] PM / devfreq: rockchip-dfi: Fix an error message
Content-Language: en-US
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        Chanwoo Choi <cw00.choi@samsung.com>,
        MyungJoo Ham <myungjoo.ham@samsung.com>,
        Kyungmin Park <kyungmin.park@samsung.com>,
        Heiko Stuebner <heiko@sntech.de>
Cc:     linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
        linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-rockchip@lists.infradead.org
References: <47627a29a443aedf3b36a4f72b3e1ad89933a0ea.1662819332.git.christophe.jaillet@wanadoo.fr>
From:   Chanwoo Choi <cwchoi00@gmail.com>
In-Reply-To: <47627a29a443aedf3b36a4f72b3e1ad89933a0ea.1662819332.git.christophe.jaillet@wanadoo.fr>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Christophe,

On 22. 9. 10. 23:15, Christophe JAILLET wrote:
> There is a typo in the message. The clock name should be 'pclk_ddr_mon'.
> Fix it.
> 
> While at it, switch to dev_err_probe() which is less verbose, filters
> -EPROBE_DEFER, and log the error code in a human readable way.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> This looks like a cut'n'paste typo from drivers/devfreq/rk3399_dmc.c
> ---
>  drivers/devfreq/event/rockchip-dfi.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/devfreq/event/rockchip-dfi.c b/drivers/devfreq/event/rockchip-dfi.c
> index 9a88faaf8b27..39ac069cabc7 100644
> --- a/drivers/devfreq/event/rockchip-dfi.c
> +++ b/drivers/devfreq/event/rockchip-dfi.c
> @@ -189,10 +189,9 @@ static int rockchip_dfi_probe(struct platform_device *pdev)
>  		return PTR_ERR(data->regs);
>  
>  	data->clk = devm_clk_get(dev, "pclk_ddr_mon");
> -	if (IS_ERR(data->clk)) {
> -		dev_err(dev, "Cannot get the clk dmc_clk\n");
> -		return PTR_ERR(data->clk);
> -	}
> +	if (IS_ERR(data->clk))
> +		return dev_err_probe(dev, PTR_ERR(data->clk),
> +				     "Cannot get the clk pclk_ddr_mon\n");
>  
>  	/* try to find the optional reference to the pmu syscon */
>  	node = of_parse_phandle(np, "rockchip,pmu", 0);

Applied it. Thanks.

-- 
Best Regards,
Samsung Electronics
Chanwoo Choi