Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Colin Foster <colin.foster@in-advantage.com>
To:     linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, netdev@vger.kernel.org
Cc:     Russell King <linux@armlinux.org.uk>,
        Linus Walleij <linus.walleij@linaro.org>,
        UNGLinuxDriver@microchip.com,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Lee Jones <lee@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Vladimir Oltean <olteanv@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>
Subject: [PATCH v3 net-next 07/14] net: dsa: felix: populate mac_capabilities for all ports
Date:   Sun, 25 Sep 2022 17:29:21 -0700
Message-Id: <20220926002928.2744638-8-colin.foster@in-advantage.com>
In-Reply-To: <20220926002928.2744638-1-colin.foster@in-advantage.com>
References: <20220926002928.2744638-1-colin.foster@in-advantage.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?zoSy74fbDoHoP0/C0z6iSi1DA6aYyWFHYRk6R1XpbVXknPZ+Qjq5FSmAywzo?=
 =?us-ascii?Q?Why+C5odAIuzY0DdS/HDKjw4Qz2J8t4haIsevbQxil9k69InDti8XHG4ZJ7C?=
 =?us-ascii?Q?KuRYNYwUw4vJfNp0SgUj4/SaGHmn4m8KwqRanN0Ry2eT4wILDDbqB1blqzOB?=
 =?us-ascii?Q?WcTwM0P0DKxJGrqIujqjkCIyNv91VJn9UoofDqTZVClsLEcHbWNJwM5ttqy2?=
 =?us-ascii?Q?JsqRz7YH4Cvuh/yRiLrCPef7nPwDS6KExyPlzc9RrQSWRwcGAcBMIhztRF/U?=
 =?us-ascii?Q?wbjCgNq2rkDbb7fukLLfUAyWwIQ4KnsiGr0ldUOKr/IQDm5ZurJB0wYkFw5j?=
 =?us-ascii?Q?N2ECKU+vxwXvuVSKERA3v2qCHLpT9rTLsokO3qEnPsMmI/LZ4e5T10PV7sbY?=
 =?us-ascii?Q?y+O+L0ZFoiIojR8E9DxMWC0u0UnR8QwVSGa2i+cgYFYgZsTNT42LIpG7J7Zg?=
 =?us-ascii?Q?qbCjs366S8iSonH+SiYOhTitFhDlxKhnUHg3aTc9Qp9N4PXeknsLxX2XKj96?=
 =?us-ascii?Q?/c6oQXEPJTW1MH/XtGltm94d3Ayb6saT3xeB2sZs3X2eY7oLbLsDaeObYfo5?=
 =?us-ascii?Q?qV3yALLcAPfTqxH4WqlxyhQ6JMqbntoHF5CLedaf+qoWRSKlmuZC8MmvRT0y?=
 =?us-ascii?Q?9/cheUL6boxl0RH8fM2W34gonjeZ1L3vsoOA8XYpaJYqGh0ZGENtxmN8PXGu?=
 =?us-ascii?Q?jUkrsEKZuJghtm+7XdwF+5MegJbuAG7X2pZlSlY1Rlr04774kF5Nx+XNZ/rj?=
 =?us-ascii?Q?OGOEwXZpdwtPyHoYL5VSl+3T5W/akrfuohE91H0WUpq1S10qucxZbhHuV+NC?=
 =?us-ascii?Q?DDsWoPKFVfFom1S2ERqpEUsEqiWugOmGSCvBwclzrDQXxjhRXdctmP8Kiqnd?=
 =?us-ascii?Q?7PU/CSqSQw0AfMAXNnowci8bGTz5GNVk9kc/i7SbohgQTfyXBJ4XwzaFnT+7?=
 =?us-ascii?Q?AJu/Lyr1NZF5ObcGdD5uVYOf47gv3TXasQ9kZAvjZS2a6uIjj6zfdzW8wEAd?=
 =?us-ascii?Q?cc5xpABaMeKLXuVNUBbesjGWBUEz6niBVJBTHdA3nXYhZDXANjax57l43jHA?=
 =?us-ascii?Q?rPDyYvIqnSj4wz4PahdMQzZx5rJcvy3CxRkipwtr0JqYnTcl0EyBKejyb1/N?=
 =?us-ascii?Q?km3xkI4UhKaelrEbH+hMxaAvUPGdMjn+cXKxmIKi3RP+ABSIEDh7OYRtsgcw?=
 =?us-ascii?Q?lHFfWJaZiTQSoMwxYfKHdrAtmyhxZ396L7l5Ew6b1XUe0BpHSMqPBSjwZMaf?=
 =?us-ascii?Q?4QTFZ/BJcRzWapq2RxcXXgk/1Tbh4SwK1SDK9l8ekNB/h4hcVbxz45gCO5Nk?=
 =?us-ascii?Q?2f4+VMc4Jt9A1PsbJoNNZlHGPwupd2V59iP+LDHK8lRXMOO31dUoYi7zqklc?=
 =?us-ascii?Q?m3H3v/RvsMUp73hfroQIUKrXol51JObVMhaLSp179t86GYQLQRMO/VMqRyn3?=
 =?us-ascii?Q?J61JOc6AH7k2JhNltoCccqjFIzkg6/eyZl0TtamRLn/IpeHxYlMkCh2mrFrB?=
 =?us-ascii?Q?efJEMCjp1IySg3VTwNSJ1xCg+VqG11v/mHBHzR1UeH4wySyG3rvkznG+1/0g?=
 =?us-ascii?Q?fC4vbbBvT5Q73IbtXFTXbr6JskFBQLC7icymZUNV6/B6y2Hay1Qz7XzqsX+m?=
 =?us-ascii?Q?xw=3D=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5d2a36fe-b75d-400b-e7e8-08da9f564c72
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 00:30:22.6980
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FysgqR6xYrYbGrYV+1j/DE6fC52B4DTnTqTQa/UclnWmF/tTqxl6uen0Mybohl6GwAtd8n1lfqvD5HjPi73+pqrWk1jNII9PSTCKF1XOzb8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB4849
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

phylink_generic_validate() requires that mac_capabilities is correctly
populated. While no existing felix drivers have used
phylink_generic_validate(), the ocelot_ext.c driver will. Populate this
element so the use of existing functions is possible.

Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
---

v3
    * No change

v2
    * Updated commit message to indicate "no existing felix drivers"
      instead of "no existing drivers"

v1 from previous RFC:
    * New patch

---
 drivers/net/dsa/ocelot/felix.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/dsa/ocelot/felix.c b/drivers/net/dsa/ocelot/felix.c
index 07c2f1b6913d..a8196cdedcc5 100644
--- a/drivers/net/dsa/ocelot/felix.c
+++ b/drivers/net/dsa/ocelot/felix.c
@@ -1050,6 +1050,9 @@ static void felix_phylink_get_caps(struct dsa_switch *ds, int port,
 
 	__set_bit(ocelot->ports[port]->phy_mode,
 		  config->supported_interfaces);
+
+	config->mac_capabilities = MAC_SYM_PAUSE | MAC_ASYM_PAUSE | MAC_10 |
+				   MAC_100 | MAC_1000FD | MAC_2500FD;
 }
 
 static void felix_phylink_validate(struct dsa_switch *ds, int port,
-- 
2.25.1