Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 26 Sep 2022 04:35:20 +0200
From:   =?utf-8?Q?Micha=C5=82?= Winiarski <michal.winiarski@intel.com>
To:     =?utf-8?B?TWHDrXJh?= Canal <mcanal@igalia.com>
CC:     David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
        "Melissa Wen" <mwen@igalia.com>,
        =?utf-8?B?QW5kcsOp?= Almeida <andrealmeid@igalia.com>,
        Javier Martinez Canillas <javierm@redhat.com>,
        Daniel Latypov <dlatypov@google.com>,
        David Gow <davidgow@google.com>,
        Arthur Grillo <arthur.grillo@usp.br>,
        Isabella Basso <isabbasso@riseup.net>,
        <magalilemes00@gmail.com>, <tales.aparecida@gmail.com>,
        <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] drm/tests: Split
 drm_test_dp_mst_sideband_msg_req_decode into parameterized tests
Message-ID: <20220926023520.7pwxotmzsa5pjeqz@nostramo>
References: <20220925222719.345424-1-mcanal@igalia.com>
 <20220925222719.345424-2-mcanal@igalia.com>
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220925222719.345424-2-mcanal@igalia.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MmNhV242a1ZCeU8rYWRpOUpzKzhkNlljaUZSUkkwL0t3ZG1JK0ZkUHgzSkd0?=
 =?utf-8?B?ZW1pSlJCOVRnaHBBK0dJcTduZTIrR1ByckJjZFZzSXVnSVZDQnNDQkFkYWRq?=
 =?utf-8?B?b2htOVdGMWc5aHFXeTlaeDYwa2ROZWpTUnFMOU9URTR4a21kK3pIYWFzTVlj?=
 =?utf-8?B?RWRHa3U5bkZOcW54ZVVpbTQ4b2NxK01RWG13aXJvcVBXT0Z5c2dRbktZQUpL?=
 =?utf-8?B?MUc2d2FDdXhQU21UMGZyZFg3dHZsL0NWUXJIdFVJZUJuOWc3Nm5VdVQ1c2M1?=
 =?utf-8?B?SEFySFlnWUYrem1jaThUekplRVArcVk2aDI3bXhSdytMNzJMQXZiU3h1NzNr?=
 =?utf-8?B?TmdiUTNnNGZMV2RFaEU0OGlwNXVkeVMvZytuKzVRT21ranFIQ0srd1YzcXIy?=
 =?utf-8?B?YjExa3BqN0R4eTJtMHdaUU9BaVZFNFNGdEsrS1E4QnRVV0Y1ZDlmSWVzeTBj?=
 =?utf-8?B?czZnSjVodTdacVVBRDhsVEdFRWpFMTVVWVJ2em9TNlRScENRclhNcDJRdDVF?=
 =?utf-8?B?OXNpeVljQnk4WTJTOFRMd1dQam5PdHJqYm5hL0ZENnNRSkUwMGFRTUFnTUpy?=
 =?utf-8?B?YlpRZ2xJK1FkUCsvT2k5djJYSG80YVpha3RZWStsTkJ3TGRnRURBMFR3TDFv?=
 =?utf-8?B?TGEvMUhadEJsQmxkNVZtQTRoRU5iSFVlaWU0R2krd3FJbjh1d0xwalk3azhG?=
 =?utf-8?B?RjRSejJTeXJUQ0dhdnRUR3N3bVRGRnhONlE4aDQxY0t1NlhkeUdIdmhydG1M?=
 =?utf-8?B?dDE0M2YrUnZ1MEl1QWwyQ0IwcVpGRnBPQmNaL2lFRjhJR2FOc0JlclRqQXlm?=
 =?utf-8?B?ZW1YQmltcUpLdk5YTkdqZ0xIZTFjc0JWQUFmblBNRENhQVBHVy9yN1l6M3pt?=
 =?utf-8?B?UDBjditNMjBjSXVpelNyRVhVZjlHV1EyeXR6elFQZ2w5cmZSM2FUTy9Ld3pv?=
 =?utf-8?B?Mnh4TDFFYytHd2ZkWVBid3V2aTNCbzlhMEVwVUo4SFliZ2Fta2VEaHFPSmsx?=
 =?utf-8?B?ek1YQlA1Y2ZRZG9tZjMxRUUyTmdUdUFaLzIrcHh1ZE1TUnU5dXRydytHTmFX?=
 =?utf-8?B?U3pkNnRkWVlZY0h4WDlkS0E0azZNdnZSb0NxVm1USlVLQ0xVWXRsQytYSllI?=
 =?utf-8?B?TytkbEU4TG9wOE9Nc1lVUVNpN3RUU0FaK05WNXNyaktiZ1BBNUVCWEEwRHI3?=
 =?utf-8?B?L25oeTgyaHZGVG5VUmdtK0twYy8vWCtjN2UyeGloWXc5eWdabHVoY2I4bTZk?=
 =?utf-8?B?d0FMdzZiVWZMUUg5ZklIelVuZlBnMHJlS2M3QjkxMjA4a015YlU2NElsdUhP?=
 =?utf-8?B?SHdHMVlTalFOVUtSSDhDV0JVaWIxamxleUxKR1l0L2dpRmtFaTVTUmVZa0li?=
 =?utf-8?B?S3ZkWEJTaklpajIxSXJKcm9YbnlMTjFuWHNneXFTeGN5aGFVNXlYcnlQTGMr?=
 =?utf-8?B?ckNhT0pTOFVSN0VidTdMUkJYSmh4UE4vY2JmaURuK0VwTHJHN2F5ZnhlUmlL?=
 =?utf-8?B?MlcxSndPcTJyamhLT0xoRjFGcEdBVXJnN0ZiUGU1dlp6UHlCZy9laW9PZTdx?=
 =?utf-8?B?RFlHVVlvK3oyczFtZVVvTEI5WXBadGtnblZZb3dkd09ubFRwTlMxeGtpR2RV?=
 =?utf-8?B?S2c1bCs5c0R1bnlaSU1zZENyc3BlQ0ZxN2pReTFCdHpBMHdzR3IrZ2Vla0p0?=
 =?utf-8?B?TXcxMGlkWEJOUmxUUnRzd1ZGVVZ3T1BsNUYrOWRFNDd0d1hLeStxRUZDVExm?=
 =?utf-8?B?MmdGQXZ3WDR4R2d3WjFSYTRpS1ZFR2pZNnIzRm03UGJWSnlSMzVZa2dkRXdz?=
 =?utf-8?B?MURCLzY5V0NacnI1Q2pWZnY1MnludmxabHV6RFhNQm52OGpoZzIrbERGb0kw?=
 =?utf-8?B?a3JoTFdNRUdhTWdES3h1eWtRbUNSSnFzdTRwaFdWQWRCTGRZbVJrYkYyNCti?=
 =?utf-8?B?NzN6VXM1VWlLZDJld3ZVcG5qd2pSdG1ocHNCMm9aSHFVc3lzT3lPeU1FUDIw?=
 =?utf-8?B?TlFKaXpDcDRGejg5QzUxN0VDdDN4YTVNUEJ4NG5qK0ZTS3oxZmgzS0hSVCtI?=
 =?utf-8?B?NlovMW9xc2NnbDlDV2pJTzZFUm0vaG9BMUJwTkxaRWZSYkQ2SGtPcm5GU1Vr?=
 =?utf-8?B?WnpjK1hSVi9KRHRsQzRYOTlhSFhQVzU0Rm1aa2k5K2FxT2ltMWFPd2VHUllW?=
 =?utf-8?B?dWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b249ef7f-5ae3-46fb-e8d2-08da9f67c33f
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5373.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 02:35:23.4414
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EG5zBH5uJVyIwCDbk3EipiO2gUcPtD+vUpIZIf6JD2wneNFHgYr23n6F1MC5mnuBHIebSAOCOJ2ZFYcue5ejU5xT86qDozpCduUmVmKLU2o=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4599
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Sep 25, 2022 at 07:27:19PM -0300, Maíra Canal wrote:
> The drm_test_dp_mst_sideband_msg_req_decode repeats the same test
> structure with different parameters. This could be better represented
> by parameterized tests, provided by KUnit.
> 
> So, convert drm_test_dp_mst_sideband_msg_req_decode into parameterized
> tests and make the test's allocations and prints completly managed by KUnit.

There's a small functional change not mentioned in the commit message.

> 
> Signed-off-by: Maíra Canal <mcanal@igalia.com>
> ---
>  .../gpu/drm/tests/drm_dp_mst_helper_test.c    | 370 ++++++++++++------
>  1 file changed, 243 insertions(+), 127 deletions(-)
> 
> diff --git a/drivers/gpu/drm/tests/drm_dp_mst_helper_test.c b/drivers/gpu/drm/tests/drm_dp_mst_helper_test.c
> index 12f41881db6b..545beea33e8c 100644
> --- a/drivers/gpu/drm/tests/drm_dp_mst_helper_test.c
> +++ b/drivers/gpu/drm/tests/drm_dp_mst_helper_test.c
> @@ -5,12 +5,8 @@
>   * Copyright (c) 2022 Maíra Canal <mairacanal@riseup.net>
>   */
>  
> -#define PREFIX_STR "[drm_dp_mst_helper]"
> -
>  #include <kunit/test.h>
>  
> -#include <linux/random.h>
> -
>  #include <drm/display/drm_dp_mst_helper.h>
>  #include <drm/drm_print.h>
>  
> @@ -72,6 +68,217 @@ static void dp_mst_calc_pbn_mode_desc(const struct drm_dp_mst_calc_pbn_mode_test
>  KUNIT_ARRAY_PARAM(drm_dp_mst_calc_pbn_mode, drm_dp_mst_calc_pbn_mode_cases,
>  		  dp_mst_calc_pbn_mode_desc);
>  
> +static u8 data[] = { 0xff, 0x00, 0xdd };
> +
> +struct drm_dp_mst_sideband_msg_req_test {
> +	const char *desc;
> +	const struct drm_dp_sideband_msg_req_body in;
> +};
> +
> +static const struct drm_dp_mst_sideband_msg_req_test drm_dp_mst_sideband_msg_req_cases[] = {
> +	{
> +		.desc = "DP_ENUM_PATH_RESOURCES with port number",
> +		.in = {
> +			.req_type = DP_ENUM_PATH_RESOURCES,
> +			.u.port_num.port_number = 5,
> +		},
> +	},
> +	{
> +		.desc = "DP_POWER_UP_PHY with port number",
> +		.in = {
> +			.req_type = DP_POWER_UP_PHY,
> +			.u.port_num.port_number = 5,
> +		},
> +	},
> +	{
> +		.desc = "DP_POWER_DOWN_PHY with port number",
> +		.in = {
> +			.req_type = DP_POWER_DOWN_PHY,
> +			.u.port_num.port_number = 5,
> +		},
> +	},
> +	{
> +		.desc = "DP_ALLOCATE_PAYLOAD with SDP stream sinks",
> +		.in = {
> +			.req_type = DP_ALLOCATE_PAYLOAD,
> +			.u.allocate_payload.number_sdp_streams = 3,
> +			.u.allocate_payload.sdp_stream_sink = { 1, 2, 3 },
> +		},
> +	},
> +	{
> +		.desc = "DP_ALLOCATE_PAYLOAD with port number",
> +		.in = {
> +			.req_type = DP_ALLOCATE_PAYLOAD,
> +			.u.allocate_payload.port_number = 0xf,
> +		},
> +	},
> +	{
> +		.desc = "DP_ALLOCATE_PAYLOAD with VCPI",
> +		.in = {
> +			.req_type = DP_ALLOCATE_PAYLOAD,
> +			.u.allocate_payload.vcpi = 0x7f,
> +		},
> +	},
> +	{
> +		.desc = "DP_ALLOCATE_PAYLOAD with PBN",
> +		.in = {
> +			.req_type = DP_ALLOCATE_PAYLOAD,
> +			.u.allocate_payload.pbn = U16_MAX,
> +		},
> +	},
> +	{
> +		.desc = "DP_QUERY_PAYLOAD with port number",
> +		.in = {
> +			.req_type = DP_QUERY_PAYLOAD,
> +			.u.query_payload.port_number = 0xf,
> +		},
> +	},
> +	{
> +		.desc = "DP_QUERY_PAYLOAD with VCPI",
> +		.in = {
> +			.req_type = DP_QUERY_PAYLOAD,
> +			.u.query_payload.vcpi = 0x7f,
> +		},
> +	},
> +	{
> +		.desc = "DP_REMOTE_DPCD_READ with port number",
> +		.in = {
> +			.req_type = DP_REMOTE_DPCD_READ,
> +			.u.dpcd_read.port_number = 0xf,
> +		},
> +	},
> +	{
> +		.desc = "DP_REMOTE_DPCD_READ with DPCD address",
> +		.in = {
> +			.req_type = DP_REMOTE_DPCD_READ,
> +			.u.dpcd_read.dpcd_address = 0xfedcb,
> +		},
> +	},
> +	{
> +		.desc = "DP_REMOTE_DPCD_READ with max number of bytes",
> +		.in = {
> +			.req_type = DP_REMOTE_DPCD_READ,
> +			.u.dpcd_read.num_bytes = U8_MAX,
> +		},
> +	},
> +	{
> +		.desc = "DP_REMOTE_DPCD_WRITE with port number",
> +		.in = {
> +			.req_type = DP_REMOTE_DPCD_WRITE,
> +			.u.dpcd_write.port_number = 0xf,
> +		},
> +	},
> +	{
> +		.desc = "DP_REMOTE_DPCD_WRITE with DPCD address",
> +		.in = {
> +			.req_type = DP_REMOTE_DPCD_WRITE,
> +			.u.dpcd_write.dpcd_address = 0xfedcb,
> +		},
> +	},
> +	{
> +		.desc = "DP_REMOTE_DPCD_WRITE with data array",
> +		.in = {
> +			.req_type = DP_REMOTE_DPCD_WRITE,
> +			.u.dpcd_write.num_bytes = ARRAY_SIZE(data),
> +			.u.dpcd_write.bytes = data,
> +		},
> +	},
> +	{
> +		.desc = "DP_REMOTE_I2C_READ with port number",
> +		.in = {
> +			.req_type = DP_REMOTE_I2C_READ,
> +			.u.i2c_read.port_number = 0xf,
> +		},
> +	},
> +	{
> +		.desc = "DP_REMOTE_I2C_READ with I2C device ID",
> +		.in = {
> +			.req_type = DP_REMOTE_I2C_READ,
> +			.u.i2c_read.read_i2c_device_id = 0x7f,
> +		},
> +	},
> +	{
> +		.desc = "DP_REMOTE_I2C_READ with transactions array",
> +		.in = {
> +			.req_type = DP_REMOTE_I2C_READ,
> +			.u.i2c_read.num_transactions = 3,
> +			.u.i2c_read.num_bytes_read = ARRAY_SIZE(data) * 3,
> +			.u.i2c_read.transactions = {
> +				{ .bytes = data, .num_bytes = ARRAY_SIZE(data), .i2c_dev_id = 0x7f,
> +				  .i2c_transaction_delay = 0xf, },
> +				{ .bytes = data, .num_bytes = ARRAY_SIZE(data), .i2c_dev_id = 0x7e,
> +				  .i2c_transaction_delay = 0xe, },
> +				{ .bytes = data, .num_bytes = ARRAY_SIZE(data), .i2c_dev_id = 0x7d,
> +				  .i2c_transaction_delay = 0xd, },
> +			},
> +		},
> +	},
> +	{
> +		.desc = "DP_REMOTE_I2C_WRITE with port number",
> +		.in = {
> +			.req_type = DP_REMOTE_I2C_WRITE,
> +			.u.i2c_write.port_number = 0xf,
> +		},
> +	},
> +	{
> +		.desc = "DP_REMOTE_I2C_WRITE with I2C device ID",
> +		.in = {
> +			.req_type = DP_REMOTE_I2C_WRITE,
> +			.u.i2c_write.write_i2c_device_id = 0x7f,
> +		},
> +	},
> +	{
> +		.desc = "DP_REMOTE_I2C_WRITE with data array",
> +		.in = {
> +			.req_type = DP_REMOTE_I2C_WRITE,
> +			.u.i2c_write.num_bytes = ARRAY_SIZE(data),
> +			.u.i2c_write.bytes = data,
> +		},
> +	},
> +	{
> +		.desc = "DP_QUERY_STREAM_ENC_STATUS with stream ID",
> +		.in = {
> +			.req_type = DP_QUERY_STREAM_ENC_STATUS,
> +			.u.enc_status.stream_id = 1,
> +		},
> +	},
> +	{
> +		.desc = "DP_QUERY_STREAM_ENC_STATUS with client ID",
> +		.in = {
> +			.req_type = DP_QUERY_STREAM_ENC_STATUS,
> +			.u.enc_status.client_id = { 0x4f, 0x7f, 0xb4, 0x00, 0x8c, 0x0d, 0x67 },

Before the conversion - client_id used to be random (different for every run of
the test).
Even if it doesn't matter from test perspective, please mention that in the
commit message.

-Michał