Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220916124112.1175522-1-scgl@linux.ibm.com>
In-Reply-To: <20220916124112.1175522-1-scgl@linux.ibm.com>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Mon, 26 Sep 2022 11:46:52 +0900
Message-ID: <CAK7LNAQQmcz96rxpUmnctZidOTTvcSo51Z=iBme_Q9bvA5Fasw@mail.gmail.com>
Subject: Re: [RFC PATCH] kbuild: rpm-pkg: fix breakage when V=1 is used
To:     Janis Schoetterl-Glausch <scgl@linux.ibm.com>
Cc:     Michal Marek <michal.lkml@markovi.net>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Sep 16, 2022 at 9:41 PM Janis Schoetterl-Glausch
<scgl@linux.ibm.com> wrote:
>
> Doing make V=3D1 binrpm-pkg results in:
>
>  Executing(%install): /bin/sh -e /var/tmp/rpm-tmp.EgV6qJ
>  + umask 022
>  + cd .
>  + /bin/rm -rf /home/scgl/rpmbuild/BUILDROOT/kernel-6.0.0_rc5+-1.s390x
>  + /bin/mkdir -p /home/scgl/rpmbuild/BUILDROOT
>  + /bin/mkdir /home/scgl/rpmbuild/BUILDROOT/kernel-6.0.0_rc5+-1.s390x
>  + mkdir -p /home/scgl/rpmbuild/BUILDROOT/kernel-6.0.0_rc5+-1.s390x/boot
>  + make -f ./Makefile image_name
>  + cp test -e include/generated/autoconf.h -a -e include/config/auto.conf=
 || ( \ echo >&2; \ echo >&2 " ERROR: Kernel configuration is invalid."; \ =
echo >&2 " include/generated/autoconf.h or include/config/auto.conf are mis=
sing.";\ echo >&2 " Run 'make oldconfig && make prepare' on kernel src to f=
ix it."; \ echo >&2 ; \ /bin/false) arch/s390/boot/bzImage /home/scgl/rpmbu=
ild/BUILDROOT/kernel-6.0.0_rc5+-1.s390x/boot/vmlinuz-6.0.0-rc5+
>  cp: invalid option -- 'e'
>  Try 'cp --help' for more information.
>  error: Bad exit status from /var/tmp/rpm-tmp.EgV6qJ (%install)
>
> Because the make call to get the image name is verbose and prints
> additional information.
>
> Fixes: 21b42eb46834 ("kbuild: rpm-pkg: fix binrpm-pkg breakage when O=3D =
is used")


This Fixes tag is wrong.


I replaced it with:

  Fixes: 993bdde94547 ("kbuild: add image_name to no-sync-config-targets")


Applied to linux-kbuild. Thanks.


> Signed-off-by: Janis Schoetterl-Glausch <scgl@linux.ibm.com>
> ---
>
>
> I don't know much about Kbuild so there may be better ways to fix this.
>
>
>  scripts/package/mkspec | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/package/mkspec b/scripts/package/mkspec
> index 8fa7c5b8a1a1..c920c1b18e7a 100755
> --- a/scripts/package/mkspec
> +++ b/scripts/package/mkspec
> @@ -88,10 +88,10 @@ $S
>         mkdir -p %{buildroot}/boot
>         %ifarch ia64
>         mkdir -p %{buildroot}/boot/efi
> -       cp \$($MAKE image_name) %{buildroot}/boot/efi/vmlinuz-$KERNELRELE=
ASE
> +       cp \$($MAKE -s image_name) %{buildroot}/boot/efi/vmlinuz-$KERNELR=
ELEASE
>         ln -s efi/vmlinuz-$KERNELRELEASE %{buildroot}/boot/
>         %else
> -       cp \$($MAKE image_name) %{buildroot}/boot/vmlinuz-$KERNELRELEASE
> +       cp \$($MAKE -s image_name) %{buildroot}/boot/vmlinuz-$KERNELRELEA=
SE
>         %endif
>  $M     $MAKE %{?_smp_mflags} INSTALL_MOD_PATH=3D%{buildroot} modules_ins=
tall
>         $MAKE %{?_smp_mflags} INSTALL_HDR_PATH=3D%{buildroot}/usr headers=
_install
> --
> 2.34.1
>


--=20
Best Regards
Masahiro Yamada