Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220922091841.4099-1-miles.chen@mediatek.com>
In-Reply-To: <20220922091841.4099-1-miles.chen@mediatek.com>
From:   Chen-Yu Tsai <wenst@chromium.org>
Date:   Mon, 26 Sep 2022 12:45:50 +0800
Message-ID: <CAGXv+5HT4w+y8ntSgBdpYPc4M5=erQNxYOc3-jGFNrZ+HJTA=Q@mail.gmail.com>
Subject: Re: [PATCH v3 0/7] clk: mediatek: use mtk_clk_simple_probe to simplify
To:     Miles Chen <miles.chen@mediatek.com>
Cc:     Stephen Boyd <sboyd@kernel.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        linux-kernel@vger.kernel.org,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        Chun-Jie Chen <chun-jie.chen@mediatek.com>,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Sep 22, 2022 at 5:19 PM Miles Chen <miles.chen@mediatek.com> wrote:
>
> Hi everyone,
>
> This is v3 patches to use mtk_clk_simple_probe to simplify driver. It is almost
> a RESEND patch, the only difference is adding reviewed-by tags and a tested-by tag
> to the commit messages.
>
> I tested the series on MT8192 and MT6779.
> This patch is based on next-20220921 and [1].
>
> Change since v1:
> - Angelo's patch [1] already exported mtk_clk_simple_probe and mtk_clk_simple_remove,
> so drop this part from my v1 and depends on [1].
> - add a reviewed-by tag
>
> Change since v2:
> - add reviewed-by tags and a tested-by tag
>
> mtk_clk_simple_probe() was introduced by Chun-Jie in commit
> c58cd0e40ffa ("clk: mediatek: Add mtk_clk_simple_probe() to simplify clock providers")
> and mtk_clk_simple_remove() was added in commit
> commit 2204d96b1919 ("clk: mediatek: Add mtk_clk_simple_remove()")
>
> With mtk_clk_simple_probe and mtk_clk_simple_remove,
> we can get rid of defining the same probe function in clk drivers.
> mtk_clk_simple_probe and mtk_clk_simple_remove are used in new platforms
> now, let's apply them to old SoCs.
>
> The process is quite straightforward:
> a. Look up probe functions which can be replaced by mtk_clk_simple_probe()
> b. Add mtk_clk_desc and add .data
> c. Replace the probe function with mtk_clk_simple_probe and mtk_clk_simple_remove
>
> Thanks,
> Miles
>
> [1] https://lore.kernel.org/lkml/20220921091455.41327-1-angelogioacchino.delregno@collabora.com/
>
>
>
> Miles Chen (7):
>   clk: mediatek: mt2701: use mtk_clk_simple_probe to simplify driver
>   clk: mediatek: mt2712: use mtk_clk_simple_probe to simplify driver
>   clk: mediatek: mt6765: use mtk_clk_simple_probe to simplify driver
>   clk: mediatek: mt6779: use mtk_clk_simple_probe to simplify driver
>   clk: mediatek: mt6797: use mtk_clk_simple_probe to simplify driver
>   clk: mediatek: mt8183: use mtk_clk_simple_probe to simplify driver
>   clk: mediatek: mt8192: add mtk_clk_simple_remove

I've queued this series up here [1] and will send a pull request to
the clock maintainer later this week.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/wens/linux.git/log/?h=clk-mtk-for-6.1