Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <63c1962b-26a5-0415-9035-580c2842e67b@mediatek.com>
Date:   Mon, 26 Sep 2022 15:23:01 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH] media: mediatek: venc: Add h264 extended profile support
Content-Language: en-US
To:     Matthias Brugger <matthias.bgg@gmail.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Hans Verkuil <hverkuil-cisco@xs4all.nl>
CC:     <Project_Global_Chrome_Upstream_Group@mediatek.com>,
        <devicetree@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-media@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-mediatek@lists.infradead.org>, <hsinyi@chromium.org>,
        kyrie wu <kyrie.wu@mediatek.com>
References: <20220915115135.7271-1-allen-kh.cheng@mediatek.com>
From:   Allen-KH Cheng <allen-kh.cheng@mediatek.com>
In-Reply-To: <20220915115135.7271-1-allen-kh.cheng@mediatek.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk

hello, maintainers

kindly disregard this patch.

The MTK HW encoder does not yet support this. (only sw)

Thanks,
Allen

On 9/15/22 19:51, Allen-KH Cheng wrote:
> Add h264 extended profile support
> 
> Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> Co-developed-by: kyrie wu <kyrie.wu@mediatek.com>
> Signed-off-by: kyrie wu <kyrie.wu@mediatek.com>
> ---
>  drivers/media/platform/mediatek/vcodec/venc/venc_h264_if.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/media/platform/mediatek/vcodec/venc/venc_h264_if.c b/drivers/media/platform/mediatek/vcodec/venc/venc_h264_if.c
> index 13c4f860fa69..ac2ef6275d78 100644
> --- a/drivers/media/platform/mediatek/vcodec/venc/venc_h264_if.c
> +++ b/drivers/media/platform/mediatek/vcodec/venc/venc_h264_if.c
> @@ -243,8 +243,7 @@ static unsigned int h264_get_profile(struct venc_h264_inst *inst,
>  		mtk_vcodec_err(inst, "unsupported CONSTRAINED_BASELINE");
>  		return 0;
>  	case V4L2_MPEG_VIDEO_H264_PROFILE_EXTENDED:
> -		mtk_vcodec_err(inst, "unsupported EXTENDED");
> -		return 0;
> +		return 88;
>  	default:
>  		mtk_vcodec_debug(inst, "unsupported profile %d", profile);
>  		return 100;