Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp466961rwb; Mon, 26 Sep 2022 01:07:54 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7kRkZqcaKKhoHyaR/+0J9A+QKEr+nZFcSBMLcGHy9AISfrOMbTgBr6mo6ePZkUq7/dm4SE X-Received: by 2002:a65:6055:0:b0:42a:7b2b:dc71 with SMTP id a21-20020a656055000000b0042a7b2bdc71mr18689660pgp.23.1664179674500; Mon, 26 Sep 2022 01:07:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664179674; cv=none; d=google.com; s=arc-20160816; b=kG1MiOutBeu4Ia4Z1Z+2ebs67buCXf7Jm8iPOqOInsdy7EMOfECJ40521aPMkIeXYJ ziXB/7M+mffgYHEyxNfuGgJ5bDwYywSOlbd3yN/blzJqzgpqQ7ZsesnWcMF9Q2ICn6XV YYYEPBFghbGt+NzLsskbQc3J5MzMYVZVGZ66mNKWTXv3zq2y+NsTylBuEvoPItaHXK0f E6L4mMrhMzNIR1pmKyWsFjYsxUwnn5+zvdzgRPHIQ+Jl2rXeUx5vso89s7MkyJc5nN0z 2qbtOz+9sAHSYzOkW/AxsqxIgBY3hsgnVW0dwSEv6fVVTfAR3WbXGiSM3uNsUuc+Rbzb EpZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=CjF3Gy54fRvoPqQakPFQ+kdzkfju16v2ClrMy7QPlzs=; b=xn68V3J8/ml+6O3U7RfZQiFE+HyNxkf/MvZh0Iph6/qRD3pxFSYsMdTmWAN0DZSyzH IgOz+PlisMY1P6p5x5zJ6N4NHNWMMwBTt4gpSyQnCLG7ZHIiZGnuljmh0MqabrZHlUNM dbBdsdHYJBX+n893/z+nnaxBq7l/JsXur00T51tRC8nEw7xzBuq2fzRc/xBFqrsPM92d lMRNGpgFt1jqp7ICZiXrITksPAaaM+RjGcrSaApAEa91hs5cv/efiySuMFzJ5NhrzyeQ Np79MidseNnsMG5jMK2W7litiheIuMpD1gcCIAt/KNUWnlD5pZn74rpDm5zzkWPb98Rq C35A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a9-20020a17090a854900b002024f3f1f8bsi9373922pjw.70.2022.09.26.01.07.42; Mon, 26 Sep 2022 01:07:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233799AbiIZIAa (ORCPT + 99 others); Mon, 26 Sep 2022 04:00:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234407AbiIZH7k (ORCPT ); Mon, 26 Sep 2022 03:59:40 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:12e:520::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD77D37188; Mon, 26 Sep 2022 00:56:44 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1ociyl-0002ma-7Z; Mon, 26 Sep 2022 09:56:39 +0200 Date: Mon, 26 Sep 2022 09:56:39 +0200 From: Florian Westphal To: Michal Hocko Cc: Florian Westphal , linux-mm@kvack.org, linux-kernel@vger.kernel.org, vbabka@suse.cz, akpm@linux-foundation.org, urezki@gmail.com, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, Martin Zaharinov Subject: Re: [PATCH mm] mm: fix BUG with kvzalloc+GFP_ATOMIC Message-ID: <20220926075639.GA908@breakpoint.cc> References: <20220923103858.26729-1-fw@strlen.de> <20220923133512.GE22541@breakpoint.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Michal Hocko wrote: > > kvzalloc(GFP_ATOMIC) was perfectly fine, is this illegal again? > > kvmalloc has never really supported GFP_ATOMIC semantic. It did, you added it: ce91f6ee5b3b ("mm: kvmalloc does not fallback to vmalloc for incompatible gfp flags")