Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp526152rwb; Mon, 26 Sep 2022 02:15:22 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4cy3ekLroCpZj3/yDlX/Ss+OAAHmXUwXLK+NZMR0b67yqcakvkzmbyca+5OtFleKp2DZir X-Received: by 2002:a17:902:e402:b0:176:e82f:3f4 with SMTP id m2-20020a170902e40200b00176e82f03f4mr21283424ple.107.1664183722051; Mon, 26 Sep 2022 02:15:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664183722; cv=none; d=google.com; s=arc-20160816; b=nGUFCWsonfNzZ8dfvxCMmMtt9F3E8AXUYBKSl5BSCMYh7U9tci9Vzs4/aJWY75N3O/ Xhm3X7aInZSniaofhRLIx//Dpb21tCfImTACkiQoYt+dX+8jzZbasDQKRFreF+F7j6+J +IRX10r7RfcMebUmpvaC1pt4sbN2r3qWRRZbRem5t9DW7tocSZBL5lTR86p78iAbhkG6 SAvLAtSFK4qtS0s4ol6UDH1EtD+K7tp1NwvypbDaG1s8lYZG5ZyOwvaYFKEsrNYyyblG Dtn5JQh6TGKmpsfD3bFfUTWqmU7KtIu4JVv+NmBgBW8UyEWd3mPvXOXt6+/aB91Dh6pg +G9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=14658X6JbmP15r9Sn/jYdfLdRQMWW+iIc4Q0SJTfq0k=; b=NvaFI7TQKXspJDI7wF17rEElI5343qtiEx8rc6th5Uh3Z7g5ZsDdKIX4pqFjKorlZt 9h5EKHlACQ1MoucUc6ZQuX7cstScn/evFZNffwErYYVwl05H8t6C1BCTEcSx3/Ai8SgT ECs1FdM1iG3RjUQW9BrPwTj58xca1cxznSkjA2R0bwflFGDxfD7+SH9WkK5VlOwQsnIv U+pPR0OqNn9WYVGIMu8heIfXnufAQA6TKpknjcA/1F1+kj1e8+KrOmMe7uvskTZFgGUm HH622rSaYfUfn29+GT29K0Qh9za/ygNyY4D924JejYNK0E17DDWp98SV5SBSeMSIHNYY 3/9w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lr18-20020a17090b4b9200b001fb4c9b9607si14911149pjb.114.2022.09.26.02.15.09; Mon, 26 Sep 2022 02:15:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234108AbiIZIuk (ORCPT + 99 others); Mon, 26 Sep 2022 04:50:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233680AbiIZIu1 (ORCPT ); Mon, 26 Sep 2022 04:50:27 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:12e:520::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 482E41B7BE; Mon, 26 Sep 2022 01:50:26 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1ocjog-00037R-1a; Mon, 26 Sep 2022 10:50:18 +0200 Date: Mon, 26 Sep 2022 10:50:18 +0200 From: Florian Westphal To: Herbert Xu Cc: Florian Westphal , netdev@vger.kernel.org, tgraf@suug.ch, urezki@gmail.com, Paolo Abeni , "David S. Miller" , Eric Dumazet , Jakub Kicinski , linux-kernel@vger.kernel.org, akpm@linux-foundation.org, Martin Zaharinov , Michal Hocko , Paolo Bonzini , kvm@vger.kernel.org Subject: Re: [PATCH net] rhashtable: fix crash due to mm api change Message-ID: <20220926085018.GA11304@breakpoint.cc> References: <20220926083139.48069-1-fw@strlen.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Herbert Xu wrote: > On Mon, Sep 26, 2022 at 10:31:39AM +0200, Florian Westphal wrote: > > > > This patch is partial revert of > > commit 93f976b5190d ("lib/rhashtable: simplify bucket_table_alloc()"), > > to avoid kvmalloc for ATOMIC case. > > This patch should just be reverted. If kvzalloc fails we should > definitely know about it. No idea what you mean, I am no mind reader. Please consider fixing this yourself, I am done with this crap.