Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 26 Sep 2022 17:37:19 +0800
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     Florian Westphal <fw@strlen.de>
Cc:     netdev@vger.kernel.org, tgraf@suug.ch, urezki@gmail.com,
        Paolo Abeni <pabeni@redhat.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>, linux-kernel@vger.kernel.org,
        akpm@linux-foundation.org, Martin Zaharinov <micron10@gmail.com>,
        Michal Hocko <mhocko@suse.com>,
        Paolo Bonzini <pbonzini@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCH net] rhashtable: fix crash due to mm api change
Message-ID: <YzFyz5FWn50rhLsH@gondor.apana.org.au>
References: <20220926083139.48069-1-fw@strlen.de>
 <YzFkt744uWI4y3Sv@gondor.apana.org.au>
 <20220926085018.GA11304@breakpoint.cc>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220926085018.GA11304@breakpoint.cc>
Precedence: bulk

On Mon, Sep 26, 2022 at 10:50:18AM +0200, Florian Westphal wrote:
> Herbert Xu <herbert@gondor.apana.org.au> wrote:
> > On Mon, Sep 26, 2022 at 10:31:39AM +0200, Florian Westphal wrote:
> > >
> > > This patch is partial revert of
> > > commit 93f976b5190d ("lib/rhashtable: simplify bucket_table_alloc()"),
> > > to avoid kvmalloc for ATOMIC case.
> > 
> > This patch should just be reverted.  If kvzalloc fails we should
> > definitely know about it.
> 
> No idea what you mean, I am no mind reader.  Please consider
> fixing this yourself, I am done with this crap.

I just meant that the patch quoted above should be completely
reverted instead of partially reverted.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt