Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp586644rwb; Mon, 26 Sep 2022 03:18:38 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4dijRN+AO6ykVpOVqOr6p0DQmzPsdao+EiC2EZb5mP2LVOE+OcmFjP0G+Yu7qhB+vS9LqC X-Received: by 2002:a17:907:da2:b0:782:b6a:326d with SMTP id go34-20020a1709070da200b007820b6a326dmr17354830ejc.429.1664187518192; Mon, 26 Sep 2022 03:18:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664187518; cv=none; d=google.com; s=arc-20160816; b=yBrBrpUl12GX0/2Gffio8e9W2dqgrG9E8Y3ZvstNeEB9M3/Lv1LseNas3CvCyxsxID MuOzCPqiEEPihsjOV0G1CxfPX3XaTayI38OODtci2y26BNpWTqEob6jSYWyw1B3m3ERW CrY6ulljfPTx5BHQfY1oKA0HHotW0qJ74DFYUqzj1sWpnDruZCzVTcODWfLNo/cvD+WF 6vhioQuSeL2bJ2htLMQYxlbkfY6hLsPFULac+WTwm55/+p1Y3DCbInp04uR/fnkQiGY9 2Cuw5jukslK9z9YtRza2LIpppZBLOGMUeT1qraH+pizMX31XYy/NoAhs85w2DftcEvIi ISrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:references :in-reply-to:mime-version:dkim-signature; bh=MTbDAGtdQOyjwr3VuUNM3DoGtToFj5T4CqFl3/zr8u0=; b=NGeTc9T1cXSY/VuYPkFwz8NvvZ4OpmF5gR/L9MowbPmChXoBktNDlRPy+LAfx6gcBL lJqxG/QR4WwYHec6TJRwVBrk/NZieGFlFY1Cl9du5fJRBkkUEnWQ7JK8C3PdKqntGF+L 5f/gtjuHZYRbOI7GBErcX4F9+uhxhYpNVUk17k5/e8GEmZOYOn4lwsO2RaQEVFuxbzz3 vNJS7Xrn4BieSsRAAYySXsLYT0Iek8L84nhN9hqyAUJWclIFJo8dQ5tUKmUdEG+tVIlw +u/Tvx1/P3r7qiT+gZvY3W201ne/0eo8T2gbftPB+6GZSLD4prWoQtd0JIBf5fQ+65IU jN3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=McsYbKM2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=zx2c4.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d11-20020a50fb0b000000b004573e23619esi2736982edq.91.2022.09.26.03.18.11; Mon, 26 Sep 2022 03:18:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=McsYbKM2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=zx2c4.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235020AbiIZKGb (ORCPT + 99 others); Mon, 26 Sep 2022 06:06:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234886AbiIZKGS (ORCPT ); Mon, 26 Sep 2022 06:06:18 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A979399F1 for ; Mon, 26 Sep 2022 03:06:13 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D0F2760B4A for ; Mon, 26 Sep 2022 10:06:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 07E15C433D7 for ; Mon, 26 Sep 2022 10:06:11 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="McsYbKM2" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1664186769; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MTbDAGtdQOyjwr3VuUNM3DoGtToFj5T4CqFl3/zr8u0=; b=McsYbKM28gBwvCorerQPM9GQ49ewfnPnXPOfKLQFHihpyhA85IwdjB/VbjDY9+dSfJ/jNo UWsoHoBoDByVcefWTwb+yK9mhm47uRv/fK49jmMVeCBACNV4/ebMUSBd1SSUD9vV5H1A0F RCwrT8a4Rb7UtVLmNh7q30+tHq6jrCM= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 897955d2 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Mon, 26 Sep 2022 10:06:08 +0000 (UTC) Received: by mail-vs1-f41.google.com with SMTP id p4so5992658vsa.9 for ; Mon, 26 Sep 2022 03:06:08 -0700 (PDT) X-Gm-Message-State: ACrzQf1NGCoFP4ySg5oGe9X7MErIqJNalPjEdEgb9QYCMKakw55xDLzX +pcJXzHG2na7d93XNKxfZrvGav4VYpBZwTkiRik= X-Received: by 2002:a05:6102:2908:b0:398:ac40:d352 with SMTP id cz8-20020a056102290800b00398ac40d352mr6526004vsb.55.1664186767749; Mon, 26 Sep 2022 03:06:07 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:ab0:2ea6:0:b0:3ae:9878:9be with HTTP; Mon, 26 Sep 2022 03:06:07 -0700 (PDT) In-Reply-To: References: <20220923170340.4099226-1-Jason@zx2c4.com> From: "Jason A. Donenfeld" Date: Mon, 26 Sep 2022 12:06:07 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 1/3] m68k: process bootinfo records before saving them To: Geert Uytterhoeven Cc: linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Geert, On 9/26/22, Geert Uytterhoeven wrote: > On Fri, Sep 23, 2022 at 7:03 PM Jason A. Donenfeld wrote: >> The RNG seed boot record is memzeroed after processing, in order to >> preserve forward secrecy. By saving the bootinfo for procfs prior to >> that, forward secrecy is violated, since it becomes possible to recover >> past states. So, save the bootinfo block only after first processing >> them. >> >> Fixes: a1ee38ab1a75 ("m68k: virt: Use RNG seed from bootinfo block") >> Signed-off-by: Jason A. Donenfeld > > Reviewed-by: Geert Uytterhoeven Thanks for the review. Did you intend to take these 3 patches through your m68k tree, or did you want me to take them for some reason instead? Jason