Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp671203rwb; Mon, 26 Sep 2022 04:31:50 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4BhPr2kEcw626uScqL/JHfN/xN4nnEWyC2ewkTz2T9CsUxOcuCuh6A+5i8d49VY6IV4Jou X-Received: by 2002:a05:6402:f07:b0:450:bf95:59e9 with SMTP id i7-20020a0564020f0700b00450bf9559e9mr22028137eda.46.1664191910651; Mon, 26 Sep 2022 04:31:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664191910; cv=none; d=google.com; s=arc-20160816; b=0LZ2VIjRxRDVCJKULu2w7dQp6kmGcFyvYf39QYwJOoj4HLzzA+Vcn887wYxCUgV2HO lgos+y0JVKWHSgDTM8RbY6pKNDsGR6IDZlbJsOCsUz4h1aEFq70MdHHqB98NtZUukFpw JW1h/Caz9f5XA12jVM88it3fF3gHMQQ7rpYDVKi2HHwakw/piMl4m8hcHXc5HLlg5z/8 nRQ/VEp7L40u8Fnvc2r6zWzt7hZEUCWaaZs6Kejr6+lNJD9JZqaNzbjT3h5/QXauXSe7 GtHWk4JReXP1+4gUYTeU4tcGGEa+iaFdirXtzj2HrzmiS/jJYRLGeoK21mrj1gN37uyH CJvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=aRL1KwelePVdzEbbfFqUs5m58Y7dzZUAAChOnI+z5JE=; b=fTR6gKB9XkeBD9k+cshPWq8K+exV3GCeJ7Y+mPyz/5Tw+XjgLIJUWcSzpV0DQ0L3e6 5Wl/jIrdCpy0zwHbT0uLX34sl4N2rDAlhHh1QPEGmQm6ZqUh4SylB1x5oK03NDBEgkhi ATocz++CfzA5IMq0/Rb0vOs1xPCJgbpXAw4v9SXkjk9OiE6s/d0mwGxmkmVemWvT+kJ8 sagyeX5OITtZFQ9XuI2xh4DsgCts6DQh+lf4RvlrO8lgtkahv7yqLLQ2gLe1zFuAa/To gU+BHXukwBtjdk5x/CMswwoz7EVaUGB+GRpqmA+wyAzpmYIFJr4rYWITV9t3UT4Rwc3Y msGA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=XU9yTuy7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fj20-20020a0564022b9400b004537a3c4982si5848109edb.601.2022.09.26.04.31.24; Mon, 26 Sep 2022 04:31:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=XU9yTuy7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235725AbiIZKb0 (ORCPT + 99 others); Mon, 26 Sep 2022 06:31:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54292 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235788AbiIZK3H (ORCPT ); Mon, 26 Sep 2022 06:29:07 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9AE54E86A; Mon, 26 Sep 2022 03:19:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664187558; x=1695723558; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Yic0GwGpixPkuYrr1AQ7VR1nKuBMpremGARqqE5/85A=; b=XU9yTuy7gqms4TQfoqNBXrkehFyXfi5nnUdoqY8K0au6cEyoe3WWLCCQ pfhkE6NyahzWJlBEtGTxn1MrQji2wv0CDB9uhGd4j6BLJ61yatZd4Sa5a IeEl5cwwWNPP6L5KiGXC1JVdOuPUH74Y0OG1gAUdMJJ2oFd/54dSR/hjg tTzo2mbB+Miws+zsrBMXmEiPM6nMzQCzJrW5Pmjv+dF6fai+rMeVErNS1 Z93HsB+3P71+zN3A2EPI4XtiZn6Lntyz8W0RTJmfTo3gkD0lWI1kkSdqW OuiuQOmu+CdzA6kSU7ynon8ishHQ4riM0AClIdcjHfkKHv8alwlOBdXM7 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10481"; a="302459750" X-IronPort-AV: E=Sophos;i="5.93,345,1654585200"; d="scan'208";a="302459750" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Sep 2022 03:19:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10481"; a="651773562" X-IronPort-AV: E=Sophos;i="5.93,345,1654585200"; d="scan'208";a="651773562" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga008.jf.intel.com with ESMTP; 26 Sep 2022 03:19:05 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1oclCZ-007kP2-2R; Mon, 26 Sep 2022 13:19:03 +0300 Date: Mon, 26 Sep 2022 13:19:03 +0300 From: Andy Shevchenko To: Andrey Smirnov Cc: Ferry Toth , Greg Kroah-Hartman , Felipe Balbi , Thinh Nguyen , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Thinh Nguyen , Sven Peter Subject: Re: [PATCH v4] usb: dwc3: Don't switch OTG -> peripheral if extcon is present Message-ID: References: <20220403164907.662860-1-andrew.smirnov@gmail.com> <691c3073-5105-9a2b-e6f2-ea0a4b8aaea8@gmail.com> <966ef528-455c-5180-fc63-ea77cb933af1@gmail.com> <331b5644-e204-8915-cd08-bd4fabbfcb49@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 25, 2022 at 10:43:07PM -0700, Andrey Smirnov wrote: > On Sun, Sep 25, 2022 at 12:21 PM Ferry Toth wrote: ... > I think we'd want to figure out why the ordering is important if we > want to justify the above fix. At least we all on the same page (I hope) on justification for reverts. ... > IMHO instead of trying to rush something in it be prudent to revert my > patch _and_ address the fact that above patch was lost during the > merge (Andy's revert needs to be updated) I'm not an expert in your fixes for DWC3, so please come up with the solution sooner than later, otherwise I will try to get my reverts into the final release, because they obviously fix the regression. -- With Best Regards, Andy Shevchenko