Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753210AbXFVFLP (ORCPT ); Fri, 22 Jun 2007 01:11:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751481AbXFVFLB (ORCPT ); Fri, 22 Jun 2007 01:11:01 -0400 Received: from netops-testserver-4-out.sgi.com ([192.48.171.29]:57975 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751215AbXFVFLA (ORCPT ); Fri, 22 Jun 2007 01:11:00 -0400 Date: Thu, 21 Jun 2007 22:10:59 -0700 (PDT) From: Christoph Lameter X-X-Sender: clameter@schroedinger.engr.sgi.com To: Hugh Dickins cc: Nicolas Ferre , ARM Linux Mailing List , Linux Kernel list , Marc Pignat , Andrew Victor , Pierre Ossman , Andrew Morton , Linus Torvalds , Russell King Subject: Re: Oops in a driver while using SLUB as a SLAB allocator In-Reply-To: Message-ID: References: <467A4532.40301@rfo.atmel.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1167 Lines: 25 On Fri, 22 Jun 2007, Hugh Dickins wrote: > However... what gives you confidence that flush_dcache_page is > never applied to other slab pages? Flush dcache page is supposed to run on pages not objects of varying length. It is suprising that this has not lead to earlier problems. Objects allocated this way may straddle a page boundary under some conditions and in that case virt_to_page may not lead to a page that covers the complete object that is supposed to be flushed. Hopefully the "size" of the allocated object were whole pages. > This looks to me like a clean way forward to try in -mm; but that > 2.6.22 should go with the safety PageSlab test in page_mapping. 2.6.22 cleans up these issues and this one follows in those footsteps. The reason for the introduction of the quicklist f.e. was to have a clear separation between page sized allocation and the variable allocations through slab allocators. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/