Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 26 Sep 2022 13:48:48 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Magnus Damm <damm+renesas@opensource.se>,
        linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
        Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v2 1/1] serdev: Replace poll loop by readx_poll_timeout()
 macro
Message-ID: <YzGDkKnttYBI4S0Q@smile.fi.intel.com>
References: <20220923171048.37386-1-andriy.shevchenko@linux.intel.com>
 <Yy7wqSWVBGwNtiiZ@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Yy7wqSWVBGwNtiiZ@kroah.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Sat, Sep 24, 2022 at 01:57:29PM +0200, Greg Kroah-Hartman wrote:
> On Fri, Sep 23, 2022 at 08:10:48PM +0300, Andy Shevchenko wrote:
> > The readx_poll_timeout() consolidates the necessary code under
> > macro. Replace current code with it.

...

> > +#include <vdso/time64.h>
> 
> Ick, just for USEC_PER_MSEC?  That should be in units.h, not burried in
> a vdso-only .h file.  This feels wrong, sorry.

Why are you asking me about this? It was not my choice and it was made
a couple of years ago (see [1]).

As a solution I can just drop using that constant in v3.

[1]: b72a9c5e023b ("linux/time64.h: Extract common header for vDSO")


-- 
With Best Regards,
Andy Shevchenko