Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d8224556-72cb-cb48-b530-05cffab2a6df@suse.com>
Date:   Mon, 26 Sep 2022 12:47:42 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH net] usbnet: Fix memory leak in usbnet_disconnect()
To:     Peilin Ye <yepeilin.cs@gmail.com>,
        Oliver Neukum <oneukum@suse.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>
Cc:     Peilin Ye <peilin.ye@bytedance.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Ming Lei <ming.lei@canonical.com>,
        Cong Wang <cong.wang@bytedance.com>, netdev@vger.kernel.org,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
References: <0000000000004027ca05e8d2ac0a@google.com>
 <20220923042551.2745-1-yepeilin.cs@gmail.com>
Content-Language: en-US
From:   Oliver Neukum <oneukum@suse.com>
In-Reply-To: <20220923042551.2745-1-yepeilin.cs@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bXNaQllRaU1rbUNRVzhSLzdBRGM5dVBaUnYxeU15bUMyTndPcHBDRC8yR1lt?=
 =?utf-8?B?bTI3OTV2S0g0TWtKaWNZbkc0WGxQWjdtdkpUcUVYUkdKa3hTNUV5SGhWTWs3?=
 =?utf-8?B?b3hHMGNIWTZRRzJvR2dpaDgwb2pORkw5bktzaDJFNWJVczFFT2tMNzlmREJZ?=
 =?utf-8?B?K3VlMnhBUWtram1mdUJHS2ExVCt4Wk5GS3hIVk1aM2dnakp2VG94cG8rY3ZI?=
 =?utf-8?B?WnU4UGdKVkVBZVJKMENPdTh4NmIySThOY1pPUlVLZ2I4RXVVWVI3UyswTzFx?=
 =?utf-8?B?MlNka1B0QnVZUWptTnozeVExRU9uN0Z2WkVwcENZYVpmVVlWanJKVWNKeGlX?=
 =?utf-8?B?RFZVYjl6UXZ0Rk9icjhjQ2lNeFY5T1g2V1p6TlRoZHlQenlVcmNRcnFMNHFs?=
 =?utf-8?B?NFVFZzA0aTI4TVl1S3R2WU55SEtRczEreW5LN1RaVG85Q1BXK2NyL3VjWGxv?=
 =?utf-8?B?aUJDYVJRTnJWanhBWmtHL2VIUCtnVDg4VVBPZzFjUVZjaDA5M3ZvTzc4c1JU?=
 =?utf-8?B?c1NjOFI5YXdMaDYvN2lkcDBZK1ZiekVsYVAxS1o5NzNjUU00c2xNczlhYTBG?=
 =?utf-8?B?V1BXRWFVeFEyNGVtdi9nK3JmcloxNEgvMzUvUUdTR1dtaHVGbjhmWkxNWkZ5?=
 =?utf-8?B?ajR0NnJnM1F2M3drYjZhdi8za0ppYzgvbWhMRXZWTSs3YmdjaSsrUWNjaW9o?=
 =?utf-8?B?QmVpbWMzQ2l6S3B3dWVXM09wYnYxTzVlOUZIZzhqN0hBbkxQRVVqM0dBOWpF?=
 =?utf-8?B?dzhCRzhYZzVRVTdoODBtblBwNlJHMk5tcmR5R2RFbXlSVGdLS1BHbkxLZFl5?=
 =?utf-8?B?bXRsUEl2ZWpWWG54aTh4U2I1RzR4YWJNQ09YbkxleStsRmVrSUoxTG9vcXBK?=
 =?utf-8?B?T2xtQ0cwU3VCNG5xMXdrcUhyOTdzMVFNa2JmYzZUL2lpNHRncW5ZL0FWRDZH?=
 =?utf-8?B?bHJ1YWlkVHhTRkpRYitiNHFYdm9tQmxvU0VnYThGa2xaRUEzRzBiZkNZaVNH?=
 =?utf-8?B?NFBJV1BsNTZBNVZ5Q25xdmwrT1N6MXZTNk93WEhWNnlCTTlQY1pXZ3p4ZmhU?=
 =?utf-8?B?R043NzFyYXlTS1pmTm56aXFMUU9LazE4RlprbmtpSmIyMFpaS1V0Qzd5bGRs?=
 =?utf-8?B?OEhHNzhlSmhBVGdYL0VYL0FWRHBta0g0MnRidU5WUGdreVNoektXVnl4M2JL?=
 =?utf-8?B?S09uUW5LRmFBNkxkOC9zTnpOMndpcjhTeTZQendBLzZoK0srTGxqc1duNGVN?=
 =?utf-8?B?QmJUbW9LOVg0aks0UlFDcUJPMjMwUTJBb3M4SlVPNG1rOXNRb1c5bFE5YUNX?=
 =?utf-8?B?bFU4K1BJZERPeHdaYW5lOFpZbFlCWGtmVytGaVpFeTcrYlpuUUlSeGk2VVl2?=
 =?utf-8?B?YlY1V3h0cjFjai9JRDZvTFBHekRLN1ovTzBBZk9rWkUrZlY4SHduZzJKdElZ?=
 =?utf-8?B?a3EzL2F5RUhBYVBoSkYvRnBJMlhEL1Zzcjhqbjk3R0Q0ckVyVmVMRjk3cENh?=
 =?utf-8?B?Uy9ySFgyM1ZEYnBrbWFqbldNTElvc0hnQkx1T2RLeTh6V2hINndqSlpzZmhj?=
 =?utf-8?B?NlgrREJJSEdoVnpoQjFYU0QxaXFWY3FVcUR1Qko1UDJuR1NLT2o3ekNvYU45?=
 =?utf-8?B?YS9UZ3RFL1dyRnNDeWxGZ28wbE9jWVZVOEZsMjBnSWdMcE1NdUh1V3hML0l1?=
 =?utf-8?B?ZU1CLzFmNDUxRHl4VkltVFcrN1VaVU9kNGNXcXBtNFpkcFlSWE44UzJqRlg4?=
 =?utf-8?B?OWk3NEhobUlCTm9aSWxleFd5bnJBV2I4U1lCWjVQNW1Ic2JNTE11NlllR0xQ?=
 =?utf-8?B?QlZoTzZ0Vk1MeUFQOTR3cVFRS1l6R0Y5YktIZ0NzeG9yNWpzcEdjcjRSY3F2?=
 =?utf-8?B?SVhRN0h0Q25rMnJuWjZRejh4NXpVSUg0L2hYOTRQeHc1SlFJZHZWRW1EVjkr?=
 =?utf-8?B?RjNTUGdUMmkrL2hta3lza3JpVjU2Mm5LNlM0Y1Vwc1cxeGZtdjBNb3ZvOWlJ?=
 =?utf-8?B?VXRkWVcxRkFteUpaR2I5TjAzWXhINVBIZDdZeWUzUzBPbFdNMk5ISUh1dWdQ?=
 =?utf-8?B?Q0ppVVZHT0Y2U0Vhekt0dnBFNkxobmsvZGNLTko4U0c0cDNjdWM2T3d6MlRI?=
 =?utf-8?B?eEo5MmR1aUZBcy81MmtXdHdTRzRpRnZZRUNzbmFhYjF6RVNIYUliTjM4VnA3?=
 =?utf-8?Q?krJIEE7S91cVKKAYPxLfV26axUGx2+sEtyd4FkVnN2c6?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 553ef41a-fa9d-47c4-8db8-08da9fac8b75
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB7104.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 10:47:45.1305
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AIRFtAvM1OAtFNwted+w6DJBrlA2GOWX+zZsL7Pb8uoJCGOR2M7jpHZqd6PHHK/fLas+a8dK4eZdH/BnrZT5rw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7918
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 23.09.22 06:25, Peilin Ye wrote:
Hi,

> I think we may have similar issues at other usb_scuttle_anchored_urbs()
> call sites.  Since urb->context is (void *), should we pass a "destructor"
> callback to usb_scuttle_anchored_urbs(), or replace this function with
> usb_get_from_anchor() loops like this patch does?
> 

please introduce a new function with an additional parameter
for that, so that we do not need to touch the correct usages.

	Regards
		Oliver